xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Paul Semel <semelpaul@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	wei.liu2@citrix.com, Paul Semel <semelpaul@gmail.com>,
	JBeulich@suse.com
Subject: [PATCH v2] fuzz/x86_emulate: fix bounds for input size
Date: Fri, 23 Feb 2018 23:48:57 +0100	[thread overview]
Message-ID: <20180223224857.10212-1-semelpaul@gmail.com> (raw)
In-Reply-To: <20180223163009.b42xfl3euanth3b7@citrix.com>

The maximum size for the input size was set to INPUT_SIZE, which is actually
the size of the data array inside the fuzz_corpus structure and so was not
abling user (or AFL) to fill in the whole structure. Changing to
sizeof(struct fuzz_corpus) correct this problem.

Signed-off-by: Paul Semel <semelpaul@gmail.com>
---
 tools/fuzz/x86_instruction_emulator/fuzz-emul.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
index 964682aa1a..0ada613f52 100644
--- a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
+++ b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
@@ -33,6 +33,7 @@ struct fuzz_corpus
     unsigned char data[INPUT_SIZE];
 } input;
 #define DATA_OFFSET offsetof(struct fuzz_corpus, data)
+#define FUZZ_CORPUS_SIZE (sizeof(struct fuzz_corpus))
 
 /*
  * Internal state of the fuzzing harness.  Calculated initially from the input
@@ -828,7 +829,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data_p, size_t size)
         return 1;
     }
 
-    if ( size > INPUT_SIZE )
+    if ( size > FUZZ_CORPUS_SIZE )
     {
         printf("Input too large\n");
         return 1;
@@ -859,8 +860,6 @@ int LLVMFuzzerTestOneInput(const uint8_t *data_p, size_t size)
 
 unsigned int fuzz_minimal_input_size(void)
 {
-    BUILD_BUG_ON(DATA_OFFSET > INPUT_SIZE);
-
     return DATA_OFFSET + 1;
 }
 
-- 
2.16.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-02-23 22:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 12:39 [xen-devel] [fuzz] [x86 emulator] Input size Paul Semel
2018-02-22 18:00 ` Wei Liu
2018-02-22 23:57   ` [PATCH] fuzz/x86_emulate: fix bounds for input size Paul Semel
2018-02-23  8:20     ` Paul Semel
2018-02-23 10:44     ` George Dunlap
2018-02-23 12:07       ` Paul Semel
2018-02-23 16:30     ` Wei Liu
2018-02-23 16:33       ` George Dunlap
2018-02-23 16:37         ` Wei Liu
2018-02-23 22:41       ` Paul Semel
2018-02-23 22:48       ` Paul Semel [this message]
2018-02-26 10:33         ` [PATCH v2] " Wei Liu
2018-03-02 12:30           ` Wei Liu
2018-02-27 10:39         ` George Dunlap
2018-02-28 17:30           ` Paul Semel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180223224857.10212-1-semelpaul@gmail.com \
    --to=semelpaul@gmail.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).