From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 3/7] x86/alt: Clean up the assembly used to generate alternatives
Date: Mon, 26 Feb 2018 14:09:23 +0000 [thread overview]
Message-ID: <20180226140923.e5tjec5shjxtpfan@MacBook-Pro-de-Roger.local> (raw)
In-Reply-To: <1519644904-11349-4-git-send-email-andrew.cooper3@citrix.com>
On Mon, Feb 26, 2018 at 11:35:00AM +0000, Andrew Cooper wrote:
> * On the C side, switch to using local lables rather than hardcoded numbers.
> * Rename parameters and lables to be consistent with alt_instr names, and
> consistent between the the C and asm versions.
> * On the asm side, factor some expressions out into macros to aid clarity.
> * Consistently declare section attributes.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-26 14:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 11:34 [PATCH RESEND v2 0/7] x86/alternatives: Support for automatic padding calculations Andrew Cooper
2018-02-26 11:34 ` [PATCH v2 1/7] x86/alt: Drop unused alternative infrastructure Andrew Cooper
2018-02-26 11:34 ` [PATCH v2 2/7] x86/alt: Clean up struct alt_instr and its users Andrew Cooper
2018-02-26 11:35 ` [PATCH v2 3/7] x86/alt: Clean up the assembly used to generate alternatives Andrew Cooper
2018-02-26 14:09 ` Roger Pau Monné [this message]
2018-02-28 15:59 ` Jan Beulich
2018-03-01 12:44 ` Wei Liu
2018-02-26 11:35 ` [PATCH v2 4/7] x86/asm: Remove opencoded uses of altinstruction_entry Andrew Cooper
2018-02-26 11:35 ` [PATCH v2 5/7] x86/alt: Support for automatic padding calculations Andrew Cooper
2018-02-28 16:16 ` Jan Beulich
2018-02-28 17:26 ` Andrew Cooper
2018-03-01 7:26 ` Jan Beulich
2018-02-26 11:35 ` [PATCH v2 6/7] x86/alt: Drop explicit padding of origin sites Andrew Cooper
2018-02-26 11:35 ` [PATCH v2 7/7] x86/build: Use new .nop directive when available Andrew Cooper
2018-02-26 12:31 ` Roger Pau Monné
2018-02-26 13:08 ` Andrew Cooper
2018-02-26 14:27 ` Roger Pau Monné
2018-02-28 16:22 ` Jan Beulich
2018-02-28 17:45 ` Andrew Cooper
2018-03-01 7:28 ` Jan Beulich
2018-03-01 10:36 ` Roger Pau Monné
2018-03-01 10:54 ` Jan Beulich
2018-03-01 16:58 ` Andrew Cooper
2018-03-02 7:10 ` Jan Beulich
2018-03-02 19:34 ` Andrew Cooper
2018-03-05 8:33 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226140923.e5tjec5shjxtpfan@MacBook-Pro-de-Roger.local \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).