From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Usage of DEBUG_DIR breaks OVMF build Date: Wed, 28 Feb 2018 18:01:51 +0100 Message-ID: <20180228170147.GA1707@aepfle.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0001606627587547564==" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============0001606627587547564== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G" Content-Disposition: inline --k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=utf-8 Content-Disposition: inline The default DEBUG_DIR=/usr/lib/debug can not be used for rpm builds because that directory is "owned" by rpm-packaging itself to store the autogenerated ${pkg}-debuginfo.rpm data. Thats why I set it to /boot. This worked fine until recently, only /boot/xen-syms was affected by that change, and in fact only the "xen" build needed DEBUG_DIR as make cmdline option. Now tools/firmware/Makefile also uses DEBUG_DIR. To set DEBUG_DIR the tools build must be done like "make DEBUG_DIR=/my/dir". But this breaks build with --enable-ovmf because ovmf.git makes use of the very same variable. For some reason it can not deal with a custom value, some autogenerated file will not be found: [ 126s] make[8]: *** No rule to make target '/boot/AutoGen.h', needed by '/home/abuild/rpmbuild/BUILD/xen-4.11.20180228T150620.cb671efbf1/non-dbg/tools/firmware/ovmf-dir-remote/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/ResetVector/ResetVector/OUTPUT/ResetVector.bin'. I think the only option to support rpm packaging is to rename DEBUG_DIR to XEN_DEBUG_DIR. Any objections to that? Olaf --k1lZvvs/B4yU6o8G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWpbgdgAKCRBdQqD6ppg2 ft8VAKCZfwQTpTGeqJnWo/xjKTFlSLF4dACgxoC5lRseoENoiJP/jI6czV4BTBE= =QP9d -----END PGP SIGNATURE----- --k1lZvvs/B4yU6o8G-- --===============0001606627587547564== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============0001606627587547564==--