From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Maran Wilson <maran.wilson@oracle.com>
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com,
linus.walleij@linaro.org, dave.hansen@linux.intel.com,
JBeulich@suse.com, hpa@zytor.com, tglx@linutronix.de,
x86@kernel.org, hch@infradead.org, mingo@redhat.com,
xen-devel@lists.xenproject.org, bp@suse.de,
thomas.lendacky@amd.com, luto@kernel.org, jpoimboe@redhat.com,
boris.ostrovsky@oracle.com, mchehab@kernel.org, jgross@suse.com,
andrew.cooper3@citrix.com, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
pbonzini@redhat.com, davem@davemloft.net,
kirill.shutemov@linux.intel.com, roger.pau@citrix.com
Subject: Re: [RFC PATCH v4 6/7] xen/pvh: Add memory map pointer to hvm_start_info struct
Date: Thu, 1 Mar 2018 10:23:40 -0500 [thread overview]
Message-ID: <20180301152340.GI15623@char.us.oracle.com> (raw)
In-Reply-To: <1519842483-8887-7-git-send-email-maran.wilson@oracle.com>
On Wed, Feb 28, 2018 at 10:28:02AM -0800, Maran Wilson wrote:
> The start info structure that is defined as part of the x86/HVM direct boot
> ABI and used for starting Xen PVH guests would be more versatile if it also
> included a way to pass information about the memory map to the guest. This
> would allow KVM guests to share the same entry point.
>
> Signed-off-by: Maran Wilson <maran.wilson@oracle.com>
> ---
> include/xen/interface/hvm/start_info.h | 50 +++++++++++++++++++++++++++++++++-
> 1 file changed, 49 insertions(+), 1 deletion(-)
>
> diff --git a/include/xen/interface/hvm/start_info.h b/include/xen/interface/hvm/start_info.h
> index 648415976ead..80cfbd35c1af 100644
> --- a/include/xen/interface/hvm/start_info.h
> +++ b/include/xen/interface/hvm/start_info.h
> @@ -33,7 +33,7 @@
> * | magic | Contains the magic value XEN_HVM_START_MAGIC_VALUE
> * | | ("xEn3" with the 0x80 bit of the "E" set).
> * 4 +----------------+
> - * | version | Version of this structure. Current version is 0. New
> + * | version | Version of this structure. Current version is 1. New
Have you checked if there are any OSes that end up checking this value at all?
Perhaps also expand the comment to say that for PV guests only 0 is allowed.
For PVH 0 or 1 is allowed ?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-01 15:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 18:27 [RFC PATCH v4 0/7] KVM: x86: Allow Qemu/KVM to use PVH entry point Maran Wilson
2018-02-28 18:27 ` [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH Maran Wilson
2018-02-28 18:27 ` [RFC PATCH v4 2/7] xen/pvh: Move PVH entry code out of Xen specific tree Maran Wilson
2018-02-28 18:27 ` [RFC PATCH v4 3/7] xen/pvh: Create a new file for Xen specific PVH code Maran Wilson
2018-02-28 18:28 ` [RFC PATCH v4 4/7] xen/pvh: Move Xen specific PVH VM initialization out of common code Maran Wilson
2018-02-28 18:28 ` [RFC PATCH v4 5/7] xen/pvh: Move Xen code for getting mem map via hcall out of common file Maran Wilson
2018-02-28 18:28 ` [RFC PATCH v4 6/7] xen/pvh: Add memory map pointer to hvm_start_info struct Maran Wilson
2018-02-28 18:28 ` [RFC PATCH v4 7/7] KVM: x86: Allow Qemu/KVM to use PVH entry point Maran Wilson
[not found] ` <1519842483-8887-3-git-send-email-maran.wilson@oracle.com>
2018-02-28 21:08 ` [RFC PATCH v4 2/7] xen/pvh: Move PVH entry code out of Xen specific tree Konrad Rzeszutek Wilk
[not found] ` <20180228210814.GK11576@char.us.oracle.com>
2018-02-28 21:35 ` Paolo Bonzini
[not found] ` <e9133f97-7ecf-2868-6883-3f0cda7bbb2f@redhat.com>
2018-03-01 6:11 ` Juergen Gross
[not found] ` <20f82d4c-9591-7770-aeca-0331a7940f5d@suse.com>
2018-03-01 8:46 ` Paolo Bonzini
[not found] ` <98eda294-8491-35a2-b278-aeedc079640f@redhat.com>
2018-03-01 16:15 ` Boris Ostrovsky
2018-03-01 17:22 ` Maran Wilson
[not found] ` <1519842483-8887-4-git-send-email-maran.wilson@oracle.com>
2018-02-28 21:09 ` [RFC PATCH v4 3/7] xen/pvh: Create a new file for Xen specific PVH code Konrad Rzeszutek Wilk
2018-02-28 21:39 ` [RFC PATCH v4 0/7] KVM: x86: Allow Qemu/KVM to use PVH entry point Paolo Bonzini
[not found] ` <1519842483-8887-5-git-send-email-maran.wilson@oracle.com>
2018-02-28 21:10 ` [RFC PATCH v4 4/7] xen/pvh: Move Xen specific PVH VM initialization out of common code Konrad Rzeszutek Wilk
2018-03-01 7:20 ` Juergen Gross
2018-03-01 16:05 ` Boris Ostrovsky
[not found] ` <d9b1e5ef-af73-d2cb-0f3d-f41cdc8f35cd@oracle.com>
2018-03-01 17:43 ` Maran Wilson
[not found] ` <1519842483-8887-6-git-send-email-maran.wilson@oracle.com>
2018-03-01 7:21 ` [RFC PATCH v4 5/7] xen/pvh: Move Xen code for getting mem map via hcall out of common file Juergen Gross
[not found] ` <1519842483-8887-8-git-send-email-maran.wilson@oracle.com>
2018-03-01 7:31 ` [RFC PATCH v4 7/7] KVM: x86: Allow Qemu/KVM to use PVH entry point Juergen Gross
[not found] ` <1519842483-8887-2-git-send-email-maran.wilson@oracle.com>
2018-02-28 21:07 ` [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH Konrad Rzeszutek Wilk
[not found] ` <20180228210734.GJ11576@char.us.oracle.com>
2018-03-01 5:43 ` Juergen Gross
2018-03-01 7:19 ` Juergen Gross
2018-03-01 15:02 ` Boris Ostrovsky
[not found] ` <5be04d96-aa10-a022-2597-f7f40138f8f8@oracle.com>
2018-03-01 15:17 ` Paolo Bonzini
[not found] ` <8cdb96db-0771-f062-e0ea-54b4171d6a98@redhat.com>
2018-03-01 17:24 ` Maran Wilson
[not found] ` <1519842483-8887-7-git-send-email-maran.wilson@oracle.com>
2018-03-01 7:29 ` [RFC PATCH v4 6/7] xen/pvh: Add memory map pointer to hvm_start_info struct Juergen Gross
[not found] ` <81b64427-4d4e-8758-436a-f2b98e3e6829@suse.com>
2018-03-01 7:41 ` Jan Beulich
[not found] ` <5A97AEC70200007800128C14@prv-mh.provo.novell.com>
2018-03-01 17:19 ` Maran Wilson
2018-03-01 15:23 ` Konrad Rzeszutek Wilk [this message]
2018-03-20 19:16 ` [PATCH v5 0/7] KVM: x86: Allow Qemu/KVM to use PVH entry point Maran Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301152340.GI15623@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=maran.wilson@oracle.com \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=roger.pau@citrix.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).