From: Igor Mammedov <imammedo@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>,
"open list:X86" <xen-devel@lists.xenproject.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 08/30] hw/i386: use the BYTE-based definitions
Date: Mon, 5 Mar 2018 14:00:36 +0100 [thread overview]
Message-ID: <20180305140036.2f8c705a@redhat.com> (raw)
In-Reply-To: <20180305132915.4dacc461@redhat.com>
On Mon, 5 Mar 2018 13:29:15 +0100
Igor Mammedov <imammedo@redhat.com> wrote:
> On Thu, 15 Feb 2018 01:28:38 -0300
> Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> > It ease code review, unit is explicit.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> [...]
>
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index deb440f286..9ccc6192b5 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -2320,8 +2320,8 @@ build_tpm2(GArray *table_data, BIOSLinker *linker, GArray *tcpalog)
> > (void *)tpm2_ptr, "TPM2", sizeof(*tpm2_ptr), 4, NULL, NULL);
> > }
> >
> > -#define HOLE_640K_START (640 * 1024)
> > -#define HOLE_640K_END (1024 * 1024)
> > +#define HOLE_640K_START (640 * K_BYTE)
> > +#define HOLE_640K_END (1024 * K_BYTE)
> nit:
> could be 1 * M_BYTE
>
> [...]
>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
taking it back
While building it, I get:
In file included from qemu/hw/acpi/ich9.c:38:0:
qemu/include/hw/i386/ich9.h:25:28: error: ‘K_BYTE’ undeclared here (not in a function)
#define ICH9_CC_SIZE (16 * K_BYTE) /* Chipset configuration registers */
^
qemu/include/hw/i386/ich9.h:56:25: note: in expansion of macro ‘ICH9_CC_SIZE’
uint8_t chip_config[ICH9_CC_SIZE];
^
make: *** [hw/acpi/ich9.o] Error 1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-05 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180215042900.16078-1-f4bug@amsat.org>
2018-02-15 4:28 ` [PATCH 08/30] hw/i386: use the BYTE-based definitions Philippe Mathieu-Daudé
2018-03-05 12:29 ` Igor Mammedov
[not found] ` <20180305132915.4dacc461@redhat.com>
2018-03-05 13:00 ` Igor Mammedov [this message]
2018-02-15 4:28 ` [PATCH 22/30] hw/display: " Philippe Mathieu-Daudé
2018-02-15 10:02 ` Gerd Hoffmann
2018-02-15 4:29 ` [PATCH 30/30] xen: " Philippe Mathieu-Daudé
2018-02-15 11:00 ` Alan Robinson
2018-02-15 12:23 ` Philippe Mathieu-Daudé
[not found] ` <fd9024d9-be99-653a-2e88-2d2d21f47dbd@amsat.org>
2018-02-15 13:28 ` Alan Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305140036.2f8c705a@redhat.com \
--to=imammedo@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).