Re: [PATCH] tools/xenstore: add libdl dependency to libxenstore

[Olaf Hering <olaf@aepfle.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1251 bytes --]

On Wed, Mar 07, Juergen Gross wrote:

> On 07/03/18 13:06, ian.jackson@citrix.com wrote:
> > Juergen Gross writes ("Re: [PATCH] tools/xenstore: add libdl dependency to libxenstore"):
> >> On 07/03/18 12:19, Ian Jackson wrote:
> >>> Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to libxenstore"):
> >>>>  libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl
> >>>> +else
> >>>> +PKG_CONFIG_REMOVE += dl
> >>> What is this ?
> >> -ldl is needed on Linux only, but I didn't want to add a Linux specific
> >> pkg-config file. So I'm removing the dependency in case we are not on
> >> Linux.
> > Sorry, I was grepping an older xen tree, so I didn't see where this
> > variable was honoured.
> > Will this work, though, when what has to be done is to remove -ldl
> > from Libs, rather than from Requires ?
> Yes, I've tested it to work (in V2 we have: PKG_CONFIG_REMOVE += -ldl)

This breaks libvirt.
m4/virt-driver-xen.m4 tries to use just '-lxenstore' and the test fails
with missing 'dlsym'. If I adjust this .m4 file to use pkgconfig it
still fails. Only appending '-ldl' to XEN_LIBS will help. So to me it
looks like -ldl is now a hard requirement when linking to
libxenstore.so. I used 20180307T163340.c9bd8a7365 for testing.

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel