From: Wei Liu <wei.liu2@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Marcus of Wetware Labs <marcus@wetwa.re>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] libxl: allow libxl_domain_suspend to simply suspend a domain, without saving it
Date: Fri, 9 Mar 2018 16:55:14 +0000 [thread overview]
Message-ID: <20180309165514.6ttrog5gwchmcurp@citrix.com> (raw)
In-Reply-To: <20180223200326.GI2023@mail-itl>
On Fri, Feb 23, 2018 at 09:03:26PM +0100, Marek Marczykowski-Górecki wrote:
> On Fri, Feb 23, 2018 at 06:47:57PM +0000, Wei Liu wrote:
> > On Fri, Feb 09, 2018 at 12:14:03AM +0100, Marek Marczykowski-Górecki wrote:
> > > When fd=-1, no savefile will be written, but the domain will still be
> > > suspended (but not destroyed). The main reason for this functionality is
> > > to suspend the host while some domains are running, potentially holding
> > > PCI devices. This will give a chance to a driver in such a domain to
> > > properly suspend device.
> > >
> > > It would be better to have separate function for this, but in fact it
> > > should be named libxl_domain_suspend, then the current one renamed to
> > > libxl_domain_save. Since that would break API compatibility, keep it in
> > > the same function.
> > >
> > > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> > > Signed-off-by: Marcus of Wetware Labs <marcus@wetwa.re>
> >
> > The basic idea seems sensible.
> >
> > Please add a comment to libxl.h to specify the new semantics.
>
> Hmm, while I'm looking at it, maybe better idea would be to use flags
> for that? I'd call it LIBXL_SUSPEND_SUSPEND, but it looks stupid, any
> better idea?
I don't have any better idea I'm afraid...
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-03-09 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 23:14 [PATCH] libxl: allow libxl_domain_suspend to simply suspend a domain, without saving it Marek Marczykowski-Górecki
2018-02-09 11:35 ` Roger Pau Monné
2018-02-23 18:47 ` Wei Liu
2018-02-23 20:03 ` Marek Marczykowski-Górecki
2018-03-09 16:55 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309165514.6ttrog5gwchmcurp@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=marcus@wetwa.re \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).