From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: George Dunlap <dunlapg@umich.edu>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Philip Lee <philip.lee@oracle.com>, Joe Jin <joe.jin@oracle.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] xenbaked.c: Avoid divide by zero issue on dump_stats()
Date: Wed, 14 Mar 2018 10:04:55 -0400 [thread overview]
Message-ID: <20180314140455.GB20607@char.us.oracle.com> (raw)
In-Reply-To: <CAFLBxZYME-PKN3HfUa8-Go0teLnWd9ep1fMAGTkYMwT6SxqnNw@mail.gmail.com>
On Wed, Mar 14, 2018 at 10:54:42AM +0000, George Dunlap wrote:
> On Wed, Mar 14, 2018 at 2:24 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> > On Tue, Mar 13, 2018 at 06:38:24PM -0700, Joe Jin wrote:
> >> run_time on dump_stats() maybe zero if break xenmon.py immediately after it
> >
> > s/maybe/can be/
> >> started, then xenbaked hit divide by zero fault.
> >
> > And:
> >
> > "Note that run_time is computed using two values which are retrieved using 'time'
> > system call which gives us resolution in seconds."
>
> Is anyone still using this? Does it even work? I thought we had
Yes as we found out as folks start coming out of the woods with the need
to update their OS thanks to spectre.
They use it with 'xenmon.py' combination.
> talked about removing it at some point.
>
> -George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-03-14 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 1:38 [PATCH] xenbaked.c: Avoid divide by zero issue on dump_stats() Joe Jin
2018-03-14 2:24 ` Konrad Rzeszutek Wilk
2018-03-14 10:54 ` George Dunlap
2018-03-14 14:04 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314140455.GB20607@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=dunlapg@umich.edu \
--cc=ian.campbell@citrix.com \
--cc=joe.jin@oracle.com \
--cc=philip.lee@oracle.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).