Re: [PATCH v3 4/4] libxc: Pass e820 map to PVH guest via hvm_start_info

From: Wei Liu <wei.liu2@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: wei.liu2@citrix.com, boris.ostrovsky@oracle.com,
	xen-devel@lists.xen.org, ian.jackson@eu.citrix.com,
	Maran Wilson <maran.wilson@oracle.com>
Subject: Re: [PATCH v3 4/4] libxc: Pass e820 map to PVH guest via hvm_start_info
Date: Wed, 21 Mar 2018 16:00:29 +0000	[thread overview]
Message-ID: <20180321160028.iyhnwgk4ayhucigr@citrix.com> (raw)
In-Reply-To: <20180316182924.m66vxbe35mbljts4@MacBook-Pro-de-Roger.local>

On Fri, Mar 16, 2018 at 06:29:24PM +0000, Roger Pau Monné wrote:
> On Thu, Mar 15, 2018 at 02:35:18PM -0700, Maran Wilson wrote:
> > From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > 
> > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Signed-off-by: Maran Wilson <maran.wilson@oracle.com>
> > ---
> >  tools/libxc/xc_dom_x86.c | 30 +++++++++++++++++++++++++++++-
> >  1 file changed, 29 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> > @@ -1718,6 +1724,27 @@ static int bootlate_hvm(struct xc_dom_image *dom)
> >  
> >          /* ACPI module 0 is the RSDP */
> >          start_info->rsdp_paddr = dom->acpi_modules[0].guest_addr_out ? : 0;
> > +
> > +        /*
> > +         * Check a couple of XEN_HVM_MEMMAP_TYPEs to verify consistency with
> > +         * their corresponding e820 numerical values.
> > +         */
> > +        BUILD_BUG_ON(XEN_HVM_MEMMAP_TYPE_RAM != E820_RAM);
> > +        BUILD_BUG_ON(XEN_HVM_MEMMAP_TYPE_ACPI != E820_ACPI);
> 
> I guess you could test all the types, but I'm not sure if it's worth
> it, let's see what others think.

TBH I don't really care about this. It is easy enough to spot something
is wrong in the E820 table.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel