xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH 3/5] hvm/mtrr: copy hardware state for Dom0
Date: Thu, 10 May 2018 18:15:03 +0100	[thread overview]
Message-ID: <20180510171505.37309-4-roger.pau@citrix.com> (raw)
In-Reply-To: <20180510171505.37309-1-roger.pau@citrix.com>

Copy the state found on the hardware when creating a PVH Dom0. Since
the memory map provided to a PVH Dom0 is based on the native one using
the same set of MTRR ranges should provide Dom0 with a sane MTRR state
without having to manually build it in Xen.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
 xen/arch/x86/hvm/mtrr.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c
index 95a3deabea..1cb000388a 100644
--- a/xen/arch/x86/hvm/mtrr.c
+++ b/xen/arch/x86/hvm/mtrr.c
@@ -176,6 +176,29 @@ int hvm_vcpu_cacheattr_init(struct vcpu *v)
         ((uint64_t)PAT_TYPE_UC_MINUS << 48) |       /* PAT6: UC- */
         ((uint64_t)PAT_TYPE_UNCACHABLE << 56);      /* PAT7: UC */
 
+    if ( is_hardware_domain(v->domain) )
+    {
+        /* Copy values from the host. */
+        struct domain *d = v->domain;
+        unsigned int i;
+
+        if ( mtrr_state.have_fixed )
+            for ( i = 0; i < NUM_FIXED_MSR; i++ )
+                mtrr_fix_range_msr_set(d, m, i,
+                                      ((uint64_t *)mtrr_state.fixed_ranges)[i]);
+
+        for ( i = 0; i < num_var_ranges; i++ )
+        {
+            mtrr_var_range_msr_set(d, m, MSR_IA32_MTRR_PHYSBASE(i),
+                                   mtrr_state.var_ranges[i].base);
+            mtrr_var_range_msr_set(d, m, MSR_IA32_MTRR_PHYSMASK(i),
+                                   mtrr_state.var_ranges[i].mask);
+        }
+
+        mtrr_def_type_msr_set(d, m, mtrr_state.def_type |
+                                    (mtrr_state.enabled << 10));
+    }
+
     return 0;
 }
 
-- 
2.17.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-05-10 17:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 17:15 [PATCH 0/5] PVH MTRR initial state Roger Pau Monne
2018-05-10 17:15 ` [PATCH 1/5] hvm/mtrr: add emacs local variables block with formatting info Roger Pau Monne
2018-05-10 17:15 ` [PATCH 2/5] hvm/mtrr: use the hardware number of variable ranges for Dom0 Roger Pau Monne
2018-05-14 14:14   ` Jan Beulich
2018-05-10 17:15 ` Roger Pau Monne [this message]
2018-05-14 14:26   ` [PATCH 3/5] hvm/mtrr: copy hardware state " Jan Beulich
2018-05-14 16:33     ` Roger Pau Monné
2018-05-15  7:52       ` Jan Beulich
2018-05-15  8:35         ` Roger Pau Monné
2018-05-15  8:48           ` Jan Beulich
2018-05-15  9:16             ` Roger Pau Monné
2018-05-15  9:50               ` Jan Beulich
2018-05-10 17:15 ` [PATCH 4/5] libxc/pvh: set default MTRR type to write-back Roger Pau Monne
2018-05-14 16:00   ` Wei Liu
2018-05-14 16:02     ` Roger Pau Monné
2018-05-14 16:42       ` Wei Liu
2018-05-14 16:50         ` Wei Liu
2018-05-14 16:53         ` Roger Pau Monné
2018-05-15 11:43   ` Wei Liu
2018-05-15 12:22     ` Jan Beulich
2018-05-10 17:15 ` [PATCH 5/5] docs/pvh: document initial MTRR state Roger Pau Monne
2018-05-14 16:03   ` Wei Liu
2018-05-14 16:13     ` Jan Beulich
2018-05-14 16:18       ` Wei Liu
2018-05-15  7:51         ` Jan Beulich
2018-05-15  8:30           ` Wei Liu
2018-05-15  8:30           ` Roger Pau Monné
2018-05-15  8:38             ` Jan Beulich
2018-05-14 16:16     ` Roger Pau Monné
2018-05-14 16:27       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180510171505.37309-4-roger.pau@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).