From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 01/10] x86/spec_ctrl: Read MSR_ARCH_CAPABILITIES only once Date: Fri, 11 May 2018 10:32:44 -0400 Message-ID: <20180511143244.GU19972@char.us.oracle.com> References: <1526035094-14343-1-git-send-email-andrew.cooper3@citrix.com> <1526035094-14343-2-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1526035094-14343-2-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Juergen Gross , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBNYXkgMTEsIDIwMTggYXQgMTE6Mzg6MDVBTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBNYWtlIGl0IGF2YWlsYWJsZSBmcm9tIHRoZSBiZWdpbm5pbmcgb2YgaW5pdF9zcGVj dWxhdGlvbl9taXRpZ2F0aW9ucygpLCBhbmQKPiBwYXNzIGl0IGludG8gYXBwcm9wcmlhdGUgZnVu Y3Rpb25zLiAgRml4IGFuIFJTQkEgdHlwbyB3aGlsZSBtb3ZpbmcgdGhlCj4gYWZmZWN0ZWQgY29t bWVudC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj aXRyaXguY29tPgpSZXZpZXdlZC1ieTogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxrb25yYWQud2ls a0BvcmFjbGUuY29tPgoKVGhhbmsgeW91IQo+IC0tLQo+IENDOiBKYW4gQmV1bGljaCA8SkJldWxp Y2hAc3VzZS5jb20+Cj4gQ0M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+Cj4gQ0M6IFJv Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgo+IENDOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+Cj4gLS0tCj4gIHhlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyB8IDM0 ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE0 IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKPiBpbmRleCAwMzdl ODRkLi40YWIwZjUwIDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwo+ICsr KyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwo+IEBAIC05NywxOCArOTcsMTUgQEAgc3RhdGlj IGludCBfX2luaXQgcGFyc2VfYnRpKGNvbnN0IGNoYXIgKnMpCj4gIH0KPiAgY3VzdG9tX3BhcmFt KCJidGkiLCBwYXJzZV9idGkpOwo+ICAKPiAtc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFp bHMoZW51bSBpbmRfdGh1bmsgdGh1bmspCj4gK3N0YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRh aWxzKGVudW0gaW5kX3RodW5rIHRodW5rLCB1aW50NjRfdCBjYXBzKQo+ICB7Cj4gICAgICB1bnNp Z25lZCBpbnQgXzdkMCA9IDAsIGU4YiA9IDAsIHRtcDsKPiAtICAgIHVpbnQ2NF90IGNhcHMgPSAw Owo+ICAKPiAgICAgIC8qIENvbGxlY3QgZGlhZ25vc3RpY3MgYWJvdXQgYXZhaWxhYmxlIG1pdGln YXRpb25zLiAqLwo+ICAgICAgaWYgKCBib290X2NwdV9kYXRhLmNwdWlkX2xldmVsID49IDcgKQo+ ICAgICAgICAgIGNwdWlkX2NvdW50KDcsIDAsICZ0bXAsICZ0bXAsICZ0bXAsICZfN2QwKTsKPiAg ICAgIGlmICggYm9vdF9jcHVfZGF0YS5leHRlbmRlZF9jcHVpZF9sZXZlbCA+PSAweDgwMDAwMDA4 ICkKPiAgICAgICAgICBjcHVpZCgweDgwMDAwMDA4LCAmdG1wLCAmZThiLCAmdG1wLCAmdG1wKTsK PiAtICAgIGlmICggXzdkMCAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9BUkNIX0NBUFMpICkK PiAtICAgICAgICByZG1zcmwoTVNSX0FSQ0hfQ0FQQUJJTElUSUVTLCBjYXBzKTsKPiAgCj4gICAg ICBwcmludGsoWEVOTE9HX0RFQlVHICJTcGVjdWxhdGl2ZSBtaXRpZ2F0aW9uIGZhY2lsaXRpZXM6 XG4iKTsKPiAgCj4gQEAgLTE0Miw3ICsxMzksNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgcHJpbnRf ZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVuaykKPiAgfQo+ICAKPiAgLyogQ2FsY3VsYXRlIHdo ZXRoZXIgUmV0cG9saW5lIGlzIGtub3duLXNhZmUgb24gdGhpcyBDUFUuICovCj4gLXN0YXRpYyBi b29sIF9faW5pdCByZXRwb2xpbmVfc2FmZSh2b2lkKQo+ICtzdGF0aWMgYm9vbCBfX2luaXQgcmV0 cG9saW5lX3NhZmUodWludDY0X3QgY2FwcykKPiAgewo+ICAgICAgdW5zaWduZWQgaW50IHVjb2Rl X3JldiA9IHRoaXNfY3B1KHVjb2RlX2NwdV9pbmZvKS5jcHVfc2lnLnJldjsKPiAgCj4gQEAgLTE1 MywxOSArMTUwLDEyIEBAIHN0YXRpYyBib29sIF9faW5pdCByZXRwb2xpbmVfc2FmZSh2b2lkKQo+ ICAgICAgICAgICBib290X2NwdV9kYXRhLng4NiAhPSA2ICkKPiAgICAgICAgICByZXR1cm4gZmFs c2U7Cj4gIAo+IC0gICAgaWYgKCBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQVJDSF9DQVBTKSAp Cj4gLSAgICB7Cj4gLSAgICAgICAgdWludDY0X3QgY2FwczsKPiAtCj4gLSAgICAgICAgcmRtc3Js KE1TUl9BUkNIX0NBUEFCSUxJVElFUywgY2Fwcyk7Cj4gLQo+IC0gICAgICAgIC8qCj4gLSAgICAg ICAgICogUkJTQSBtYXkgYmUgc2V0IGJ5IGEgaHlwZXJ2aXNvciB0byBpbmRpY2F0ZSB0aGF0IHdl IG1heSBtb3ZlIHRvIGEKPiAtICAgICAgICAgKiBwcm9jZXNzb3Igd2hpY2ggaXNuJ3QgcmV0cG9s aW5lLXNhZmUuCj4gLSAgICAgICAgICovCj4gLSAgICAgICAgaWYgKCBjYXBzICYgQVJDSF9DQVBT X1JTQkEgKQo+IC0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gLSAgICB9Cj4gKyAgICAvKgo+ ICsgICAgICogUlNCQSBtYXkgYmUgc2V0IGJ5IGEgaHlwZXJ2aXNvciB0byBpbmRpY2F0ZSB0aGF0 IHdlIG1heSBtb3ZlIHRvIGEKPiArICAgICAqIHByb2Nlc3NvciB3aGljaCBpc24ndCByZXRwb2xp bmUtc2FmZS4KPiArICAgICAqLwo+ICsgICAgaWYgKCBjYXBzICYgQVJDSF9DQVBTX1JTQkEgKQo+ ICsgICAgICAgIHJldHVybiBmYWxzZTsKPiAgCj4gICAgICBzd2l0Y2ggKCBib290X2NwdV9kYXRh Lng4Nl9tb2RlbCApCj4gICAgICB7Cj4gQEAgLTI5OSw2ICsyODksMTAgQEAgdm9pZCBfX2luaXQg aW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQo+ICB7Cj4gICAgICBlbnVtIGluZF90 aHVuayB0aHVuayA9IFRIVU5LX0RFRkFVTFQ7Cj4gICAgICBib29sIGlicnMgPSBmYWxzZTsKPiAr ICAgIHVpbnQ2NF90IGNhcHMgPSAwOwo+ICsKPiArICAgIGlmICggYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX0FSQ0hfQ0FQUykgKQo+ICsgICAgICAgIHJkbXNybChNU1JfQVJDSF9DQVBBQklMSVRJ RVMsIGNhcHMpOwo+ICAKPiAgICAgIC8qCj4gICAgICAgKiBIYXMgdGhlIHVzZXIgc3BlY2lmaWVk IGFueSBjdXN0b20gQlRJIG1pdGlnYXRpb25zPyAgSWYgc28sIGZvbGxvdyB0aGVpcgo+IEBAIC0z MjcsNyArMzIxLDcgQEAgdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2 b2lkKQo+ICAgICAgICAgICAgICAgKiBPbiBJbnRlbCBoYXJkd2FyZSwgd2UnZCBsaWtlIHRvIHVz ZSByZXRwb2xpbmUgaW4gcHJlZmVyZW5jZSB0bwo+ICAgICAgICAgICAgICAgKiBJQlJTLCBidXQg b25seSBpZiBpdCBpcyBzYWZlIG9uIHRoaXMgaGFyZHdhcmUuCj4gICAgICAgICAgICAgICAqLwo+ IC0gICAgICAgICAgICBlbHNlIGlmICggcmV0cG9saW5lX3NhZmUoKSApCj4gKyAgICAgICAgICAg IGVsc2UgaWYgKCByZXRwb2xpbmVfc2FmZShjYXBzKSApCj4gICAgICAgICAgICAgICAgICB0aHVu ayA9IFRIVU5LX1JFVFBPTElORTsKPiAgICAgICAgICAgICAgZWxzZSBpZiAoIGJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9JQlJTQikgKQo+ICAgICAgICAgICAgICAgICAgaWJycyA9IHRydWU7Cj4g QEAgLTQxOCw3ICs0MTIsNyBAQCB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRp b25zKHZvaWQpCj4gICAgICBlbHNlCj4gICAgICAgICAgc2V0dXBfY2xlYXJfY3B1X2NhcChYODZf RkVBVFVSRV9OT19YUFRJKTsKPiAgCj4gLSAgICBwcmludF9kZXRhaWxzKHRodW5rKTsKPiArICAg IHByaW50X2RldGFpbHModGh1bmssIGNhcHMpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBfX2lu aXQgX19tYXliZV91bnVzZWQgYnVpbGRfYXNzZXJ0aW9ucyh2b2lkKQo+IC0tIAo+IDIuMS40Cj4g Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Cj4gWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCj4g aHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==