[PATCH v1] libxl: fix return code in qmp_synchronous_send

[PATCH v1] libxl: fix return code in qmp_synchronous_send

[Olaf Hering]

Use error code from libxl namespace, a plain -1 is not valid in this context.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 tools/libxl/libxl_qmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
index be1fda18ba..0fe42813bf 100644
--- a/tools/libxl/libxl_qmp.c
+++ b/tools/libxl/libxl_qmp.c
@@ -627,7 +627,7 @@ static int qmp_synchronous_send(libxl__qmp_handler *qmp, const char *cmd,
 
     id = qmp_send(qmp, cmd, args, callback, opaque, &context);
     if (id <= 0) {
-        return -1;
+        return ERROR_FAIL;
     }
     qmp->wait_for_id = id;
 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v1] libxl: fix return code in qmp_synchronous_send

[Wei Liu]

On Thu, May 17, 2018 at 04:29:57PM +0200, Olaf Hering wrote:
> Use error code from libxl namespace, a plain -1 is not valid in this context.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

While this function doesn't have libxl prefix, its return value does get
returned directly by various libxl functions. Instead of fixing all the
callers, I'm fine with this change.

Acked-by: Wei Liu <wei.liu2@citrix.com>

> ---
>  tools/libxl/libxl_qmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
> index be1fda18ba..0fe42813bf 100644
> --- a/tools/libxl/libxl_qmp.c
> +++ b/tools/libxl/libxl_qmp.c
> @@ -627,7 +627,7 @@ static int qmp_synchronous_send(libxl__qmp_handler *qmp, const char *cmd,
>  
>      id = qmp_send(qmp, cmd, args, callback, opaque, &context);
>      if (id <= 0) {
> -        return -1;
> +        return ERROR_FAIL;
>      }
>      qmp->wait_for_id = id;
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel