From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume
Date: Fri, 18 May 2018 17:55:59 +0100 [thread overview]
Message-ID: <20180518165559.nhybtsj5ff2diy3m@citrix.com> (raw)
In-Reply-To: <0821043c-56d8-0046-4c4e-772afdeb3d5c@suse.com>
On Fri, May 18, 2018 at 09:25:07AM +0200, Juergen Gross wrote:
> On 17/05/18 17:51, Olaf Hering wrote:
> > If a domU has a qemu-xen instance attached, it is required to call qemus
> > "xen-save-devices-state" method. Without it, the receiving side of a PV
> > migration may be unable to lock the image:
> >
> > xen be: qdisk-51712: xen be: qdisk-51712: error: Failed to get "write" lock
> > error: Failed to get "write" lock
> > xen be: qdisk-51712: xen be: qdisk-51712: initialise() failed
> > initialise() failed
> >
> > The proper way to decide if a PV or PVH domU has a qemu-xen running is
> > to use the libxl__need_xenpv_qemu API. But since there is no copy of a
> > libxl_domain_config available in these places, it should be enough to
> > check if xenstore contains the relevant info.
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> I'm rather sure this patch is repairing the following:
>
> Tests which are failing intermittently (not blocking):
> test-amd64-amd64-xl-qemut-debianhvm-amd64 16 guest-localmigrate/x10
> fail pass in 122715
> test-amd64-amd64-xl-qemuu-debianhvm-amd64 16 guest-localmigrate/x10
> fail pass in 122715
I don't think so. The locking issue is known and fixed (at least for
HVM). It would cause local migration to fail definitively, while the
log says those two tests fail intermittently.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-18 16:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 15:51 [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume Olaf Hering
2018-05-18 7:25 ` Juergen Gross
2018-05-18 8:02 ` Olaf Hering
2018-05-18 16:55 ` Wei Liu [this message]
2018-05-18 17:01 ` Wei Liu
2018-05-18 19:09 ` Olaf Hering
2018-05-21 8:18 ` Wei Liu
2018-05-22 8:52 ` Olaf Hering
2018-05-22 11:14 ` Wei Liu
2018-05-25 13:59 ` Olaf Hering
2018-06-04 17:31 ` Anthony PERARD
2018-06-21 15:34 ` Olaf Hering
2018-06-21 15:59 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518165559.nhybtsj5ff2diy3m@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).