From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH for-next 2/5] ipxe: produce a single binary from its build
Date: Mon, 21 May 2018 09:55:29 +0100 [thread overview]
Message-ID: <20180521085529.nssrxxeeh2e2cfts@citrix.com> (raw)
In-Reply-To: <5AFEF35902000078001C4238@prv1-mh.provo.novell.com>
On Fri, May 18, 2018 at 09:38:01AM -0600, Jan Beulich wrote:
> >>> On 15.05.18 at 20:22, <wei.liu2@citrix.com> wrote:
> > --- a/tools/firmware/etherboot/Makefile
> > +++ b/tools/firmware/etherboot/Makefile
> > @@ -18,11 +18,15 @@ D=ipxe
> > T=ipxe.tar.gz
> >
> > ROMS = $(addprefix $D/src/bin/, $(addsuffix .rom, $(ETHERBOOT_NICS)))
> > +ROM = $D/src/bin/ipxe.bin
> >
> > .NOTPARALLEL:
> >
> > .PHONY: all
> > -all: $(ROMS)
> > +all: $(ROM)
> > +
> > +$(ROM): $(ROMS)
> > + cat $^ > $@
>
> Simple commands like this always make me worry what happens if someone
> interrupts the build at the "right" point in time: Does the target file get
> removed in that case, so that a subsequent re-invocation of make will
> correctly rebuild it? If not, you may need to go through an intermediate file,
> which you then rename to $@.
Good point. I will use an intermediary file in my next version.
>
> hvmloader part
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
Thanks.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-21 8:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 18:22 [PATCH for-next 0/5] Load ipxe from a standalone file Wei Liu
2018-05-15 18:22 ` [PATCH for-next 1/5] Tools.mk.in: drop unused variables Wei Liu
2018-05-15 18:22 ` [PATCH for-next 2/5] ipxe: produce a single binary from its build Wei Liu
2018-05-18 15:38 ` Jan Beulich
2018-05-21 8:55 ` Wei Liu [this message]
2018-05-15 18:22 ` [PATCH for-next 3/5] libxc: allow HVM guest to have modules Wei Liu
2018-05-15 18:22 ` [PATCH for-next 4/5] tools: load IPXE from standalone file Wei Liu
2018-05-18 15:49 ` Jan Beulich
2018-06-04 13:47 ` Anthony PERARD
2018-06-25 8:16 ` Wei Liu
2018-06-25 9:04 ` Jan Beulich
2018-05-15 18:22 ` [PATCH for-next 5/5] tools: provide --with-system-ipxe Wei Liu
2018-06-04 13:59 ` Anthony PERARD
2018-06-25 8:14 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521085529.nssrxxeeh2e2cfts@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).