From: Wei Liu <wei.liu2@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume
Date: Tue, 22 May 2018 12:14:29 +0100 [thread overview]
Message-ID: <20180522111429.srz63nx6te2mefbt@citrix.com> (raw)
In-Reply-To: <20180522105220.607f3f48.olaf@aepfle.de>
On Tue, May 22, 2018 at 10:52:20AM +0200, Olaf Hering wrote:
> Am Mon, 21 May 2018 09:18:20 +0100
> schrieb Wei Liu <wei.liu2@citrix.com>:
>
> > What I mean is: now you seem to want to call
> > libxl__domain_suspend_device_model when QEMU upstream is running,
> > regardless of whether a guest is HVM or PV, so the check for HVM should
> > be gone.
>
> libxl__domain_suspend_device_model calls libxl__device_model_version_running,
> which may return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL in case
> "dm-version" does not exist.
> Is it valid to assume that a non-existant "dm-version" means qemu-trad?
> So far I have not tested a PV domU with qemu-trad, not sure if that can work
> anyway.
>
> Also, libxl__device_model_version_running may return -1. Is that valid?
>
I think your predicate is correct. Sorry for the noise.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-22 11:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 15:51 [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume Olaf Hering
2018-05-18 7:25 ` Juergen Gross
2018-05-18 8:02 ` Olaf Hering
2018-05-18 16:55 ` Wei Liu
2018-05-18 17:01 ` Wei Liu
2018-05-18 19:09 ` Olaf Hering
2018-05-21 8:18 ` Wei Liu
2018-05-22 8:52 ` Olaf Hering
2018-05-22 11:14 ` Wei Liu [this message]
2018-05-25 13:59 ` Olaf Hering
2018-06-04 17:31 ` Anthony PERARD
2018-06-21 15:34 ` Olaf Hering
2018-06-21 15:59 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522111429.srz63nx6te2mefbt@citrix.com \
--to=wei.liu2@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).