From: Wei Liu <wei.liu2@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Juergen Gross <jgross@suse.com>, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] tools/kdd: alternative way of muting spurious gcc warning
Date: Wed, 23 May 2018 09:31:52 +0100 [thread overview]
Message-ID: <20180523083152.u7rx2bzaann623q5@citrix.com> (raw)
In-Reply-To: <20180523082847.GC1291@mail-itl>
On Wed, May 23, 2018 at 10:28:47AM +0200, Marek Marczykowski-Górecki wrote:
> On Wed, May 23, 2018 at 08:48:12AM +0100, Wei Liu wrote:
> > On Tue, May 22, 2018 at 09:47:45PM +0200, Marek Marczykowski-Górecki wrote:
> > > Older gcc does not support #pragma GCC diagnostics, so use alternative
> > > approach - change variable type to uint32_t (this code handle 32-bit
> > > requests only anyway), which apparently also avoid gcc complaining about
> > > this (otherwise correct) code.
> > >
> > > Fixes 437e00fea04becc91c1b6bc1c0baa636b067a5cc "tools/kdd: mute spurious
> > > gcc warning"
> > >
> > > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> >
> > I'm confused. Do we still need this? Gcc 8.1 seems to have fixed the bug
> > which caused compilation failure.
>
> Apparently not entirely - see my other email. It still fails on Fedora
> 28 with gcc 8.1.
>
Oh I missed that, sorry.
In that case we should take this patch instead:
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-05-23 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 19:47 [PATCH] tools/kdd: alternative way of muting spurious gcc warning Marek Marczykowski-Górecki
2018-05-23 4:02 ` Juergen Gross
2018-05-25 6:26 ` Tim Deegan
2018-05-23 7:48 ` Wei Liu
2018-05-23 8:28 ` Marek Marczykowski-Górecki
2018-05-23 8:31 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523083152.u7rx2bzaann623q5@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).