xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Sameer Goel <sameer.goel@linaro.org>
To: xen-devel@lists.xenproject.org, julien.grall@arm.com,
	mjaggi@caviumnetworks.com
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
	george.dunlap@eu.citrix.com, Andrew.Cooper3@citrix.com,
	jbeulich@suse.com, Sameer Goel <sameer.goel@linaro.org>,
	Ian.Jackson@citrix.com, nd@arm.com, shankerd@codeaurora.org,
	roger.pau@citrix.com
Subject: [v2 1/6] Port WARN_ON_ONCE() from Linux
Date: Wed, 23 May 2018 18:46:15 -0600	[thread overview]
Message-ID: <20180524004620.23828-2-sameer.goel@linaro.org> (raw)
In-Reply-To: <20180524004620.23828-1-sameer.goel@linaro.org>

Port WARN_ON_ONCE macro from Linux.

Signed-off-by: Sameer Goel <sameer.goel@linaro.org>
Acked-by: Julien Grall <julien.grall@linaro.org>
---
 xen/arch/arm/xen.lds.S |  1 +
 xen/arch/x86/xen.lds.S |  1 +
 xen/include/xen/lib.h  | 13 +++++++++++++
 3 files changed, 15 insertions(+)

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index 245a0e0e85..2f211be22f 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -94,6 +94,7 @@ SECTIONS
        __end_schedulers_array = .;
        *(.data.rel)
        *(.data.rel.*)
+       *(.data.unlikely)
        CONSTRUCTORS
   } :text
 
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 70afedd31d..11b2a93eb1 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -270,6 +270,7 @@ SECTIONS
        *(.data)
        *(.data.rel)
        *(.data.rel.*)
+       *(.data.unlikely)
        CONSTRUCTORS
   } :text
 
diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
index 1d9771340c..b8442a292e 100644
--- a/xen/include/xen/lib.h
+++ b/xen/include/xen/lib.h
@@ -11,6 +11,19 @@
 #define BUG_ON(p)  do { if (unlikely(p)) BUG();  } while (0)
 #define WARN_ON(p) do { if (unlikely(p)) WARN(); } while (0)
 
+#define WARN_ON_ONCE(p)                               \
+({                                                    \
+    static bool __section(".data.unlikely") warned;   \
+    bool ret_warn_once = !!(p);                       \
+                                                      \
+    if ( unlikely(ret_warn_once && !warned) )         \
+    {                                                 \
+        warned = true;                                \
+        WARN();                                       \
+    }                                                 \
+    unlikely(ret_warn_once);                          \
+})
+
 #if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)
 /* Force a compilation error if condition is true */
 #define BUILD_BUG_ON(cond) ({ _Static_assert(!(cond), "!(" #cond ")"); })
-- 
2.17.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-05-24  0:46 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24  0:46 [v2 0/6] SMMUv3 driver Sameer Goel
2018-05-24  0:46 ` Sameer Goel [this message]
2018-05-24  7:53   ` [v2 1/6] Port WARN_ON_ONCE() from Linux Jan Beulich
2018-05-24 20:23     ` Sameer Goel
2018-05-25  7:07       ` Jan Beulich
2018-06-07  1:21         ` Sameer Goel
2018-05-24  0:46 ` [v2 2/6] passthrough/arm: Modify SMMU driver to use generic device definition Sameer Goel
2018-05-24  0:46 ` [v2 3/6] Add verbatim copy of arm-smmu-v3.c from Linux Sameer Goel
2018-05-24  0:46 ` [v2 4/6] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver Sameer Goel
2018-05-24  4:48   ` Manish Jaggi
2018-05-24 20:18     ` Sameer Goel
2018-05-24 20:29     ` Sameer Goel
2018-05-25  4:41       ` Manish Jaggi
2018-05-25  8:45         ` Julien Grall
2018-05-30 19:46         ` Sameer Goel
2018-05-31  4:10           ` Manish Jaggi
2018-05-31 16:06             ` Goel, Sameer
2018-05-30 23:01         ` Sameer Goel
2018-05-31  4:13           ` Manish Jaggi
2018-05-31 15:57             ` Sameer Goel
2018-06-01  5:16               ` Manish Jaggi
2018-06-01 18:58                 ` Sameer Goel
2018-06-02 21:26                   ` Manish Jaggi
2018-05-24  7:57   ` Jan Beulich
2018-05-24 20:26     ` Sameer Goel
2018-05-25  7:10       ` Jan Beulich
2018-05-30 19:30         ` Sameer Goel
2018-05-24  0:46 ` [v2 5/6] drivers/passthrough/arm: Refactor code for arm smmu drivers Sameer Goel
2018-05-24  7:58   ` Jan Beulich
2018-05-24 20:30     ` Sameer Goel
2018-05-24  0:46 ` [v2 6/6] xen/smmu: Add a new config define for legacy SMMU Sameer Goel
2018-05-24  7:59   ` Jan Beulich
2018-05-24  8:52     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180524004620.23828-2-sameer.goel@linaro.org \
    --to=sameer.goel@linaro.org \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=mjaggi@caviumnetworks.com \
    --cc=nd@arm.com \
    --cc=roger.pau@citrix.com \
    --cc=shankerd@codeaurora.org \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).