From: Wei Liu <wei.liu2@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>,
sergey.dyasli@citrix.com
Subject: Re: [PATCH 2/5] x86: split out cpuid objects and helpers
Date: Fri, 25 May 2018 10:49:12 +0100 [thread overview]
Message-ID: <20180525094912.zkwalyemsuutue2s@citrix.com> (raw)
In-Reply-To: <20180525094104.5ogk4qzcya5pfucc@MacBook-Pro-de-Roger.local>
On Fri, May 25, 2018 at 11:41:04AM +0200, Roger Pau Monné wrote:
> On Thu, May 24, 2018 at 05:05:19PM +0100, Wei Liu wrote:
> > They are moved to a new header which is going to be consumed by both
> > the hypervisor and toolstack.
> >
> > Create a new directory for this kind of headers in anticipation of
> ^that?
> > more will come.
> >
> > No functional change.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > Cc: Jan Beulich <jbeulich@suse.com>
> > Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> >
> > Any suggestion on the directory name?
> > ---
> > xen/include/asm-x86/arch-shared/cpuid.h | 213 ++++++++++++++++++++++++++++++++
> > xen/include/asm-x86/cpuid.h | 210 +------------------------------
>
> I would have placed those inside of:
>
> xen/include/public/arch-x86/cpuid.h
>
> Protected with a #if defined(__XEN__) || defined(__XEN_TOOLS__)?
>
I envision this is going to grow into libcpuid or something, just like
libelf.
Also this isn't some sort of interface between HV and toolstack -- the
interface works on serialised data. Putting the internal representation
in public header would be wrong.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-25 9:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 16:05 [PATCH 0/5] Share CPUID stuff between hypervisor and toolstack Wei Liu
2018-05-24 16:05 ` [PATCH 1/5] x86: move definition of struct cpuid_leaf to cpuid.h Wei Liu
2018-05-25 9:31 ` Roger Pau Monné
2018-05-25 9:35 ` Wei Liu
2018-05-25 11:50 ` Jan Beulich
2018-05-25 12:03 ` Wei Liu
2018-05-25 13:05 ` Jan Beulich
2018-05-25 13:11 ` Andrew Cooper
2018-05-24 16:05 ` [PATCH 2/5] x86: split out cpuid objects and helpers Wei Liu
2018-05-25 9:41 ` Roger Pau Monné
2018-05-25 9:49 ` Wei Liu [this message]
2018-05-25 10:01 ` Andrew Cooper
2018-05-25 10:23 ` Roger Pau Monné
2018-05-29 12:32 ` Jan Beulich
2018-05-24 16:05 ` [PATCH 3/5] tools: link arch-shared directory Wei Liu
2018-05-24 16:05 ` [PATCH 4/5] libxc: introduce xc_cpuid_x86.h Wei Liu
2018-05-24 16:05 ` [PATCH 5/5] XXX DO NOT APPLY: compilation test Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525094912.zkwalyemsuutue2s@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=sergey.dyasli@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).