From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH v2 1/6] osstest: allow appending to existing runvars
Date: Thu, 12 Jul 2018 16:46:17 +0200 [thread overview]
Message-ID: <20180712144622.96603-2-roger.pau@citrix.com> (raw)
In-Reply-To: <20180712144622.96603-1-roger.pau@citrix.com>
From: Ian Jackson <ian.jackson@citrix.com>
So that the contents of the runvar can be expanded. There are
currently two ways to do this:
- Using += will append to the end of the runvar.
- Using ,= will append to the end of the runvar using ',' as the
separator.
Note that if the runvar is empty {,|+}= just sets the runvar.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
cs-job-create | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/cs-job-create b/cs-job-create
index 064a9294..1980a625 100755
--- a/cs-job-create
+++ b/cs-job-create
@@ -53,8 +53,12 @@ foreach my $rv (@runvars) {
$suppress{$1}= 1;
next;
}
- $rv =~ m/^([a-z][0-9a-z_]*)(\~?)\=(.*)$/ or die "$rv ?";
- my ($name,$synth,$val) = ($1,$2,$3);
+ $rv =~ m/^([a-z][0-9a-z_]*)(\~?)([+,]?)\=(.*)$/ or die "$rv ?";
+ my ($name,$synth,$add,$val) = ($1,$2,$3,$4);
+ if ($add && $runvars{$name}) {
+ die "$name synth mismatch" if !!$runvars{$name}[1] ne !!$synth;
+ $val = $runvars{$name}[0].($add ne '+' && $add).$val;
+ }
$runvars{$name}= [$val,$synth];
}
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-07-12 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 14:46 [PATCH v2 0/6] osstest: FreeBSD bugfixes and improvements Roger Pau Monne
2018-07-12 14:46 ` Roger Pau Monne [this message]
2018-07-12 14:46 ` [PATCH v2 2/6] osstest: remove duplicate set_freebsd_runvars Roger Pau Monne
2018-07-12 14:46 ` [PATCH v2 3/6] osstest: abstract code to create a FreeBSD build job Roger Pau Monne
2018-07-12 14:46 ` [PATCH v2 4/6] osstest: limit FreeBSD jobs to hardware booting in BIOS mode Roger Pau Monne
2018-07-17 11:12 ` Ian Jackson
2018-07-12 14:46 ` [PATCH v2 5/6] osstest: set the make command to use for xen-build Roger Pau Monne
2018-07-12 14:46 ` [PATCH v2 6/6] osstest: add FreeBSD Xen build job Roger Pau Monne
2018-07-12 14:50 ` Ian Jackson
2018-07-12 15:02 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712144622.96603-2-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).