From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH v4 6/6] tools: --with-system-{ovmf, seabios, ipxe} should provide absolute paths
Date: Mon, 16 Jul 2018 15:02:55 +0100 [thread overview]
Message-ID: <20180716140255.13648-7-wei.liu2@citrix.com> (raw)
In-Reply-To: <20180716140255.13648-1-wei.liu2@citrix.com>
The paths shouldn't be set to "yes". We ask the user to set absolute
paths because Xen's build system doesn't know where to search, and the
build machine doesn't necessarily have those binaries present in the
first place.
Reported-by: Anthony Perard <anthony.perard@citrix.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
v3: really check for absolute paths.
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
new in v2
---
tools/configure | 9 ++++++---
tools/configure.ac | 9 ++++++---
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/tools/configure b/tools/configure
index 4bff2c02fd..3b55fb2e36 100755
--- a/tools/configure
+++ b/tools/configure
@@ -4564,7 +4564,8 @@ if test "${with_system_seabios+set}" = set; then :
seabios=n
case $withval in
no) seabios_path= ;;
- *) seabios_path=$withval ;;
+ /*) seabios_path=$withval ;;
+ *) as_fn_error $? "Seabios specified, but is not an absolute path" "$LINENO" 5 ;;
esac
fi
@@ -4587,7 +4588,8 @@ if test "${with_system_ovmf+set}" = set; then :
ovmf=n
case $withval in
no) ovmf_path= ;;
- *) ovmf_path=$withval ;;
+ /*) ovmf_path=$withval ;;
+ *) as_fn_error $? "OVMF specified, but is not an absolute path" "$LINENO" 5 ;;
esac
fi
@@ -4610,7 +4612,8 @@ if test "${with_system_ipxe+set}" = set; then :
ipxe=n
case $withval in
no) ipxe_path= ;;
- *) ipxe_path=$withval ;;
+ /*) ipxe_path=$withval ;;
+ *) as_fn_error $? "IPXE specified, but is not an absolute path" "$LINENO" 5 ;;
esac
# IPXE depends on Rombios
diff --git a/tools/configure.ac b/tools/configure.ac
index 2db2356380..0f85472602 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -216,7 +216,8 @@ AC_ARG_WITH([system-seabios],
seabios=n
case $withval in
no) seabios_path= ;;
- *) seabios_path=$withval ;;
+ /*) seabios_path=$withval ;;
+ *) AC_MSG_ERROR([Seabios specified, but is not an absolute path]) ;;
esac
],[])
AS_IF([test "x$seabios" = "xy" -o -n "$seabios_path" ], [
@@ -233,7 +234,8 @@ AC_ARG_WITH([system-ovmf],
ovmf=n
case $withval in
no) ovmf_path= ;;
- *) ovmf_path=$withval ;;
+ /*) ovmf_path=$withval ;;
+ *) AC_MSG_ERROR([OVMF specified, but is not an absolute path]) ;;
esac
],[])
AS_IF([test "x$ovmf" = "xy" -o -n "$ovmf_path" ], [
@@ -250,7 +252,8 @@ AC_ARG_WITH([system-ipxe],
ipxe=n
case $withval in
no) ipxe_path= ;;
- *) ipxe_path=$withval ;;
+ /*) ipxe_path=$withval ;;
+ *) AC_MSG_ERROR([IPXE specified, but is not an absolute path]) ;;
esac
# IPXE depends on Rombios
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-07-16 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 14:02 [PATCH v4 0/6] Load ipxe from a standalone file Wei Liu
2018-07-16 14:02 ` [PATCH v4 1/6] Tools.mk.in: drop unused variables Wei Liu
2018-07-16 14:58 ` Ian Jackson
2018-07-16 14:02 ` [PATCH v4 2/6] ipxe: produce a single binary from its build Wei Liu
2018-07-16 14:02 ` [PATCH v4 3/6] libxc: allow HVM guest to have modules Wei Liu
2018-07-16 14:58 ` Ian Jackson
2018-07-16 14:02 ` [PATCH v4 4/6] tools: load IPXE from standalone file Wei Liu
2018-07-16 14:02 ` [PATCH v4 5/6] tools: provide --with-system-ipxe Wei Liu
2018-07-16 14:59 ` Ian Jackson
2018-07-16 14:02 ` Wei Liu [this message]
2018-07-16 14:58 ` [PATCH v4 6/6] tools: --with-system-{ovmf, seabios, ipxe} should provide absolute paths Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716140255.13648-7-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).