* [PATCH] tools/xentop : replace use of deprecated vwprintw
@ 2018-07-18 22:22 Christopher Clark
2018-07-19 6:53 ` Wei Liu
2019-02-19 17:45 ` George Dunlap
0 siblings, 2 replies; 6+ messages in thread
From: Christopher Clark @ 2018-07-18 22:22 UTC (permalink / raw)
To: xen-devel; +Cc: wei.liu2, ian.jackson
gcc-8.1 complains:
| xentop.c: In function 'print':
| xentop.c:304:4: error: 'vwprintw' is deprecated [-Werror=deprecated-declarations]
| vwprintw(stdscr, (curses_str_t)fmt, args);
| ^~~~~~~~
vw_printw (note the underscore) is a non-deprecated alternative.
Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
---
Please use my gmail address for any correspondence to me.
tools/xenstat/xentop/xentop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xenstat/xentop/xentop.c b/tools/xenstat/xentop/xentop.c
index 2fd2b67..c465810 100644
--- a/tools/xenstat/xentop/xentop.c
+++ b/tools/xenstat/xentop/xentop.c
@@ -301,7 +301,7 @@ static void print(const char *fmt, ...)
if (!batch) {
if((current_row() < lines()-1)) {
va_start(args, fmt);
- vwprintw(stdscr, (curses_str_t)fmt, args);
+ vw_printw(stdscr, (curses_str_t)fmt, args);
va_end(args);
}
} else {
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] tools/xentop : replace use of deprecated vwprintw
2018-07-18 22:22 [PATCH] tools/xentop : replace use of deprecated vwprintw Christopher Clark
@ 2018-07-19 6:53 ` Wei Liu
2018-08-22 21:33 ` Hans van Kranenburg
2019-02-19 17:45 ` George Dunlap
1 sibling, 1 reply; 6+ messages in thread
From: Wei Liu @ 2018-07-19 6:53 UTC (permalink / raw)
To: Christopher Clark; +Cc: wei.liu2, ian.jackson, xen-devel
On Wed, Jul 18, 2018 at 03:22:17PM -0700, Christopher Clark wrote:
> gcc-8.1 complains:
>
> | xentop.c: In function 'print':
> | xentop.c:304:4: error: 'vwprintw' is deprecated [-Werror=deprecated-declarations]
> | vwprintw(stdscr, (curses_str_t)fmt, args);
> | ^~~~~~~~
>
> vw_printw (note the underscore) is a non-deprecated alternative.
>
> Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools/xentop : replace use of deprecated vwprintw
2018-07-19 6:53 ` Wei Liu
@ 2018-08-22 21:33 ` Hans van Kranenburg
2018-08-23 7:01 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Hans van Kranenburg @ 2018-08-22 21:33 UTC (permalink / raw)
To: Wei Liu, Christopher Clark; +Cc: ian.jackson, xen-devel
Hi,
On 07/19/2018 08:53 AM, Wei Liu wrote:
> On Wed, Jul 18, 2018 at 03:22:17PM -0700, Christopher Clark wrote:
>> gcc-8.1 complains:
>>
>> | xentop.c: In function 'print':
>> | xentop.c:304:4: error: 'vwprintw' is deprecated [-Werror=deprecated-declarations]
>> | vwprintw(stdscr, (curses_str_t)fmt, args);
>> | ^~~~~~~~
>>
>> vw_printw (note the underscore) is a non-deprecated alternative.
>>
>> Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Would it be possible to put this into 4.11-stable? It seems the change
is not that invasive and risky. :)
If so, I can drop a patch from the Debian packaging.
Thanks,
Hans
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools/xentop : replace use of deprecated vwprintw
2018-08-22 21:33 ` Hans van Kranenburg
@ 2018-08-23 7:01 ` Wei Liu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2018-08-23 7:01 UTC (permalink / raw)
To: Hans van Kranenburg; +Cc: ian.jackson, Wei Liu, Christopher Clark, xen-devel
On Wed, Aug 22, 2018 at 11:33:56PM +0200, Hans van Kranenburg wrote:
> Hi,
>
> On 07/19/2018 08:53 AM, Wei Liu wrote:
> > On Wed, Jul 18, 2018 at 03:22:17PM -0700, Christopher Clark wrote:
> >> gcc-8.1 complains:
> >>
> >> | xentop.c: In function 'print':
> >> | xentop.c:304:4: error: 'vwprintw' is deprecated [-Werror=deprecated-declarations]
> >> | vwprintw(stdscr, (curses_str_t)fmt, args);
> >> | ^~~~~~~~
> >>
> >> vw_printw (note the underscore) is a non-deprecated alternative.
> >>
> >> Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
> >
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> Would it be possible to put this into 4.11-stable? It seems the change
> is not that invasive and risky. :)
>
> If so, I can drop a patch from the Debian packaging.
This one is for Ian to answer.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools/xentop : replace use of deprecated vwprintw
2018-07-18 22:22 [PATCH] tools/xentop : replace use of deprecated vwprintw Christopher Clark
2018-07-19 6:53 ` Wei Liu
@ 2019-02-19 17:45 ` George Dunlap
2019-02-19 17:48 ` Wei Liu
1 sibling, 1 reply; 6+ messages in thread
From: George Dunlap @ 2019-02-19 17:45 UTC (permalink / raw)
To: Christopher Clark; +Cc: Ian Jackson, Wei Liu, Jan Beulich, Xen-devel
On Wed, Jul 18, 2018 at 11:23 PM Christopher Clark
<christopher.w.clark@gmail.com> wrote:
>
> gcc-8.1 complains:
>
> | xentop.c: In function 'print':
> | xentop.c:304:4: error: 'vwprintw' is deprecated [-Werror=deprecated-declarations]
> | vwprintw(stdscr, (curses_str_t)fmt, args);
> | ^~~~~~~~
>
> vw_printw (note the underscore) is a non-deprecated alternative.
>
> Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
Jan,
This should probably be queued for backport.
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools/xentop : replace use of deprecated vwprintw
2019-02-19 17:45 ` George Dunlap
@ 2019-02-19 17:48 ` Wei Liu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2019-02-19 17:48 UTC (permalink / raw)
To: George Dunlap
Cc: Ian Jackson, Wei Liu, Christopher Clark, Jan Beulich, Xen-devel
On Tue, Feb 19, 2019 at 05:45:40PM +0000, George Dunlap wrote:
> On Wed, Jul 18, 2018 at 11:23 PM Christopher Clark
> <christopher.w.clark@gmail.com> wrote:
> >
> > gcc-8.1 complains:
> >
> > | xentop.c: In function 'print':
> > | xentop.c:304:4: error: 'vwprintw' is deprecated [-Werror=deprecated-declarations]
> > | vwprintw(stdscr, (curses_str_t)fmt, args);
> > | ^~~~~~~~
> >
> > vw_printw (note the underscore) is a non-deprecated alternative.
> >
> > Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
>
> Jan,
>
> This should probably be queued for backport.
ITYM Ian.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-19 17:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-18 22:22 [PATCH] tools/xentop : replace use of deprecated vwprintw Christopher Clark
2018-07-19 6:53 ` Wei Liu
2018-08-22 21:33 ` Hans van Kranenburg
2018-08-23 7:01 ` Wei Liu
2019-02-19 17:45 ` George Dunlap
2019-02-19 17:48 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).