Re: [PATCH] libxl: Handle deprecation of QEMU's -usbdevice

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Jul 19, 2018 at 06:29:29PM +0100, Anthony PERARD wrote:
> -usbdevice is deprecated as of QEMU 2.10.
> 
> This patch replace the few options documented in xl.cfg(5) by the
> recommanded syntax. And if the option isn't recognize, simply use
> -usbdevice with a warning, the options isn't entirely removed from QEMU
> upstream.
> 
> Also, remove from the manual the sentence inviting to read QEMU's
> documentation.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  docs/man/xl.cfg.pod.5.in |  3 --
>  tools/libxl/libxl_dm.c   | 66 +++++++++++++++++++++++++++++++++++++---
>  2 files changed, 61 insertions(+), 8 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
> index 099a28dc7a..74375e0225 100644
> --- a/docs/man/xl.cfg.pod.5.in
> +++ b/docs/man/xl.cfg.pod.5.in
> @@ -2468,9 +2468,6 @@ write "host:8.2".
>  
>  The form usbdevice=DEVICE is also accepted for backwards compatibility.
>  
> -More valid options can be found in the "usbdevice" section of the QEMU
> -documentation.
> -

Does this mean we intend to only support the options listed in
xl.cfg(5)?

If so, I think we should make clear here -- this is a regression. And
tell users if they have appended their own options they should take
actions, like using device_model_extra_args or something else (?).

How does libvirt handle QEMU option deprecation?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel