From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [RFC PATCH 04/17] libxl: Build the domain with a Linux based stubdomain Date: Wed, 1 Aug 2018 16:37:15 +0200 Message-ID: <20180801143715.GV1371@mail-itl> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6145515537827097235==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jason Andryuk Cc: Wei Liu , Ian Jackson , xen-devel@lists.xen.org, Simon Gaiser , xen-devel , Eric Shelton List-Id: xen-devel@lists.xenproject.org --===============6145515537827097235== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xmaaO/kAkmiSHqEM" Content-Disposition: inline --xmaaO/kAkmiSHqEM Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 01, 2018 at 10:26:06AM -0400, Jason Andryuk wrote: > On Mon, Jul 30, 2018 at 11:56 PM, Marek Marczykowski-G=C3=B3recki > wrote: > > From: Eric Shelton > > > > This will build a Linux-based stubdomain with QEMU upstream. > > > > Signed-off-by: Eric Shelton > > > > Simon: > > * use initramfs instead of disk with rootfs > > * don't initialize qmp (unused in Qubes) > > * Make libxl_domain_need_memory consistent with actual stubdoma build > > code (bugfix relevant also for non-linux case) > > * Make stubdomain memory size configurable > > Signed-off-by: Simon Gaiser > > > > Marek: > > * Make kernel and ramdisk paths configurable. > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > --- >=20 > >=20 > > @@ -1983,10 +1997,8 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl= __stub_dm_spawn_state *sdss) > > dm_config->num_vkbs =3D 1; > > } > > > > - stubdom_state->pv_kernel.path > > - =3D libxl__abs_path(gc, "ioemu-stubdom.gz", libxl__xenfirmware= dir_path()); > > - stubdom_state->pv_cmdline =3D GCSPRINTF(" -d %d", guest_domid); >=20 > This dropped line isn't restored anywhere else, afaics. Does this > break mini-os stubdoms? No, mini-os gets cmdline from xenstore anyway. And libxl__build_device_model_args_old do add -d domid there. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --xmaaO/kAkmiSHqEM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAlthxZsACgkQ24/THMrX 1ywpKgf8DBfzuowi3wBMz6y+2ofZnVgBslb07f1yY+z6g8GaNgNEqc1AebtKM+PN MD9AsRpQ0pXMBF+cKg+fggu3LkqC1XDcsZJvw17ptgAeblY9ogZKHtk7jdWTeZ+B cHizDgYZiBXpZoYtt1OL0DtHFEDj8TOAFAWLLD7o3fjlBxkdhjIk21FICC87lHGU 16m+kg1dVSzJLlWSXRq8ghpwZdmcCV8mM7ML57Xct0sFuAScDEaE1CzTBRV9BPtr 4SJIlyiwq3rUG2SmDl2ctoixLqPmd8cVmQsYzieQQH8/13erph1P8B5cLcNZclRw 783sRU/gRaAAqUGBZW9W6jBuJFx5yA== =r6YK -----END PGP SIGNATURE----- --xmaaO/kAkmiSHqEM-- --===============6145515537827097235== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============6145515537827097235==--