From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 3/5] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu
Date: Fri, 3 Aug 2018 12:39:26 +0200 [thread overview]
Message-ID: <20180803103926.332bvockhvb277gf@mac> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D19129162C@SHSMSX101.ccr.corp.intel.com>
On Thu, Aug 02, 2018 at 07:58:48AM +0000, Tian, Kevin wrote:
> > +void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
> > +{
> > + unsigned long i, top, max_pfn;
> > +
> > + BUG_ON(!is_hardware_domain(d));
> > +
> > + /* Set the default value of inclusive depending on the hardware. */
> > + if ( iommu_dom0_inclusive == -1 )
> > + iommu_dom0_inclusive = boot_cpu_data.x86_vendor ==
> > X86_VENDOR_INTEL;
> > +
>
> I don't like above style.
>
> btw It's better to set it in intel_iommu_hwdom_init.
Then I will also have to set the AMD default in amd_iommu_hwdom_init.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-03 10:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 11:03 [PATCH v2 0/5] x86/iommu: PVH Dom0 workarounds for missing RMRR entries Roger Pau Monne
2018-08-01 11:03 ` [PATCH v2 1/5] iommu/vtd: cleanup vtd_set_hwdom_mapping after ia64 removal Roger Pau Monne
2018-08-01 11:16 ` Paul Durrant
2018-08-02 7:36 ` Tian, Kevin
2018-08-01 11:03 ` [PATCH v2 2/5] iommu: introduce dom0-iommu option Roger Pau Monne
2018-08-01 11:15 ` Paul Durrant
2018-08-01 11:16 ` Andrew Cooper
2018-08-02 7:46 ` Tian, Kevin
2018-08-02 8:23 ` Jan Beulich
2018-08-03 8:14 ` Roger Pau Monné
2018-08-03 8:35 ` Paul Durrant
2018-08-03 8:52 ` Roger Pau Monné
2018-08-03 9:05 ` Paul Durrant
2018-08-03 9:08 ` Roger Pau Monné
2018-08-03 9:14 ` Paul Durrant
2018-08-03 9:32 ` Roger Pau Monné
2018-08-03 9:37 ` Paul Durrant
2018-08-06 3:19 ` Tian, Kevin
2018-08-06 7:51 ` Paul Durrant
2018-08-06 9:09 ` Roger Pau Monné
2018-08-01 11:03 ` [PATCH v2 3/5] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu Roger Pau Monne
2018-08-01 11:21 ` Paul Durrant
2018-08-02 7:58 ` Tian, Kevin
2018-08-03 10:39 ` Roger Pau Monné [this message]
2018-08-03 9:09 ` Julien Grall
2018-08-01 11:03 ` [PATCH v2 4/5] dom0/pvh: change the order of the MMCFG initialization Roger Pau Monne
2018-08-01 11:03 ` [PATCH v2 5/5] x86/iommu: add PVH support to the inclusive options Roger Pau Monne
2018-08-01 11:27 ` Paul Durrant
2018-08-02 8:03 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803103926.332bvockhvb277gf@mac \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=kevin.tian@intel.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).