From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: [PATCH 1/2] x86/hvm/ioreq: MMIO range checking completely ignores direction flag Date: Fri, 10 Aug 2018 11:37:13 +0100 Message-ID: <20180810103714.5112-2-paul.durrant@citrix.com> References: <20180810103714.5112-1-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fo4nJ-0000Tf-7m for xen-devel@lists.xenproject.org; Fri, 10 Aug 2018 10:37:21 +0000 In-Reply-To: <20180810103714.5112-1-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Paul Durrant , Jan Beulich List-Id: xen-devel@lists.xenproject.org aHZtX3NlbGVjdF9pb3JlcV9zZXJ2ZXIoKSBpcyB1c2VkIHRvIHJvdXRlIGFuIGlvcmVxIHRvIHRo ZSBhcHByb3ByaWF0ZQppb3JlcSBzZXJ2ZXIuIEZvciBNTUlPIHRoaXMgaXMgZG9uZSBieSBjb21w YXJpbmcgdGhlIHJhbmdlIG9mIHRoZSBpb3JlcQp0byB0aGUgcmFuZ2VzIHJlZ2lzdGVyZWQgYnkg dGhlIGRldmljZSBtb2RlbHMgb2YgZWFjaCBpb3JlcSBzZXJ2ZXIuClVuZm9ydHVuYXRlbHkgdGhl IGNhbGN1bGF0aW9uIG9mIHRoZSByYW5nZSBpZiB0aGUgaW9yZXEgY29tcGxldGVseSBpZ25vcmVz CnRoZSBkaXJlY3Rpb24gZmxhZyBhbmQgdGh1cyBtYXkgY2FsY3VsYXRlIHRoZSB3cm9uZyByYW5n ZSBmb3IgY29tcGFyaXNvbi4KVGh1cyB0aGUgaW9yZXEgbWF5IGVpdGhlciBiZSByb3V0ZWQgdG8g dGhlIHdyb25nIHNlcnZlciBvciBlcnJvbmVvdXNseQp0ZXJtaW5hdGVkIGJ5IG51bGxfb3BzLgoK Tk9URTogVGhlIHBhdGNoIGFsc28gZml4ZXMgd2hpdGVzcGFjZSBpbiB0aGUgc3dpdGNoIHN0YXRl bWVudCB0byBtYWtlIGl0CiAgICAgIHN0eWxlIGNvbXBsaWFudC4KClNpZ25lZC1vZmYtYnk6IFBh dWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+Ci0tLQpDYzogSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPgpDYzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0 cml4LmNvbT4KLS0tCiB4ZW4vYXJjaC94ODYvaHZtL2lvcmVxLmMgfCAxNSArKysrKysrKysrLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vaW9yZXEuYyBiL3hlbi9hcmNoL3g4Ni9odm0vaW9y ZXEuYwppbmRleCA3YzUxNWIzZWY3Li45NDBhMmM5NzI4IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94 ODYvaHZtL2lvcmVxLmMKKysrIGIveGVuL2FyY2gveDg2L2h2bS9pb3JlcS5jCkBAIC0xMzUzLDIw ICsxMzUzLDI1IEBAIHN0cnVjdCBodm1faW9yZXFfc2VydmVyICpodm1fc2VsZWN0X2lvcmVxX3Nl cnZlcihzdHJ1Y3QgZG9tYWluICpkLAogCiAgICAgICAgIHN3aXRjaCAoIHR5cGUgKQogICAgICAg ICB7Ci0gICAgICAgICAgICB1bnNpZ25lZCBsb25nIGVuZDsKKyAgICAgICAgICAgIHVuc2lnbmVk IGxvbmcgc3RhcnQsIGVuZDsKIAogICAgICAgICBjYXNlIFhFTl9ETU9QX0lPX1JBTkdFX1BPUlQ6 Ci0gICAgICAgICAgICBlbmQgPSBhZGRyICsgcC0+c2l6ZSAtIDE7Ci0gICAgICAgICAgICBpZiAo IHJhbmdlc2V0X2NvbnRhaW5zX3JhbmdlKHIsIGFkZHIsIGVuZCkgKQorICAgICAgICAgICAgc3Rh cnQgPSBhZGRyOworICAgICAgICAgICAgZW5kID0gc3RhcnQgKyBwLT5zaXplIC0gMTsKKyAgICAg ICAgICAgIGlmICggcmFuZ2VzZXRfY29udGFpbnNfcmFuZ2Uociwgc3RhcnQsIGVuZCkgKQogICAg ICAgICAgICAgICAgIHJldHVybiBzOwogCiAgICAgICAgICAgICBicmVhazsKKwogICAgICAgICBj YXNlIFhFTl9ETU9QX0lPX1JBTkdFX01FTU9SWToKLSAgICAgICAgICAgIGVuZCA9IGFkZHIgKyAo cC0+c2l6ZSAqIHAtPmNvdW50KSAtIDE7Ci0gICAgICAgICAgICBpZiAoIHJhbmdlc2V0X2NvbnRh aW5zX3JhbmdlKHIsIGFkZHIsIGVuZCkgKQorICAgICAgICAgICAgc3RhcnQgPSBodm1fbW1pb19m aXJzdF9ieXRlKHApOworICAgICAgICAgICAgZW5kID0gaHZtX21taW9fbGFzdF9ieXRlKHApOwor CisgICAgICAgICAgICBpZiAoIHJhbmdlc2V0X2NvbnRhaW5zX3JhbmdlKHIsIHN0YXJ0LCBlbmQp ICkKICAgICAgICAgICAgICAgICByZXR1cm4gczsKIAogICAgICAgICAgICAgYnJlYWs7CisKICAg ICAgICAgY2FzZSBYRU5fRE1PUF9JT19SQU5HRV9QQ0k6CiAgICAgICAgICAgICBpZiAoIHJhbmdl c2V0X2NvbnRhaW5zX3NpbmdsZXRvbihyLCBhZGRyID4+IDMyKSApCiAgICAgICAgICAgICB7Ci0t IAoyLjExLjAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpo dHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs