[PATCH for-4.7] arm: constify atomic_read parameter

[PATCH for-4.7] arm: constify atomic_read parameter

[Wei Liu]

ded2a37d63 added const to atomic_read. Do the same for Arm
counterpart.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>

Breakage due to XSA-273 changes.
---
 xen/include/asm-arm/atomic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/atomic.h b/xen/include/asm-arm/atomic.h
index 29ab265f00..de22fd55d7 100644
--- a/xen/include/asm-arm/atomic.h
+++ b/xen/include/asm-arm/atomic.h
@@ -110,7 +110,7 @@ typedef struct { int counter; } atomic_t;
  * strex/ldrex monitor on some implementations. The reason we can use it for
  * atomic_set() is the clrex or dummy strex done on every exception return.
  */
-static inline int atomic_read(atomic_t *v)
+static inline int atomic_read(const atomic_t *v)
 {
     return *(volatile int *)&v->counter;
 }
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.7] arm: constify atomic_read parameter

[Andrew Cooper]

On 15/08/2018 09:28, Wei Liu wrote:
> ded2a37d63 added const to atomic_read. Do the same for Arm
> counterpart.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Most likely needed for 4.6 as well.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.7] arm: constify atomic_read parameter

[Julien Grall]

On 08/15/2018 09:29 AM, Andrew Cooper wrote:
> On 15/08/2018 09:28, Wei Liu wrote:
>> ded2a37d63 added const to atomic_read. Do the same for Arm
>> counterpart.
>>
>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Most likely needed for 4.6 as well.

Feel free to add my ack on 4.6 patch as well:

Acked-by: Julien Grall <julien.grall@arm.com>.

> 
> ~Andrew
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.7] arm: constify atomic_read parameter

[Wei Liu]

On Wed, Aug 15, 2018 at 09:51:35AM +0100, Julien Grall wrote:
> 
> 
> On 08/15/2018 09:29 AM, Andrew Cooper wrote:
> > On 15/08/2018 09:28, Wei Liu wrote:
> > > ded2a37d63 added const to atomic_read. Do the same for Arm
> > > counterpart.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > 
> > Most likely needed for 4.6 as well.
> 
> Feel free to add my ack on 4.6 patch as well:
> 
> Acked-by: Julien Grall <julien.grall@arm.com>.

Thanks. I will commit both patches shortly.

> 
> > 
> > ~Andrew
> > 
> 
> -- 
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel