* [PATCH v2] xen: xen.lds should depend on Kconfig's auto.conf
@ 2018-08-17 15:04 Wei Liu
2018-08-17 16:02 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2018-08-17 15:04 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Andrew Cooper, Doug Goldstein,
Julien Grall, Jan Beulich
xen.lds.S uses on some of the config options set by Kconfig.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
v2: correct the path used in the patch.
---
xen/arch/arm/Makefile | 2 +-
xen/arch/x86/Makefile | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index b9b141dc84..55c1bf032f 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -124,7 +124,7 @@ $(TARGET)-syms: prelink.o xen.lds $(BASEDIR)/common/symbols-dummy.o
asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c
$(CC) $(filter-out -flto,$(CFLAGS)) -S -o $@ $<
-xen.lds: xen.lds.S
+xen.lds: xen.lds.S ../../include/config/auto.conf
$(CC) -P -E -Ui386 $(AFLAGS) -o $@ $<
sed -e 's/xen\.lds\.o:/xen\.lds:/g' <.xen.lds.d >.xen.lds.d.new
mv -f .xen.lds.d.new .xen.lds.d
diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index 9b9b63ac63..bb7e1d966c 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -218,12 +218,12 @@ efi/boot.init.o efi/runtime.o efi/compat.o efi/buildid.o: ;
asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c
$(CC) $(filter-out -Wa$(comma)% -flto,$(CFLAGS)) -S -o $@ $<
-xen.lds: xen.lds.S
+xen.lds: xen.lds.S ../../include/config/auto.conf
$(CC) -P -E -Ui386 $(filter-out -Wa$(comma)%,$(AFLAGS)) -o $@ $<
sed -e 's/xen\.lds\.o:/xen\.lds:/g' <.xen.lds.d >.xen.lds.d.new
mv -f .xen.lds.d.new .xen.lds.d
-efi.lds: xen.lds.S
+efi.lds: xen.lds.S ../../include/config/auto.conf
$(CC) -P -E -Ui386 -DEFI $(filter-out -Wa$(comma)%,$(AFLAGS)) -o $@ $<
sed -e 's/efi\.lds\.o:/efi\.lds:/g' <.$(@F).d >.$(@F).d.new
mv -f .$(@F).d.new .$(@F).d
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] xen: xen.lds should depend on Kconfig's auto.conf
2018-08-17 15:04 [PATCH v2] xen: xen.lds should depend on Kconfig's auto.conf Wei Liu
@ 2018-08-17 16:02 ` Jan Beulich
2018-08-17 16:05 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2018-08-17 16:02 UTC (permalink / raw)
To: Wei Liu
Cc: Andrew Cooper, Julien Grall, Stefano Stabellini, Doug Goldstein,
xen-devel
>>> On 17.08.18 at 17:04, <wei.liu2@citrix.com> wrote:
> xen.lds.S uses on some of the config options set by Kconfig.
But .xen.lds.d already has a dependency on
/build/xen/unstable-hg/2018-07-16-64bit/xen/include/generated/autoconf.h,
which is a more correct dependency than auto.conf.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] xen: xen.lds should depend on Kconfig's auto.conf
2018-08-17 16:02 ` Jan Beulich
@ 2018-08-17 16:05 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2018-08-17 16:05 UTC (permalink / raw)
To: Jan Beulich
Cc: Stefano Stabellini, Wei Liu, Andrew Cooper, Doug Goldstein,
Julien Grall, xen-devel
On Fri, Aug 17, 2018 at 10:02:58AM -0600, Jan Beulich wrote:
> >>> On 17.08.18 at 17:04, <wei.liu2@citrix.com> wrote:
> > xen.lds.S uses on some of the config options set by Kconfig.
>
> But .xen.lds.d already has a dependency on
> /build/xen/unstable-hg/2018-07-16-64bit/xen/include/generated/autoconf.h,
> which is a more correct dependency than auto.conf.
Hmm... in that case I'm a bit baffled why it could go out of sync. I
will try to reproduce the issue next week.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-17 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 15:04 [PATCH v2] xen: xen.lds should depend on Kconfig's auto.conf Wei Liu
2018-08-17 16:02 ` Jan Beulich
2018-08-17 16:05 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).