xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] osstest: make git proxy setup common
@ 2018-08-20 10:51 Roger Pau Monne
  2018-08-20 10:51 ` [PATCH 2/2] osstest: configure git proxy for FreeBSD Roger Pau Monne
  2018-08-20 10:52 ` [PATCH 1/2] osstest: make git proxy setup common Ian Jackson
  0 siblings, 2 replies; 9+ messages in thread
From: Roger Pau Monne @ 2018-08-20 10:51 UTC (permalink / raw)
  To: xen-devel; +Cc: Ian Jackson, Roger Pau Monne

By moving it into TestSupport. No functional change.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest/TestSupport.pm | 20 ++++++++++++++++++++
 ts-xen-build-prep      | 19 -------------------
 2 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index ea546011..f8ef8233 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -138,6 +138,7 @@ BEGIN {
                       host_install_postboot_complete
                       target_core_dump_setup
                       sha256file host_shared_mark_ready
+                      gitcache_setup
                       );
     %EXPORT_TAGS = ( );
 
@@ -2903,4 +2904,23 @@ sub host_shared_mark_ready($$) {
                                               $sharetype);
 }
 
+sub gitcache_setup () {
+    my $proxy = $c{GitCacheProxy};
+    return unless $proxy;
+
+    logm("setting up git cacheing proxy $proxy");
+
+    my $gitcfg = '';
+    foreach my $urlprefix (qw(git:// http:// https://)) {
+        $gitcfg .= <<END
+[url "${proxy}$urlprefix"]
+        insteadOf = $urlprefix
+[url "${proxy}$urlprefix"]
+        insteadOf = ${proxy}$urlprefix
+END
+    }
+    target_putfilecontents_stash($ho,30,$gitcfg,"/home/osstest/.gitconfig",
+                                 'home-osstest-gitconfig');
+}
+
 1;
diff --git a/ts-xen-build-prep b/ts-xen-build-prep
index bff5c927..0ec81000 100755
--- a/ts-xen-build-prep
+++ b/ts-xen-build-prep
@@ -245,25 +245,6 @@ sub ccache_setup () {
     }
 }
 
-sub gitcache_setup () {
-    my $proxy = $c{GitCacheProxy};
-    return unless $proxy;
-
-    logm("setting up git cacheing proxy $proxy");
-
-    my $gitcfg = '';
-    foreach my $urlprefix (qw(git:// http:// https://)) {
-	$gitcfg .= <<END
-[url "${proxy}$urlprefix"]
-        insteadOf = $urlprefix
-[url "${proxy}$urlprefix"]
-        insteadOf = ${proxy}$urlprefix
-END
-    }
-    target_putfilecontents_stash($ho,30,$gitcfg,"/home/osstest/.gitconfig",
-				 'home-osstest-gitconfig');
-}
-
 if (!$ho->{Flags}{'no-reinstall'}) {
     determine_vg_lv();
     lvcreate();
-- 
2.18.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] osstest: configure git proxy for FreeBSD
  2018-08-20 10:51 [PATCH 1/2] osstest: make git proxy setup common Roger Pau Monne
@ 2018-08-20 10:51 ` Roger Pau Monne
  2018-08-20 10:53   ` Ian Jackson
  2018-08-20 10:52 ` [PATCH 1/2] osstest: make git proxy setup common Ian Jackson
  1 sibling, 1 reply; 9+ messages in thread
From: Roger Pau Monne @ 2018-08-20 10:51 UTC (permalink / raw)
  To: xen-devel; +Cc: Ian Jackson, Roger Pau Monne

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
---
 ts-build-prep-freebsd | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ts-build-prep-freebsd b/ts-build-prep-freebsd
index e3220fa8..0ed30be4 100755
--- a/ts-build-prep-freebsd
+++ b/ts-build-prep-freebsd
@@ -38,6 +38,7 @@ sub install_deps () {
 }
 
 install_deps();
+gitcache_setup();
 
 our $path_prefix = $r{"freebsd_distpath"} ||
                    get_stashed("path_freebsddist", $r{"freebsdbuildjob"});
-- 
2.18.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] osstest: make git proxy setup common
  2018-08-20 10:51 [PATCH 1/2] osstest: make git proxy setup common Roger Pau Monne
  2018-08-20 10:51 ` [PATCH 2/2] osstest: configure git proxy for FreeBSD Roger Pau Monne
@ 2018-08-20 10:52 ` Ian Jackson
  1 sibling, 0 replies; 9+ messages in thread
From: Ian Jackson @ 2018-08-20 10:52 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: xen-devel

Roger Pau Monne writes ("[PATCH 1/2] osstest: make git proxy setup common"):
> By moving it into TestSupport. No functional change.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD
  2018-08-20 10:51 ` [PATCH 2/2] osstest: configure git proxy for FreeBSD Roger Pau Monne
@ 2018-08-20 10:53   ` Ian Jackson
  2018-08-20 11:07     ` Roger Pau Monné
  0 siblings, 1 reply; 9+ messages in thread
From: Ian Jackson @ 2018-08-20 10:53 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: xen-devel

Roger Pau Monne writes ("[PATCH 2/2] osstest: configure git proxy for FreeBSD"):
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Thanks.

Do you want me to push these to pretest soon ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD
  2018-08-20 10:53   ` Ian Jackson
@ 2018-08-20 11:07     ` Roger Pau Monné
  2018-08-20 11:42       ` Ian Jackson
  2018-08-20 14:04       ` Ian Jackson
  0 siblings, 2 replies; 9+ messages in thread
From: Roger Pau Monné @ 2018-08-20 11:07 UTC (permalink / raw)
  To: Ian Jackson; +Cc: xen-devel

On Mon, Aug 20, 2018 at 11:53:17AM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH 2/2] osstest: configure git proxy for FreeBSD"):
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> Thanks.
> 
> Do you want me to push these to pretest soon ?

If you could, yes please. I'm hoping this will unblock the FreeBSD
build, or at least get it closer to unblocking :)

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD
  2018-08-20 11:07     ` Roger Pau Monné
@ 2018-08-20 11:42       ` Ian Jackson
  2018-08-20 14:04       ` Ian Jackson
  1 sibling, 0 replies; 9+ messages in thread
From: Ian Jackson @ 2018-08-20 11:42 UTC (permalink / raw)
  To: Roger Pau Monné; +Cc: xen-devel

Roger Pau Monné writes ("Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD"):
> On Mon, Aug 20, 2018 at 11:53:17AM +0100, Ian Jackson wrote:
> > Do you want me to push these to pretest soon ?
> 
> If you could, yes please. I'm hoping this will unblock the FreeBSD
> build, or at least get it closer to unblocking :)

Right, done.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD
  2018-08-20 11:07     ` Roger Pau Monné
  2018-08-20 11:42       ` Ian Jackson
@ 2018-08-20 14:04       ` Ian Jackson
  2018-08-20 14:34         ` Roger Pau Monné
  1 sibling, 1 reply; 9+ messages in thread
From: Ian Jackson @ 2018-08-20 14:04 UTC (permalink / raw)
  To: Roger Pau Monné; +Cc: xen-devel

Roger Pau Monné writes ("Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD"):
> On Mon, Aug 20, 2018 at 11:53:17AM +0100, Ian Jackson wrote:
> > Roger Pau Monne writes ("[PATCH 2/2] osstest: configure git proxy for FreeBSD"):
> > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > 
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > 
> > Thanks.
> > 
> > Do you want me to push these to pretest soon ?
> 
> If you could, yes please. I'm hoping this will unblock the FreeBSD
> build, or at least get it closer to unblocking :)

mariner:testing.git> ./mg-allocate -l
Global symbol "$ho" requires explicit package name at Osstest/TestSupport.pm line 2922.
Compilation failed in require at ./mg-allocate line 86.
BEGIN failed--compilation aborted at ./mg-allocate line 86.
mariner:testing.git>

And similar things from cron.  I have rewound pretest and will await
updated patches...

Regards,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD
  2018-08-20 14:04       ` Ian Jackson
@ 2018-08-20 14:34         ` Roger Pau Monné
  2018-08-21 10:28           ` Ian Jackson
  0 siblings, 1 reply; 9+ messages in thread
From: Roger Pau Monné @ 2018-08-20 14:34 UTC (permalink / raw)
  To: Ian Jackson; +Cc: xen-devel

On Mon, Aug 20, 2018 at 03:04:37PM +0100, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD"):
> > On Mon, Aug 20, 2018 at 11:53:17AM +0100, Ian Jackson wrote:
> > > Roger Pau Monne writes ("[PATCH 2/2] osstest: configure git proxy for FreeBSD"):
> > > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > > 
> > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > > 
> > > Thanks.
> > > 
> > > Do you want me to push these to pretest soon ?
> > 
> > If you could, yes please. I'm hoping this will unblock the FreeBSD
> > build, or at least get it closer to unblocking :)
> 
> mariner:testing.git> ./mg-allocate -l
> Global symbol "$ho" requires explicit package name at Osstest/TestSupport.pm line 2922.
> Compilation failed in require at ./mg-allocate line 86.
> BEGIN failed--compilation aborted at ./mg-allocate line 86.
> mariner:testing.git>
> 
> And similar things from cron.  I have rewound pretest and will await
> updated patches...

Sorry, here is a working branch:

git://xenbits.xen.org/people/royger/osstest.git git-proxy

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD
  2018-08-20 14:34         ` Roger Pau Monné
@ 2018-08-21 10:28           ` Ian Jackson
  0 siblings, 0 replies; 9+ messages in thread
From: Ian Jackson @ 2018-08-21 10:28 UTC (permalink / raw)
  To: Roger Pau Monné; +Cc: xen-devel

Roger Pau Monné writes ("Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD"):
> On Mon, Aug 20, 2018 at 03:04:37PM +0100, Ian Jackson wrote:
> > And similar things from cron.  I have rewound pretest and will await
> > updated patches...
> 
> Sorry, here is a working branch:
> 
> git://xenbits.xen.org/people/royger/osstest.git git-proxy

Thanks, that seems better.  I have added my acks and pushed it.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-08-21 10:28 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-20 10:51 [PATCH 1/2] osstest: make git proxy setup common Roger Pau Monne
2018-08-20 10:51 ` [PATCH 2/2] osstest: configure git proxy for FreeBSD Roger Pau Monne
2018-08-20 10:53   ` Ian Jackson
2018-08-20 11:07     ` Roger Pau Monné
2018-08-20 11:42       ` Ian Jackson
2018-08-20 14:04       ` Ian Jackson
2018-08-20 14:34         ` Roger Pau Monné
2018-08-21 10:28           ` Ian Jackson
2018-08-20 10:52 ` [PATCH 1/2] osstest: make git proxy setup common Ian Jackson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).