From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: andrew.cooper3@citrix.com, srinivas.eeda@oracle.com,
JBeulich@suse.com, manoj.gopalasetty@hpe.com,
david.westwood@hpe.com, boris.ostrovsky@oracle.com,
Xen-Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v3 2/2] x86/mmcfg/drhd: Move acpi_mmcfg_init() call before calling acpi_parse_dmar()
Date: Wed, 22 Aug 2018 09:36:49 +0200 [thread overview]
Message-ID: <20180822073649.5hg5hygkpmw3fsoo@mac> (raw)
In-Reply-To: <dc0238dc-8dbd-4c04-aef8-da16e931dcb2@default>
On Tue, Aug 21, 2018 at 09:53:08PM -0700, Zhenzhong Duan wrote:
> pci_conf_read8() needs pci mmcfg mapping to work on multiple pci
> segments system such as HPE Superdome-Flex.
>
> Move acpi_mmcfg_init() call in acpi_boot_init() before calling
> acpi_parse_dmar() so that when pci_conf_read8() is called in
> acpi_parse_dev_scope(), we already have the mapping set up.
>
> mmio_ro_ranges initialization is also moved ahead as it's the only
> dependency of pci_mmcfg_arch_enable() need to be moved. Also
> checked codes between the old and new call sites to ensure we
> don't break anything.
>
> Furthermore MMCFG will continue to not work this early (or
> more precisely not at all until Dom0 boot has progressed far
> enough) if the range(s) isn't/aren't marked reserved in E820.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> Tested-by: Gopalasetty, Manoj <manoj.gopalasetty@hpe.com>
LGTM:
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
I'm however failing to find patch 1/2 in this series. Could you please
make sure threading is setup correctly?
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-22 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 4:53 [PATCH v3 2/2] x86/mmcfg/drhd: Move acpi_mmcfg_init() call before calling acpi_parse_dmar() Zhenzhong Duan
2018-08-22 7:36 ` Roger Pau Monné [this message]
2018-08-22 8:39 ` Zhenzhong Duan
2018-08-22 8:42 ` Roger Pau Monné
2018-08-22 9:14 ` Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822073649.5hg5hygkpmw3fsoo@mac \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.westwood@hpe.com \
--cc=manoj.gopalasetty@hpe.com \
--cc=srinivas.eeda@oracle.com \
--cc=xen-devel@lists.xen.org \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).