From: Wei Liu <wei.liu2@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v7 5/6] x86/iommu: switch the hwdom mapping function to use page_get_type
Date: Wed, 22 Aug 2018 10:45:46 +0100 [thread overview]
Message-ID: <20180822094546.od5pte5nhphsjgmc@citrix.com> (raw)
In-Reply-To: <20180822075200.50278-6-roger.pau@citrix.com>
On Wed, Aug 22, 2018 at 09:51:59AM +0200, Roger Pau Monne wrote:
> This avoids repeated calls to page_is_ram_type which improves
> performance and makes the code easier to read.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Changes since v4:
> - New in this version.
> ---
> Cc: Jan Beulich <jbeulich@suse.com>
> ---
> xen/drivers/passthrough/x86/iommu.c | 60 +++++++++++++++--------------
> 1 file changed, 32 insertions(+), 28 deletions(-)
>
> diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c
> index 25e1ebf8b3..b947ed6043 100644
> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -134,6 +134,37 @@ void arch_iommu_domain_destroy(struct domain *d)
> {
> }
>
> +static bool __hwdom_init hwdom_iommu_map(const struct domain *d,
> + unsigned long pfn,
> + unsigned long max_pfn)
Consider using type-safe types if possible?
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-22 9:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 7:51 [PATCH v7 0/6] x86/iommu: PVH Dom0 workarounds for missing RMRR entries Roger Pau Monne
2018-08-22 7:51 ` [PATCH v7 1/6] iommu: rename iommu_dom0_strict and iommu_passthrough Roger Pau Monne
2018-08-22 9:45 ` Wei Liu
2018-08-22 7:51 ` [PATCH v7 2/6] iommu: introduce dom0-iommu option Roger Pau Monne
2018-08-22 9:45 ` Wei Liu
2018-08-22 7:51 ` [PATCH v7 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu Roger Pau Monne
2018-08-22 9:45 ` Wei Liu
2018-08-24 10:30 ` Roger Pau Monné
2018-08-22 15:07 ` Julien Grall
2018-08-22 15:22 ` Roger Pau Monné
2018-08-22 15:24 ` Julien Grall
2018-08-22 7:51 ` [PATCH v7 4/6] mm: introduce a helper to get the memory type of a page Roger Pau Monne
2018-08-22 9:45 ` Wei Liu
2018-08-24 10:49 ` Roger Pau Monné
2018-08-22 7:51 ` [PATCH v7 5/6] x86/iommu: switch the hwdom mapping function to use page_get_type Roger Pau Monne
2018-08-22 9:45 ` Wei Liu [this message]
2018-08-22 7:52 ` [PATCH v7 6/6] x86/iommu: add map-reserved dom0-iommu option to map reserved memory ranges Roger Pau Monne
2018-08-22 9:45 ` Wei Liu
2018-08-22 15:08 ` Julien Grall
2018-08-28 15:18 ` Jan Beulich
2018-08-27 9:29 ` [PATCH v7 0/6] x86/iommu: PVH Dom0 workarounds for missing RMRR entries Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822094546.od5pte5nhphsjgmc@citrix.com \
--to=wei.liu2@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).