xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Hans van Kranenburg <hans@knorrie.org>
Cc: ian.jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>,
	Christopher Clark <christopher.w.clark@gmail.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/xentop : replace use of deprecated vwprintw
Date: Thu, 23 Aug 2018 08:01:42 +0100	[thread overview]
Message-ID: <20180823070142.t4himrb4nnyaagw4@citrix.com> (raw)
In-Reply-To: <c6ccd141-f30d-2c31-ccc5-112ecdeb9e5b@knorrie.org>

On Wed, Aug 22, 2018 at 11:33:56PM +0200, Hans van Kranenburg wrote:
> Hi,
> 
> On 07/19/2018 08:53 AM, Wei Liu wrote:
> > On Wed, Jul 18, 2018 at 03:22:17PM -0700, Christopher Clark wrote:
> >> gcc-8.1 complains:
> >>
> >> | xentop.c: In function 'print':
> >> | xentop.c:304:4: error: 'vwprintw' is deprecated [-Werror=deprecated-declarations]
> >> |     vwprintw(stdscr, (curses_str_t)fmt, args);
> >> |     ^~~~~~~~
> >>
> >> vw_printw (note the underscore) is a non-deprecated alternative.
> >>
> >> Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
> > 
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> Would it be possible to put this into 4.11-stable? It seems the change
> is not that invasive and risky. :)
> 
> If so, I can drop a patch from the Debian packaging.

This one is for Ian to answer.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-08-23  7:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 22:22 [PATCH] tools/xentop : replace use of deprecated vwprintw Christopher Clark
2018-07-19  6:53 ` Wei Liu
2018-08-22 21:33   ` Hans van Kranenburg
2018-08-23  7:01     ` Wei Liu [this message]
2019-02-19 17:45 ` George Dunlap
2019-02-19 17:48   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180823070142.t4himrb4nnyaagw4@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=christopher.w.clark@gmail.com \
    --cc=hans@knorrie.org \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).