incompatible changes in staging break qemu

incompatible changes in staging break qemu

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 323 bytes --]

Since about two weeks, no released qemu can be built against xen.git#staging. The error looks like that:

qemu-20180825T130857.235c82acca/include/hw/xen/xen_common.h:677:5: error: too many arguments to function 'xc_domain_create'

It looks like staging lacks proper compat wrappers for released qemu versions.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: incompatible changes in staging break qemu

[Jan Beulich]

>>> On 27.08.18 at 08:43, <olaf@aepfle.de> wrote:
> Since about two weeks, no released qemu can be built against xen.git#staging. 
> The error looks like that:
> 
> qemu-20180825T130857.235c82acca/include/hw/xen/xen_common.h:677:5: error: too 
> many arguments to function 'xc_domain_create'
> 
> It looks like staging lacks proper compat wrappers for released qemu 
> versions.

I think it's the other way around - qemu needs such wrappers added
(which of course for released versions of qemu means they'd need
backporting of such an addition). After all the libxc interface, other
than the libxl one, is not stable iirc. However - is the code controlled
by CONFIG_XEN_PV_DOMAIN_BUILD actually used by anyone? So far I
was under the impression that it's the core tool stack's job to create
domains, no qemu's.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: incompatible changes in staging break qemu

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 525 bytes --]

On Mon, Aug 27, Olaf Hering wrote:

> Since about two weeks, no released qemu can be built against xen.git#staging. The error looks like that:
> qemu-20180825T130857.235c82acca/include/hw/xen/xen_common.h:677:5: error: too many arguments to function 'xc_domain_create'
> It looks like staging lacks proper compat wrappers for released qemu versions.

Passing --disable-xen-pv-domain-build instead of
--enable-xen-pv-domain-build to configure fixes/hides the build error.

What is "xen-pv-domain-build" supposed to do?


Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: incompatible changes in staging break qemu

[Anthony PERARD]

On Wed, Aug 29, 2018 at 02:22:05PM +0200, Olaf Hering wrote:
> On Mon, Aug 27, Olaf Hering wrote:
> 
> > Since about two weeks, no released qemu can be built against xen.git#staging. The error looks like that:
> > qemu-20180825T130857.235c82acca/include/hw/xen/xen_common.h:677:5: error: too many arguments to function 'xc_domain_create'
> > It looks like staging lacks proper compat wrappers for released qemu versions.
> 
> Passing --disable-xen-pv-domain-build instead of
> --enable-xen-pv-domain-build to configure fixes/hides the build error.
> 
> What is "xen-pv-domain-build" supposed to do?

It suppose to let QEMU create a Xen domain all by itself, without using
any toolstack. Nickname: xenner.

But that code probably doesn't work anymore.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: incompatible changes in staging break qemu

[Andrew Cooper]

On 04/09/18 18:01, Anthony PERARD wrote:
> On Wed, Aug 29, 2018 at 02:22:05PM +0200, Olaf Hering wrote:
>> On Mon, Aug 27, Olaf Hering wrote:
>>
>>> Since about two weeks, no released qemu can be built against xen.git#staging. The error looks like that:
>>> qemu-20180825T130857.235c82acca/include/hw/xen/xen_common.h:677:5: error: too many arguments to function 'xc_domain_create'
>>> It looks like staging lacks proper compat wrappers for released qemu versions.
>> Passing --disable-xen-pv-domain-build instead of
>> --enable-xen-pv-domain-build to configure fixes/hides the build error.
>>
>> What is "xen-pv-domain-build" supposed to do?
> It suppose to let QEMU create a Xen domain all by itself, without using
> any toolstack. Nickname: xenner.
>
> But that code probably doesn't work anymore.

Having a quick look over the code, its been completely broken since Xen
4.9 (it never called gnttab_set_limits()), and appears to only function
for PV guests (by use of the xc_linux_build() call), and clearly noone
has noticed/cared.

If I were you, I'd purge it completely from qemu.  You don't want to be
playing "keep up with all the changes going into xc_domain_create()",
given how tightly coupled it is to other low level libxc functionality.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel