From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Ross Lagerwall" <ross.lagerwall@citrix.com>,
"Jan Beulich" <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/alt: Fix build when CONFIG_LIVEPATCH is disabled
Date: Wed, 29 Aug 2018 09:25:30 -0400 [thread overview]
Message-ID: <20180829132530.GA7598@char.us.oracle.com> (raw)
In-Reply-To: <20180829131512.wt7wngejcrfs52tb@citrix.com>
On Wed, Aug 29, 2018 at 02:15:12PM +0100, Wei Liu wrote:
> On Wed, Aug 29, 2018 at 11:57:02AM +0100, Andrew Cooper wrote:
> > c/s b28cd21c3628 "x86/build: Use new .nops directive when available"
> > introduced a __read_mostly boolean which is included if the toolchain supports
> > the .nops directive.
> >
> > When CONFIG_LIVEPATCH is compiled out, alternative.o is expected to be a fully
> > init module, and toolchain_nops_are_ideal trips the build system check:
> >
> > Error: size of alternative.o:.data.read_mostly is 0x01
> > /local/xen.git/xen/Rules.mk:206: recipe for target 'alternative.init.o' failed
> > make[3]: *** [alternative.init.o] Error 12
> >
> > Introduce init_or_livepatch_read_mostly and switch the annotation for
> > toolchain_nops_are_ideal.
> >
> > Reported-by: Olaf Hering <olaf@aepfle.de>
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thank you!
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-08-29 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 10:57 [PATCH] x86/alt: Fix build when CONFIG_LIVEPATCH is disabled Andrew Cooper
2018-08-29 12:00 ` Jan Beulich
2018-08-29 13:15 ` Wei Liu
2018-08-29 13:25 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829132530.GA7598@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).