From: Tim Deegan <tim@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers
Date: Thu, 30 Aug 2018 09:04:15 +0100 [thread overview]
Message-ID: <20180830080415.GA7308@deinos.phlegethon.org> (raw)
In-Reply-To: <1535479914-30520-1-git-send-email-andrew.cooper3@citrix.com>
At 19:11 +0100 on 28 Aug (1535483514), Andrew Cooper wrote:
> Unlike the PRINTK/DEBUG wrappers, these go straight out to the console, rather
> than ending up in the debugtrace buffer.
>
> A number of these users are followed by domain_crash(), and future changes
> will want to combine the printk() into the domain_crash() call. Expand these
> wrappers in place, using XENLOG_ERR before a BUG(), and XENLOG_G_ERR before a
> domain_crash().
>
> Perfom some %pv/PRI_mfn/etc cleanup while modifying the invocations, and
> explicitly drop some calls which are unnecessary (bad shadow op, and the empty
> stubs for incorrect sh_map_and_validate_gl?e() calls).
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-30 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 18:11 [PATCH] x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers Andrew Cooper
2018-08-29 8:09 ` Wei Liu
2018-08-30 8:04 ` Tim Deegan [this message]
2018-08-30 15:15 ` Jan Beulich
2018-08-30 15:20 ` Andrew Cooper
2018-08-30 15:26 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830080415.GA7308@deinos.phlegethon.org \
--to=tim@xen.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).