[PATCH] tools: correct tools/tests/depriv/Makefile

[PATCH] tools: correct tools/tests/depriv/Makefile

[Juergen Gross]

tools/tests/depriv/Makefile directly builds the target program from
its C-source. This is problematic when an incremental build is needed
after a header the program is depending on has been modified: in this
case all headers are added into the gcc call and the build will fail.

Correct that by adding a rule for building the program from its .o
file.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/tests/depriv/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/tests/depriv/Makefile b/tools/tests/depriv/Makefile
index 11e07b7c03..3cba28da25 100644
--- a/tools/tests/depriv/Makefile
+++ b/tools/tests/depriv/Makefile
@@ -40,6 +40,9 @@ clean:
 .PHONY: distclean
 distclean: clean
 
+depriv-fd-checker: depriv-fd-checker.o
+	$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
+
 install: all
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
 	$(INSTALL_PROG) $(INSTALL_PRIVBIN) $(DESTDIR)$(LIBEXEC_BIN)
-- 
2.16.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools: correct tools/tests/depriv/Makefile

[Ian Jackson]

Juergen Gross writes ("[PATCH] tools: correct tools/tests/depriv/Makefile"):
> tools/tests/depriv/Makefile directly builds the target program from
> its C-source.

Oh.  That was not my intent.

>  This is problematic when an incremental build is needed
> after a header the program is depending on has been modified: in this
> case all headers are added into the gcc call and the build will fail.
> 
> Correct that by adding a rule for building the program from its .o
> file.

That I omitted this was unintentional.  It just worked for me without
it...

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools: correct tools/tests/depriv/Makefile

[Wei Liu]

On Fri, Sep 07, 2018 at 11:16:54AM +0200, Juergen Gross wrote:
> tools/tests/depriv/Makefile directly builds the target program from
> its C-source. This is problematic when an incremental build is needed
> after a header the program is depending on has been modified: in this
> case all headers are added into the gcc call and the build will fail.
> 
> Correct that by adding a rule for building the program from its .o
> file.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel