From: "'Marek Marczykowski-Górecki'" <marmarek@invisiblethingslab.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Paul Durrant <Paul.Durrant@citrix.com>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH] libvchan: create xenstore entries in one transaction
Date: Wed, 31 Oct 2018 11:43:13 +0100 [thread overview]
Message-ID: <20181031104313.GB32486@mail-itl> (raw)
In-Reply-To: <20181031101703.emdlgaazvxsyq6jg@zion.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1336 bytes --]
On Wed, Oct 31, 2018 at 10:17:03AM +0000, Wei Liu wrote:
> On Wed, Oct 31, 2018 at 10:08:26AM +0000, Paul Durrant wrote:
> > > -----Original Message-----
> > > From: Xen-devel [mailto:xen-devel-bounces@lists.xenproject.org] On Behalf
> > > Of Marek Marczykowski-Górecki
> > > Sent: 30 October 2018 23:49
> > > To: xen-devel@lists.xenproject.org
> > > Cc: Wei Liu <wei.liu2@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>;
> > > Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> > > Subject: [Xen-devel] [PATCH] libvchan: create xenstore entries in one
> > > transaction
> > >
> > > This will prevent race when client waits for server with xs_watch - all
> > > entries should appear at once.
> >
> > Watches should be put on the "state" key to avoid this kind of thing. That key should always be the last thing modified and hence there should never really be the need for xenstore transactions at all.
>
> AIUI libxenvchan doesn't have a "state" key. We can introduce one now
> but we still need to handle old code which doesn't know about the new
> key.
Wei is right, there is no "state" key in libxenvchan.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-10-31 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 23:49 [PATCH] libvchan: create xenstore entries in one transaction Marek Marczykowski-Górecki
2018-10-31 9:41 ` Wei Liu
2018-10-31 10:08 ` Paul Durrant
2018-10-31 10:17 ` Wei Liu
2018-10-31 10:40 ` Paul Durrant
2018-10-31 10:43 ` 'Marek Marczykowski-Górecki' [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031104313.GB32486@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=Ian.Jackson@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).