* [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref
@ 2018-11-01 10:16 Julien Grall
2018-11-01 10:21 ` Andrew Cooper
2018-11-01 11:03 ` George Dunlap
0 siblings, 2 replies; 4+ messages in thread
From: Julien Grall @ 2018-11-01 10:16 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk, George Dunlap,
Andrew Cooper, Ian Jackson, Tim Deegan, Julien Grall, Jan Beulich
Remove the 2 part comment on top of map_grant_ref:
- The first part mention the return value which has been void since
2006!
- The second part mention a local variable 'addr' which does not
exist anymore.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
xen/common/grant_table.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 878e668bf5..0b5894a070 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -890,13 +890,6 @@ static unsigned int mapkind(
return kind;
}
-/*
- * Returns 0 if TLB flush / invalidate required by caller.
- * va will indicate the address to be invalidated.
- *
- * addr is _either_ a host virtual address, or the address of the pte to
- * update, as indicated by the GNTMAP_contains_pte flag.
- */
static void
map_grant_ref(
struct gnttab_map_grant_ref *op)
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref
2018-11-01 10:16 [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref Julien Grall
@ 2018-11-01 10:21 ` Andrew Cooper
2018-11-01 11:03 ` George Dunlap
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Cooper @ 2018-11-01 10:21 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk, George Dunlap,
Ian Jackson, Tim Deegan, Jan Beulich
On 01/11/2018 10:16, Julien Grall wrote:
> Remove the 2 part comment on top of map_grant_ref:
> - The first part mention the return value which has been void since
> 2006!
> - The second part mention a local variable 'addr' which does not
> exist anymore.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref
2018-11-01 10:16 [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref Julien Grall
2018-11-01 10:21 ` Andrew Cooper
@ 2018-11-01 11:03 ` George Dunlap
2018-11-01 12:49 ` Julien Grall
1 sibling, 1 reply; 4+ messages in thread
From: George Dunlap @ 2018-11-01 11:03 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk, George Dunlap,
Andrew Cooper, Ian Jackson, Tim Deegan, Jan Beulich
On 11/01/2018 10:16 AM, Julien Grall wrote:
> Remove the 2 part comment on top of map_grant_ref:
> - The first part mention the return value which has been void since
> 2006!
> - The second part mention a local variable 'addr' which does not
> exist anymore.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Nit: s/stall/stale/; in title
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref
2018-11-01 11:03 ` George Dunlap
@ 2018-11-01 12:49 ` Julien Grall
0 siblings, 0 replies; 4+ messages in thread
From: Julien Grall @ 2018-11-01 12:49 UTC (permalink / raw)
To: George Dunlap, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk, George Dunlap,
Andrew Cooper, Ian Jackson, Tim Deegan, Jan Beulich
Hi George,
On 01/11/2018 11:03, George Dunlap wrote:
> On 11/01/2018 10:16 AM, Julien Grall wrote:
>> Remove the 2 part comment on top of map_grant_ref:
>> - The first part mention the return value which has been void since
>> 2006!
>> - The second part mention a local variable 'addr' which does not
>> exist anymore.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> Nit: s/stall/stale/; in title
I will fix this on commit.
Cheers,
>
> -George
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-01 12:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-01 10:16 [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref Julien Grall
2018-11-01 10:21 ` Andrew Cooper
2018-11-01 11:03 ` George Dunlap
2018-11-01 12:49 ` Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).