[PATCH] automation: build some customised configs

[PATCH] automation: build some customised configs

[Wei Liu]

Introduce a new directory to put in configs we care about. Modify
build script to build with those configs.

While we only introduce x86 configs initially, provision for non-x86
configs.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>

Jan, feel free to put configs here.
---
 automation/configs/x86/hvm_only_config  |  2 ++
 automation/configs/x86/no_hvm_pv_config |  2 ++
 automation/configs/x86/pv_only_config   |  2 ++
 automation/scripts/build                | 15 +++++++++++++++
 4 files changed, 21 insertions(+)
 create mode 100644 automation/configs/x86/hvm_only_config
 create mode 100644 automation/configs/x86/no_hvm_pv_config
 create mode 100644 automation/configs/x86/pv_only_config

diff --git a/automation/configs/x86/hvm_only_config b/automation/configs/x86/hvm_only_config
new file mode 100644
index 0000000000..e82cc04d69
--- /dev/null
+++ b/automation/configs/x86/hvm_only_config
@@ -0,0 +1,2 @@
+CONFIG_HVM=y
+# CONFIG_PV is not set
diff --git a/automation/configs/x86/no_hvm_pv_config b/automation/configs/x86/no_hvm_pv_config
new file mode 100644
index 0000000000..ed853cd358
--- /dev/null
+++ b/automation/configs/x86/no_hvm_pv_config
@@ -0,0 +1,2 @@
+# CONFIG_HVM is not set
+# CONFIG_PV is not set
diff --git a/automation/configs/x86/pv_only_config b/automation/configs/x86/pv_only_config
new file mode 100644
index 0000000000..aca77b64d4
--- /dev/null
+++ b/automation/configs/x86/pv_only_config
@@ -0,0 +1,2 @@
+CONFIG_PV=y
+# CONFIG_HVM is not set
diff --git a/automation/scripts/build b/automation/scripts/build
index c463b060d4..0cde1c7794 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -31,3 +31,18 @@ fi
 ./configure "${cfgargs[@]}"
 
 make -j$(nproc) dist
+
+# Build all the configs we care about
+case ${XEN_TARGET_ARCH} in
+    x86_64) arch=x86 ;;
+    *) exit 0 ;;
+esac
+
+cfg_dir="automation/configs/${arch}"
+for cfg in `ls ${cfg_dir}`; do
+    echo "Building $cfg"
+    rm -f xen/.config
+    make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} XEN_CONFIG_EXPERT=y defconfig
+    make -j$(nproc) -C xen XEN_CONFIG_EXPERT=y
+done
+
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] automation: build some customised configs

[Jan Beulich]

>>> On 02.11.18 at 20:33, <wei.liu2@citrix.com> wrote:
> Introduce a new directory to put in configs we care about. Modify
> build script to build with those configs.
> 
> While we only introduce x86 configs initially, provision for non-x86
> configs.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

> Jan, feel free to put configs here.

Are you referring to some part of a prior discussion we've had, and
that I forgot about in the meantime? I don't recall having pointed
out specific configs we'd want to routinely test (albeit I certainly
can think of some).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] automation: build some customised configs

[Wei Liu]

On Mon, Nov 05, 2018 at 02:06:01AM -0700, Jan Beulich wrote:
> >>> On 02.11.18 at 20:33, <wei.liu2@citrix.com> wrote:
> > Introduce a new directory to put in configs we care about. Modify
> > build script to build with those configs.
> > 
> > While we only introduce x86 configs initially, provision for non-x86
> > configs.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> > Jan, feel free to put configs here.
> 
> Are you referring to some part of a prior discussion we've had, and
> that I forgot about in the meantime? I don't recall having pointed
> out specific configs we'd want to routinely test (albeit I certainly
> can think of some).

In one of the mails to my previous version, you said:

"We don't have no-shadow and bigmem defconfigs, yet I think we (should)
care about not breaking those builds (I routinely check them every once
in a while)."

Once this patch is merged, you can add whatever configs you care about to
this directory and they will be built by Gitlab CI constantly.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] automation: build some customised configs

[Doug Goldstein]

On Fri, Nov 02, 2018 at 07:33:28PM +0000, Wei Liu wrote:
> Introduce a new directory to put in configs we care about. Modify
> build script to build with those configs.
> 
> While we only introduce x86 configs initially, provision for non-x86
> configs.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Jan Beulich <jbeulich@suse.com>
> 
> Jan, feel free to put configs here.
> ---
>  automation/configs/x86/hvm_only_config  |  2 ++
>  automation/configs/x86/no_hvm_pv_config |  2 ++
>  automation/configs/x86/pv_only_config   |  2 ++
>  automation/scripts/build                | 15 +++++++++++++++
>  4 files changed, 21 insertions(+)
>  create mode 100644 automation/configs/x86/hvm_only_config
>  create mode 100644 automation/configs/x86/no_hvm_pv_config
>  create mode 100644 automation/configs/x86/pv_only_config
> 
> diff --git a/automation/configs/x86/hvm_only_config b/automation/configs/x86/hvm_only_config
> new file mode 100644
> index 0000000000..e82cc04d69
> --- /dev/null
> +++ b/automation/configs/x86/hvm_only_config
> @@ -0,0 +1,2 @@
> +CONFIG_HVM=y
> +# CONFIG_PV is not set
> diff --git a/automation/configs/x86/no_hvm_pv_config b/automation/configs/x86/no_hvm_pv_config
> new file mode 100644
> index 0000000000..ed853cd358
> --- /dev/null
> +++ b/automation/configs/x86/no_hvm_pv_config
> @@ -0,0 +1,2 @@
> +# CONFIG_HVM is not set
> +# CONFIG_PV is not set
> diff --git a/automation/configs/x86/pv_only_config b/automation/configs/x86/pv_only_config
> new file mode 100644
> index 0000000000..aca77b64d4
> --- /dev/null
> +++ b/automation/configs/x86/pv_only_config
> @@ -0,0 +1,2 @@
> +CONFIG_PV=y
> +# CONFIG_HVM is not set
> diff --git a/automation/scripts/build b/automation/scripts/build
> index c463b060d4..0cde1c7794 100755
> --- a/automation/scripts/build
> +++ b/automation/scripts/build
> @@ -31,3 +31,18 @@ fi
>  ./configure "${cfgargs[@]}"
>  
>  make -j$(nproc) dist
> +
> +# Build all the configs we care about
> +case ${XEN_TARGET_ARCH} in
> +    x86_64) arch=x86 ;;
> +    *) exit 0 ;;
> +esac
> +
> +cfg_dir="automation/configs/${arch}"
> +for cfg in `ls ${cfg_dir}`; do
> +    echo "Building $cfg"
> +    rm -f xen/.config
> +    make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} XEN_CONFIG_EXPERT=y defconfig
> +    make -j$(nproc) -C xen XEN_CONFIG_EXPERT=y
> +done
> +
> -- 
> 2.11.0
> 

Seems very reasonable to me.

Acked-by: Doug Goldstein <cardoe@cardoe.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel