From: Chao Gao <chao.gao@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2] xen/pt: fix some pass-thru devices don't work across reboot
Date: Mon, 19 Nov 2018 21:20:57 +0800 [thread overview]
Message-ID: <20181119132055.GA19865@gao-cwp> (raw)
In-Reply-To: <5BF2B2AC02000078001FD75D@prv1-mh.provo.novell.com>
On Mon, Nov 19, 2018 at 05:55:08AM -0700, Jan Beulich wrote:
>>>> On 19.11.18 at 13:45, <chao.gao@intel.com> wrote:
>> Another solution came to my mind:
>>
>> The intention of Xen setting 'host_maskall' is to mask a single vector. How
>> about converting the host_maskall to mask all vectors when Xen tries to init
>> the first vector in msix_capability_init()? Actually, on hardware, all
>> vector's mask bit is already set when pciback is performing device reset. So
>> it won't break anything. With commit 69d99d1b223, even a guest has cleared
>> some vectors' mask bit before the convertion, it won't be an issue.
>
>But we already mask vectors in msix_capability_init(). I thought we had
>already settled that if we came through this function before assigning
>the device to a (new or same/restarting) guest, all ought to be fine:
>When we come here for the first entry, we also turn off host_maskall.
Yes, it is reasonable.
>That's why we've been suggesting to go through a release/prepare
>cycle.
Will follow your suggestion.
Thanks
Chao
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-19 13:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 1:10 [PATCH v2] xen/pt: fix some pass-thru devices don't work across reboot Chao Gao
2018-11-15 10:40 ` Roger Pau Monné
2018-11-16 7:53 ` Chao Gao
2018-11-16 9:35 ` Roger Pau Monné
2018-11-16 9:59 ` Jan Beulich
2018-11-16 14:30 ` Roger Pau Monné
2018-11-19 12:23 ` Jan Beulich
2018-11-19 12:45 ` Chao Gao
2018-11-19 12:55 ` Jan Beulich
2018-11-19 13:20 ` Chao Gao [this message]
2018-12-11 17:03 ` Jan Beulich
2018-12-12 4:20 ` Chao Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119132055.GA19865@gao-cwp \
--to=chao.gao@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).