From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: [OSSTEST PATCH v2 1/3] ts-depriv-audit-qemu: Create complete /run/user in appropriate root
Date: Tue, 20 Nov 2018 11:51:13 +0000 [thread overview]
Message-ID: <20181120115115.30556-1-ian.jackson@eu.citrix.com> (raw)
* Use mkdir -p, rather than trying to only create /run/user/$uid.
That helps if /run and/or /run/user do not exist, as they do in
libxl-made chroots with recent libxl (which gets qemu to chroot).
* Do all of this in the root directory of the qemu process, not our
own root directory. So it works if qemu is chrooted.
CC: George Dunlap <george.dunlap@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
v2: Actually use $qpid rather than hardcoding 8123 !
squash! ts-depriv-audit-qemu: Create complete /run/user in appropriate root
---
ts-depriv-audit-qemu | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ts-depriv-audit-qemu b/ts-depriv-audit-qemu
index 5d093500..d5bf10c9 100755
--- a/ts-depriv-audit-qemu
+++ b/ts-depriv-audit-qemu
@@ -48,9 +48,10 @@ END
qpid=$(xenstore-read /local/domain/$domid/image/device-model-pid)
uid=$(id -u xen-qemuuser-range-base)
uid=$(( $uid + $domid ))
- test -d /run/user || mkdir -m 2755 /run/user
- if mkdir -m 2700 /run/user/$uid; then
- chown $uid:root /run/user/$uid
+ qroot=$(readlink /proc/$qpid/root)
+ mkdir -pm 2755 $qroot/run/user
+ if mkdir -m 2700 $qroot/run/user/$uid; then
+ chown $uid:root $qroot/run/user/$uid
fi
osstest-depriv-fd-collector $qpid \
/usr/local/lib/xen/bin/depriv-fd-checker
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2018-11-20 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 11:51 Ian Jackson [this message]
2018-11-20 11:51 ` [OSSTEST PATCH v2 2/3] ts-depriv-audit-qemu: chmod +x qemu's chroot Ian Jackson
2018-11-20 11:51 ` [OSSTEST PATCH v2 3/3] production-config*: Update to fishdescriptor with chroot bugfix Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120115115.30556-1-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).