From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH for-3.2 v3 03/14] qom: make
 user_creatable_complete() specific to UserCreatable
Date: Tue, 20 Nov 2018 17:39:24 +0100
Message-ID: <20181120173924.0131a3e4@redhat.com>
References: <20181107123652.23417-1-marcandre.lureau@redhat.com>
 <20181107123652.23417-4-marcandre.lureau@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xenproject.org>
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from
 <SRS0=lBdB=N7=redhat.com=imammedo@srs-us1.protection.inumbo.net>)
 id 1gP93n-0002JI-L5
 for xen-devel@lists.xenproject.org; Tue, 20 Nov 2018 16:39:35 +0000
In-Reply-To: <20181107123652.23417-4-marcandre.lureau@redhat.com>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau <marcandre.lureau@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefano Stabellini <sstabellini@kernel.org>, Eduardo Habkost <ehabkost@redhat.com>, Corey Minyard <minyard@acm.org>, Amit Shah <amit@kernel.org>, =?UTF-8?B?SGVydsOp?= Poussineau <hpoussin@reactos.org>, "Michael S. Tsirkin" <mst@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org, dgilbert@redhat.com, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, xen-devel@lists.xenproject.org, Anthony Perard <anthony.perard@citrix.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Berger <stefanb@linux.ibm.com>, Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>, Artyom Tarasenko <atar4qemu@gmail.com>, Richard Henderson <rth@twiddle.net>
List-Id: xen-devel@lists.xenproject.org

T24gV2VkLCAgNyBOb3YgMjAxOCAxNjozNjo0MSArMDQwMApNYXJjLUFuZHLDqSBMdXJlYXUgPG1h
cmNhbmRyZS5sdXJlYXVAcmVkaGF0LmNvbT4gd3JvdGU6Cgo+IEluc3RlYWQgb2YgYWNjZXB0aW5n
IGFueSBPYmplY3QqLCBjaGFuZ2UgdXNlcl9jcmVhdGFibGVfY29tcGxldGUoKSB0bwo+IHJlcXVp
cmUgYSBVc2VyQ3JlYXRhYmxlKi4gTW9kaWZ5IHRoZSBjYWxsZXJzIHRvIHBhc3MgdGhlIGFwcHJv
cHJpYXRlCj4gYXJndW1lbnQsIHJlbW92aW5nIHJlZHVuZGFudCBkeW5hbWljIGNhc3QgY2hlY2tz
IGluIG9iamVjdCBjcmVhdGlvbi4KCkxvb2tzIGxpa2UgaXQgZG9lc24ndCBhcHBseSB0byBjdXJy
ZW50IEhFQUQgYW55bW9yZQogCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFyYy1BbmRyw6kgTHVyZWF1
IDxtYXJjYW5kcmUubHVyZWF1QHJlZGhhdC5jb20+Cj4gUmV2aWV3ZWQtYnk6IElnb3IgTWFtbWVk
b3YgPGltYW1tZWRvQHJlZGhhdC5jb20+Cj4gLS0tCj4gIGluY2x1ZGUvcW9tL29iamVjdF9pbnRl
cmZhY2VzLmggfCAgNCArKy0tCj4gIGh3L21pc2MvaXZzaG1lbS5jICAgICAgICAgICAgICAgfCAg
MiArLQo+ICBody92aXJ0aW8vdmlydGlvLXJuZy5jICAgICAgICAgIHwgIDIgKy0KPiAgcW9tL29i
amVjdC5jICAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKysrLS0tLQo+ICBxb20vb2JqZWN0
X2ludGVyZmFjZXMuYyAgICAgICAgIHwgMTQgKysrLS0tLS0tLS0tLS0KPiAgNSBmaWxlcyBjaGFu
Z2VkLCAxNSBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv
aW5jbHVkZS9xb20vb2JqZWN0X2ludGVyZmFjZXMuaCBiL2luY2x1ZGUvcW9tL29iamVjdF9pbnRl
cmZhY2VzLmgKPiBpbmRleCA2NTJhMTZkMmJhLi42ODJiYTFkOWIwIDEwMDY0NAo+IC0tLSBhL2lu
Y2x1ZGUvcW9tL29iamVjdF9pbnRlcmZhY2VzLmgKPiArKysgYi9pbmNsdWRlL3FvbS9vYmplY3Rf
aW50ZXJmYWNlcy5oCj4gQEAgLTUxLDE0ICs1MSwxNCBAQCB0eXBlZGVmIHN0cnVjdCBVc2VyQ3Jl
YXRhYmxlQ2xhc3Mgewo+ICAKPiAgLyoqCj4gICAqIHVzZXJfY3JlYXRhYmxlX2NvbXBsZXRlOgo+
IC0gKiBAb2JqOiB0aGUgb2JqZWN0IHdob3NlIGNvbXBsZXRlKCkgbWV0aG9kIGlzIGNhbGxlZCBp
ZiBkZWZpbmVkCj4gKyAqIEB1YzogdGhlIHVzZXItY3JlYXRhYmxlIG9iamVjdCB3aG9zZSBjb21w
bGV0ZSgpIG1ldGhvZCBpcyBjYWxsZWQgaWYgZGVmaW5lZAo+ICAgKiBAZXJycDogaWYgYW4gZXJy
b3Igb2NjdXJzLCBhIHBvaW50ZXIgdG8gYW4gYXJlYSB0byBzdG9yZSB0aGUgZXJyb3IKPiAgICoK
PiAgICogV3JhcHBlciB0byBjYWxsIGNvbXBsZXRlKCkgbWV0aG9kIGlmIG9uZSBvZiB0eXBlcyBp
dCdzIGluaGVyaXRlZAo+ICAgKiBmcm9tIGltcGxlbWVudHMgVVNFUl9DUkVBVEFCTEUgaW50ZXJm
YWNlLCBvdGhlcndpc2UgdGhlIGNhbGwgZG9lcwo+ICAgKiBub3RoaW5nLgo+ICAgKi8KPiAtdm9p
ZCB1c2VyX2NyZWF0YWJsZV9jb21wbGV0ZShPYmplY3QgKm9iaiwgRXJyb3IgKiplcnJwKTsKPiAr
dm9pZCB1c2VyX2NyZWF0YWJsZV9jb21wbGV0ZShVc2VyQ3JlYXRhYmxlICp1YywgRXJyb3IgKipl
cnJwKTsKPiAgCj4gIC8qKgo+ICAgKiB1c2VyX2NyZWF0YWJsZV9jYW5fYmVfZGVsZXRlZDoKPiBk
aWZmIC0tZ2l0IGEvaHcvbWlzYy9pdnNobWVtLmMgYi9ody9taXNjL2l2c2htZW0uYwo+IGluZGV4
IGY4ODkxMGU1NWMuLjQ3OGY0MTA0NGMgMTAwNjQ0Cj4gLS0tIGEvaHcvbWlzYy9pdnNobWVtLmMK
PiArKysgYi9ody9taXNjL2l2c2htZW0uYwo+IEBAIC0xMjc5LDcgKzEyNzksNyBAQCBzdGF0aWMg
dm9pZCBkZXN1Z2FyX3NobShJVlNobWVtU3RhdGUgKnMpCj4gICAgICBvYmplY3RfcHJvcGVydHlf
c2V0X2Jvb2wob2JqLCB0cnVlLCAic2hhcmUiLCAmZXJyb3JfYWJvcnQpOwo+ICAgICAgb2JqZWN0
X3Byb3BlcnR5X2FkZF9jaGlsZChPQkpFQ1QocyksICJpbnRlcm5hbC1zaG0tYmFja2VuZCIsIG9i
aiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmVycm9yX2Fib3J0KTsKPiAtICAg
IHVzZXJfY3JlYXRhYmxlX2NvbXBsZXRlKG9iaiwgJmVycm9yX2Fib3J0KTsKPiArICAgIHVzZXJf
Y3JlYXRhYmxlX2NvbXBsZXRlKFVTRVJfQ1JFQVRBQkxFKG9iaiksICZlcnJvcl9hYm9ydCk7Cj4g
ICAgICBzLT5ob3N0bWVtID0gTUVNT1JZX0JBQ0tFTkQob2JqKTsKPiAgfQo+ICAKPiBkaWZmIC0t
Z2l0IGEvaHcvdmlydGlvL3ZpcnRpby1ybmcuYyBiL2h3L3ZpcnRpby92aXJ0aW8tcm5nLmMKPiBp
bmRleCA4NTVmMWI0MWQxLi4zMDQ5M2EyNTg2IDEwMDY0NAo+IC0tLSBhL2h3L3ZpcnRpby92aXJ0
aW8tcm5nLmMKPiArKysgYi9ody92aXJ0aW8vdmlydGlvLXJuZy5jCj4gQEAgLTE5MSw3ICsxOTEs
NyBAQCBzdGF0aWMgdm9pZCB2aXJ0aW9fcm5nX2RldmljZV9yZWFsaXplKERldmljZVN0YXRlICpk
ZXYsIEVycm9yICoqZXJycCkKPiAgICAgIGlmICh2cm5nLT5jb25mLnJuZyA9PSBOVUxMKSB7Cj4g
ICAgICAgICAgdnJuZy0+Y29uZi5kZWZhdWx0X2JhY2tlbmQgPSBSTkdfUkFORE9NKG9iamVjdF9u
ZXcoVFlQRV9STkdfUkFORE9NKSk7Cj4gIAo+IC0gICAgICAgIHVzZXJfY3JlYXRhYmxlX2NvbXBs
ZXRlKE9CSkVDVCh2cm5nLT5jb25mLmRlZmF1bHRfYmFja2VuZCksCj4gKyAgICAgICAgdXNlcl9j
cmVhdGFibGVfY29tcGxldGUoVVNFUl9DUkVBVEFCTEUodnJuZy0+Y29uZi5kZWZhdWx0X2JhY2tl
bmQpLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZsb2NhbF9lcnIpOwo+ICAg
ICAgICAgIGlmIChsb2NhbF9lcnIpIHsKPiAgICAgICAgICAgICAgZXJyb3JfcHJvcGFnYXRlKGVy
cnAsIGxvY2FsX2Vycik7Cj4gZGlmZiAtLWdpdCBhL3FvbS9vYmplY3QuYyBiL3FvbS9vYmplY3Qu
Ywo+IGluZGV4IDU0N2RjZjk3YzMuLmViNzcwZGJmN2YgMTAwNjQ0Cj4gLS0tIGEvcW9tL29iamVj
dC5jCj4gKysrIGIvcW9tL29iamVjdC5jCj4gQEAgLTQxNyw2ICs0MTcsNyBAQCB2b2lkIG9iamVj
dF9pbml0aWFsaXplX2NoaWxkdihPYmplY3QgKnBhcmVudG9iaiwgY29uc3QgY2hhciAqcHJvcG5h
bWUsCj4gIHsKPiAgICAgIEVycm9yICpsb2NhbF9lcnIgPSBOVUxMOwo+ICAgICAgT2JqZWN0ICpv
Ymo7Cj4gKyAgICBVc2VyQ3JlYXRhYmxlICp1YzsKPiAgCj4gICAgICBvYmplY3RfaW5pdGlhbGl6
ZShjaGlsZG9iaiwgc2l6ZSwgdHlwZSk7Cj4gICAgICBvYmogPSBPQkpFQ1QoY2hpbGRvYmopOwo+
IEBAIC00MzEsOCArNDMyLDkgQEAgdm9pZCBvYmplY3RfaW5pdGlhbGl6ZV9jaGlsZHYoT2JqZWN0
ICpwYXJlbnRvYmosIGNvbnN0IGNoYXIgKnByb3BuYW1lLAo+ICAgICAgICAgIGdvdG8gb3V0Owo+
ICAgICAgfQo+ICAKPiAtICAgIGlmIChvYmplY3RfZHluYW1pY19jYXN0KG9iaiwgVFlQRV9VU0VS
X0NSRUFUQUJMRSkpIHsKPiAtICAgICAgICB1c2VyX2NyZWF0YWJsZV9jb21wbGV0ZShvYmosICZs
b2NhbF9lcnIpOwo+ICsgICAgdWMgPSAoVXNlckNyZWF0YWJsZSAqKW9iamVjdF9keW5hbWljX2Nh
c3Qob2JqLCBUWVBFX1VTRVJfQ1JFQVRBQkxFKTsKPiArICAgIGlmICh1Yykgewo+ICsgICAgICAg
IHVzZXJfY3JlYXRhYmxlX2NvbXBsZXRlKHVjLCAmbG9jYWxfZXJyKTsKPiAgICAgICAgICBpZiAo
bG9jYWxfZXJyKSB7Cj4gICAgICAgICAgICAgIG9iamVjdF91bnBhcmVudChvYmopOwo+ICAgICAg
ICAgICAgICBnb3RvIG91dDsKPiBAQCAtNTkwLDYgKzU5Miw3IEBAIE9iamVjdCAqb2JqZWN0X25l
d193aXRoX3Byb3B2KGNvbnN0IGNoYXIgKnR5cGVuYW1lLAo+ICAgICAgT2JqZWN0ICpvYmo7Cj4g
ICAgICBPYmplY3RDbGFzcyAqa2xhc3M7Cj4gICAgICBFcnJvciAqbG9jYWxfZXJyID0gTlVMTDsK
PiArICAgIFVzZXJDcmVhdGFibGUgKnVjOwo+ICAKPiAgICAgIGtsYXNzID0gb2JqZWN0X2NsYXNz
X2J5X25hbWUodHlwZW5hbWUpOwo+ICAgICAgaWYgKCFrbGFzcykgewo+IEBAIC02MTIsOCArNjE1
LDkgQEAgT2JqZWN0ICpvYmplY3RfbmV3X3dpdGhfcHJvcHYoY29uc3QgY2hhciAqdHlwZW5hbWUs
Cj4gICAgICAgICAgZ290byBlcnJvcjsKPiAgICAgIH0KPiAgCj4gLSAgICBpZiAob2JqZWN0X2R5
bmFtaWNfY2FzdChvYmosIFRZUEVfVVNFUl9DUkVBVEFCTEUpKSB7Cj4gLSAgICAgICAgdXNlcl9j
cmVhdGFibGVfY29tcGxldGUob2JqLCAmbG9jYWxfZXJyKTsKPiArICAgIHVjID0gKFVzZXJDcmVh
dGFibGUgKilvYmplY3RfZHluYW1pY19jYXN0KG9iaiwgVFlQRV9VU0VSX0NSRUFUQUJMRSk7Cj4g
KyAgICBpZiAodWMpIHsKPiArICAgICAgICB1c2VyX2NyZWF0YWJsZV9jb21wbGV0ZSh1YywgJmxv
Y2FsX2Vycik7Cj4gICAgICAgICAgaWYgKGxvY2FsX2Vycikgewo+ICAgICAgICAgICAgICBvYmpl
Y3RfdW5wYXJlbnQob2JqKTsKPiAgICAgICAgICAgICAgZ290byBlcnJvcjsKPiBkaWZmIC0tZ2l0
IGEvcW9tL29iamVjdF9pbnRlcmZhY2VzLmMgYi9xb20vb2JqZWN0X2ludGVyZmFjZXMuYwo+IGlu
ZGV4IDk3Yjc5YjQ4YmIuLmRiODVkMWViNzUgMTAwNjQ0Cj4gLS0tIGEvcW9tL29iamVjdF9pbnRl
cmZhY2VzLmMKPiArKysgYi9xb20vb2JqZWN0X2ludGVyZmFjZXMuYwo+IEBAIC04LDE4ICs4LDEw
IEBACj4gICNpbmNsdWRlICJxYXBpL29wdHMtdmlzaXRvci5oIgo+ICAjaW5jbHVkZSAicWVtdS9j
b25maWctZmlsZS5oIgo+ICAKPiAtdm9pZCB1c2VyX2NyZWF0YWJsZV9jb21wbGV0ZShPYmplY3Qg
Km9iaiwgRXJyb3IgKiplcnJwKQo+ICt2b2lkIHVzZXJfY3JlYXRhYmxlX2NvbXBsZXRlKFVzZXJD
cmVhdGFibGUgKnVjLCBFcnJvciAqKmVycnApCj4gIHsKPiArICAgIFVzZXJDcmVhdGFibGVDbGFz
cyAqdWNjID0gVVNFUl9DUkVBVEFCTEVfR0VUX0NMQVNTKHVjKTsKPiAgCj4gLSAgICBVc2VyQ3Jl
YXRhYmxlQ2xhc3MgKnVjYzsKPiAtICAgIFVzZXJDcmVhdGFibGUgKnVjID0KPiAtICAgICAgICAo
VXNlckNyZWF0YWJsZSAqKW9iamVjdF9keW5hbWljX2Nhc3Qob2JqLCBUWVBFX1VTRVJfQ1JFQVRB
QkxFKTsKPiAtCj4gLSAgICBpZiAoIXVjKSB7Cj4gLSAgICAgICAgcmV0dXJuOwo+IC0gICAgfQo+
IC0KPiAtICAgIHVjYyA9IFVTRVJfQ1JFQVRBQkxFX0dFVF9DTEFTUyh1Yyk7Cj4gICAgICBpZiAo
dWNjLT5jb21wbGV0ZSkgewo+ICAgICAgICAgIHVjYy0+Y29tcGxldGUodWMsIGVycnApOwo+ICAg
ICAgfQo+IEBAIC04OSw3ICs4MSw3IEBAIE9iamVjdCAqdXNlcl9jcmVhdGFibGVfYWRkX3R5cGUo
Y29uc3QgY2hhciAqdHlwZSwgY29uc3QgY2hhciAqaWQsCj4gICAgICAgICAgZ290byBvdXQ7Cj4g
ICAgICB9Cj4gIAo+IC0gICAgdXNlcl9jcmVhdGFibGVfY29tcGxldGUob2JqLCAmbG9jYWxfZXJy
KTsKPiArICAgIHVzZXJfY3JlYXRhYmxlX2NvbXBsZXRlKFVTRVJfQ1JFQVRBQkxFKG9iaiksICZs
b2NhbF9lcnIpOwo+ICAgICAgaWYgKGxvY2FsX2Vycikgewo+ICAgICAgICAgIG9iamVjdF9wcm9w
ZXJ0eV9kZWwob2JqZWN0X2dldF9vYmplY3RzX3Jvb3QoKSwKPiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIGlkLCAmZXJyb3JfYWJvcnQpOwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp
c3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9s
aXN0aW5mby94ZW4tZGV2ZWw=