From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [PATCH for-3.2 v3 07/14] qdev: all globals are now user-provided Date: Fri, 23 Nov 2018 15:20:22 +0100 Message-ID: <20181123152022.2a07375b@redhat.com> References: <20181107123652.23417-1-marcandre.lureau@redhat.com> <20181107123652.23417-8-marcandre.lureau@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gQCJv-0007qR-TQ for xen-devel@lists.xenproject.org; Fri, 23 Nov 2018 14:20:35 +0000 In-Reply-To: <20181107123652.23417-8-marcandre.lureau@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , Corey Minyard , Amit Shah , =?UTF-8?B?SGVydsOp?= Poussineau , "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-devel@nongnu.org, dgilbert@redhat.com, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Marcel Apfelbaum , xen-devel@lists.xenproject.org, Anthony Perard , Paolo Bonzini , Stefan Berger , Andreas =?UTF-8?B?RsOkcmJlcg==?= , Artyom Tarasenko , Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAgNyBOb3YgMjAxOCAxNjozNjo0NSArMDQwMApNYXJjLUFuZHLDqSBMdXJlYXUgPG1h cmNhbmRyZS5sdXJlYXVAcmVkaGF0LmNvbT4gd3JvdGU6Cgo+IENvbnNpZGVyaW5nIHRoYXQgQ1BV IGZlYXR1cmVzIGFyZSBwcm92aWRlZCB2aWEgY29tbWFuZCBsaW5lLCB0aGUKSSBjYW4gZ3Vlc3Mg d2hhdCBpdCBpcyBhYm91dCBvbmNlIEkgcmVjYWxsIGhvdyAtY3B1IGZvbywrLWZlYXQgd29ya3Ms CmJ1dCB3aXRob3V0IHRoYXQga25vd2xlZGdlIEkgZG9uJ3QgZ2V0IG1lYW5pbmcgYmVoaW5kIHRo ZSBzZW50ZW5jZS4KQ291bGQgeW91IHJlcGhyYXNlIGl0PwoKPiBnbG9iYWxfcHJvcHMgYXJlIG5v dyBhbGwgdXNlci1wcm92aWRlZCBnbG9iYWxzLiBObyBuZWVkIHRvIHRyYWNrIHRoaXMKPiBhbnlt b3JlIGZvciBxZGV2X3Byb3BfY2hlY2tfZ2xvYmFscygpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1h cmMtQW5kcsOpIEx1cmVhdSA8bWFyY2FuZHJlLmx1cmVhdUByZWRoYXQuY29tPgo+IC0tLQo+ICBp bmNsdWRlL2h3L3FkZXYtY29yZS5oICAgICAgICAgfCAgMyAtLQo+ICBody9jb3JlL3FkZXYtcHJv cGVydGllcy5jICAgICAgfCAgNCAtLS0KPiAgdGVzdHMvdGVzdC1xZGV2LWdsb2JhbC1wcm9wcy5j IHwgNTcgKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICB2bC5jICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAgMSAtCj4gIDQgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25z KCspLCA1OSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9ody9xZGV2LWNv cmUuaCBiL2luY2x1ZGUvaHcvcWRldi1jb3JlLmgKPiBpbmRleCBhMjRkMGRkNTY2Li5iYWFmMDk3 MjEyIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvaHcvcWRldi1jb3JlLmgKPiArKysgYi9pbmNsdWRl L2h3L3FkZXYtY29yZS5oCj4gQEAgLTI0OSw4ICsyNDksNiBAQCBzdHJ1Y3QgUHJvcGVydHlJbmZv IHsKPiAgCj4gIC8qKgo+ICAgKiBHbG9iYWxQcm9wZXJ0eToKPiAtICogQHVzZXJfcHJvdmlkZWQ6 IFNldCB0byB0cnVlIGlmIHByb3BlcnR5IGNvbWVzIGZyb20gdXNlci1wcm92aWRlZCBjb25maWcK PiAtICogKGNvbW1hbmQtbGluZSBvciBjb25maWcgZmlsZSkuCj4gICAqIEB1c2VkOiBTZXQgdG8g dHJ1ZSBpZiBwcm9wZXJ0eSB3YXMgdXNlZCB3aGVuIGluaXRpYWxpemluZyBhIGRldmljZS4KPiAg ICogQGVycnA6IEVycm9yIGRlc3RpbmF0aW9uLCB1c2VkIGxpa2UgZmlyc3QgYXJndW1lbnQgb2Yg ZXJyb3Jfc2V0ZygpCj4gICAqICAgICAgICBpbiBjYXNlIHByb3BlcnR5IHNldHRpbmcgZmFpbHMg bGF0ZXIuIElmIEBlcnJwIGlzIE5VTEwsIHdlCj4gQEAgLTI2Miw3ICsyNjAsNiBAQCB0eXBlZGVm IHN0cnVjdCBHbG9iYWxQcm9wZXJ0eSB7Cj4gICAgICBjb25zdCBjaGFyICpkcml2ZXI7Cj4gICAg ICBjb25zdCBjaGFyICpwcm9wZXJ0eTsKPiAgICAgIGNvbnN0IGNoYXIgKnZhbHVlOwo+IC0gICAg Ym9vbCB1c2VyX3Byb3ZpZGVkOwo+ICAgICAgYm9vbCB1c2VkOwo+ICAgICAgRXJyb3IgKiplcnJw Owo+ICB9IEdsb2JhbFByb3BlcnR5Owo+IGRpZmYgLS1naXQgYS9ody9jb3JlL3FkZXYtcHJvcGVy dGllcy5jIGIvaHcvY29yZS9xZGV2LXByb3BlcnRpZXMuYwo+IGluZGV4IGJkODRjNGVhNGMuLjQz YzMwYTU3ZjQgMTAwNjQ0Cj4gLS0tIGEvaHcvY29yZS9xZGV2LXByb3BlcnRpZXMuYwo+ICsrKyBi L2h3L2NvcmUvcWRldi1wcm9wZXJ0aWVzLmMKPiBAQCAtMTE5Miw5ICsxMTkyLDYgQEAgaW50IHFk ZXZfcHJvcF9jaGVja19nbG9iYWxzKHZvaWQpCj4gICAgICAgICAgaWYgKHByb3AtPnVzZWQpIHsK PiAgICAgICAgICAgICAgY29udGludWU7Cj4gICAgICAgICAgfQo+IC0gICAgICAgIGlmICghcHJv cC0+dXNlcl9wcm92aWRlZCkgewo+IC0gICAgICAgICAgICBjb250aW51ZTsKPiAtICAgICAgICB9 Cj4gICAgICAgICAgb2MgPSBvYmplY3RfY2xhc3NfYnlfbmFtZShwcm9wLT5kcml2ZXIpOwo+ICAg ICAgICAgIG9jID0gb2JqZWN0X2NsYXNzX2R5bmFtaWNfY2FzdChvYywgVFlQRV9ERVZJQ0UpOwo+ ICAgICAgICAgIGlmICghb2MpIHsKPiBAQCAtMTIzMyw3ICsxMjMwLDYgQEAgdm9pZCBxZGV2X3By b3Bfc2V0X2dsb2JhbHMoRGV2aWNlU3RhdGUgKmRldikKPiAgICAgICAgICAgICAgaWYgKCFkZXYt PmhvdHBsdWdnZWQgJiYgcHJvcC0+ZXJycCkgewo+ICAgICAgICAgICAgICAgICAgZXJyb3JfcHJv cGFnYXRlKHByb3AtPmVycnAsIGVycik7Cj4gICAgICAgICAgICAgIH0gZWxzZSB7Cj4gLSAgICAg ICAgICAgICAgICBhc3NlcnQocHJvcC0+dXNlcl9wcm92aWRlZCk7Cj4gICAgICAgICAgICAgICAg ICB3YXJuX3JlcG9ydF9lcnIoZXJyKTsKPiAgICAgICAgICAgICAgfQo+ICAgICAgICAgIH0KPiBk aWZmIC0tZ2l0IGEvdGVzdHMvdGVzdC1xZGV2LWdsb2JhbC1wcm9wcy5jIGIvdGVzdHMvdGVzdC1x ZGV2LWdsb2JhbC1wcm9wcy5jCj4gaW5kZXggM2E4ZDMxNzBhMC4uZjQ5YTFiNzBiNSAxMDA2NDQK PiAtLS0gYS90ZXN0cy90ZXN0LXFkZXYtZ2xvYmFsLXByb3BzLmMKPiArKysgYi90ZXN0cy90ZXN0 LXFkZXYtZ2xvYmFsLXByb3BzLmMKPiBAQCAtMjE1LDEyICsyMTUsMTIgQEAgc3RhdGljIHZvaWQg dGVzdF9keW5hbWljX2dsb2JhbHByb3Bfc3VicHJvY2Vzcyh2b2lkKQo+ICB7Cj4gICAgICBNeVR5 cGUgKm10Owo+ICAgICAgc3RhdGljIEdsb2JhbFByb3BlcnR5IHByb3BzW10gPSB7Cj4gLSAgICAg ICAgeyBUWVBFX0RZTkFNSUNfUFJPUFMsICJwcm9wMSIsICIxMDEiLCB0cnVlIH0sCj4gLSAgICAg ICAgeyBUWVBFX0RZTkFNSUNfUFJPUFMsICJwcm9wMiIsICIxMDIiLCB0cnVlIH0sCj4gLSAgICAg ICAgeyBUWVBFX0RZTkFNSUNfUFJPUFMiLWJhZCIsICJwcm9wMyIsICIxMDMiLCB0cnVlIH0sCj4g LSAgICAgICAgeyBUWVBFX1VOVVNFRF9IT1RQTFVHLCAicHJvcDQiLCAiMTA0IiwgdHJ1ZSB9LAo+ IC0gICAgICAgIHsgVFlQRV9VTlVTRURfTk9IT1RQTFVHLCAicHJvcDUiLCAiMTA1IiwgdHJ1ZSB9 LAo+IC0gICAgICAgIHsgVFlQRV9OT05ERVZJQ0UsICJwcm9wNiIsICIxMDYiLCB0cnVlIH0sCj4g KyAgICAgICAgeyBUWVBFX0RZTkFNSUNfUFJPUFMsICJwcm9wMSIsICIxMDEiLCB9LAo+ICsgICAg ICAgIHsgVFlQRV9EWU5BTUlDX1BST1BTLCAicHJvcDIiLCAiMTAyIiwgfSwKPiArICAgICAgICB7 IFRZUEVfRFlOQU1JQ19QUk9QUyItYmFkIiwgInByb3AzIiwgIjEwMyIsIH0sCj4gKyAgICAgICAg eyBUWVBFX1VOVVNFRF9IT1RQTFVHLCAicHJvcDQiLCAiMTA0IiwgfSwKPiArICAgICAgICB7IFRZ UEVfVU5VU0VEX05PSE9UUExVRywgInByb3A1IiwgIjEwNSIsIH0sCj4gKyAgICAgICAgeyBUWVBF X05PTkRFVklDRSwgInByb3A2IiwgIjEwNiIsIH0sCj4gICAgICAgICAge30KPiAgICAgIH07Cj4g ICAgICBpbnQgZ2xvYmFsX2Vycm9yOwo+IEBAIC0yNTUsNDYgKzI1NSw2IEBAIHN0YXRpYyB2b2lk IHRlc3RfZHluYW1pY19nbG9iYWxwcm9wKHZvaWQpCj4gICAgICBnX3Rlc3RfdHJhcF9hc3NlcnRf c3Rkb3V0KCIiKTsKPiAgfQo+ICAKPiAtLyogVGVzdCBzZXR0aW5nIG9mIGR5bmFtaWMgcHJvcGVy dGllcyB1c2luZyB1c2VyX3Byb3ZpZGVkPWZhbHNlIHByb3BlcnRpZXMgKi8KPiAtc3RhdGljIHZv aWQgdGVzdF9keW5hbWljX2dsb2JhbHByb3Bfbm91c2VyX3N1YnByb2Nlc3Modm9pZCkKPiAtewo+ IC0gICAgTXlUeXBlICptdDsKPiAtICAgIHN0YXRpYyBHbG9iYWxQcm9wZXJ0eSBwcm9wc1tdID0g ewo+IC0gICAgICAgIHsgVFlQRV9EWU5BTUlDX1BST1BTLCAicHJvcDEiLCAiMTAxIiB9LAo+IC0g ICAgICAgIHsgVFlQRV9EWU5BTUlDX1BST1BTLCAicHJvcDIiLCAiMTAyIiB9LAo+IC0gICAgICAg IHsgVFlQRV9EWU5BTUlDX1BST1BTIi1iYWQiLCAicHJvcDMiLCAiMTAzIiB9LAo+IC0gICAgICAg IHsgVFlQRV9VTlVTRURfSE9UUExVRywgInByb3A0IiwgIjEwNCIgfSwKPiAtICAgICAgICB7IFRZ UEVfVU5VU0VEX05PSE9UUExVRywgInByb3A1IiwgIjEwNSIgfSwKPiAtICAgICAgICB7IFRZUEVf Tk9OREVWSUNFLCAicHJvcDYiLCAiMTA2IiB9LAo+IC0gICAgICAgIHt9Cj4gLSAgICB9Owo+IC0g ICAgaW50IGdsb2JhbF9lcnJvcjsKPiAtCj4gLSAgICByZWdpc3Rlcl9nbG9iYWxfcHJvcGVydGll cyhwcm9wcyk7Cj4gLQo+IC0gICAgbXQgPSBEWU5BTUlDX1RZUEUob2JqZWN0X25ldyhUWVBFX0RZ TkFNSUNfUFJPUFMpKTsKPiAtICAgIHFkZXZfaW5pdF9ub2ZhaWwoREVWSUNFKG10KSk7Cj4gLQo+ IC0gICAgZ19hc3NlcnRfY21wdWludChtdC0+cHJvcDEsID09LCAxMDEpOwo+IC0gICAgZ19hc3Nl cnRfY21wdWludChtdC0+cHJvcDIsID09LCAxMDIpOwo+IC0gICAgZ2xvYmFsX2Vycm9yID0gcWRl dl9wcm9wX2NoZWNrX2dsb2JhbHMoKTsKPiAtICAgIGdfYXNzZXJ0X2NtcHVpbnQoZ2xvYmFsX2Vy cm9yLCA9PSwgMCk7Cj4gLSAgICBnX2Fzc2VydChwcm9wc1swXS51c2VkKTsKPiAtICAgIGdfYXNz ZXJ0KHByb3BzWzFdLnVzZWQpOwo+IC0gICAgZ19hc3NlcnQoIXByb3BzWzJdLnVzZWQpOwo+IC0g ICAgZ19hc3NlcnQoIXByb3BzWzNdLnVzZWQpOwo+IC0gICAgZ19hc3NlcnQoIXByb3BzWzRdLnVz ZWQpOwo+IC0gICAgZ19hc3NlcnQoIXByb3BzWzVdLnVzZWQpOwo+IC19Cj4gLQo+IC1zdGF0aWMg dm9pZCB0ZXN0X2R5bmFtaWNfZ2xvYmFscHJvcF9ub3VzZXIodm9pZCkKPiAtewo+IC0gICAgZ190 ZXN0X3RyYXBfc3VicHJvY2VzcygiL3FkZXYvcHJvcGVydGllcy9keW5hbWljL2dsb2JhbC9ub3Vz ZXIvc3VicHJvY2VzcyIsIDAsIDApOwo+IC0gICAgZ190ZXN0X3RyYXBfYXNzZXJ0X3Bhc3NlZCgp Owo+IC0gICAgZ190ZXN0X3RyYXBfYXNzZXJ0X3N0ZGVycigiIik7Cj4gLSAgICBnX3Rlc3RfdHJh cF9hc3NlcnRfc3Rkb3V0KCIiKTsKPiAtfQo+IC0KPiAgLyogVGVzdCBpZiBnbG9iYWwgcHJvcHMg YWZmZWN0aW5nIHN1YmNsYXNzZXMgYXJlIGFwcGxpZWQgaW4gdGhlIHJpZ2h0IG9yZGVyICovCj4g IHN0YXRpYyB2b2lkIHRlc3Rfc3ViY2xhc3NfZ2xvYmFsX3Byb3BzKHZvaWQpCj4gIHsKPiBAQCAt MzQ0LDExICszMDQsNiBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCj4gICAgICBn X3Rlc3RfYWRkX2Z1bmMoIi9xZGV2L3Byb3BlcnRpZXMvZHluYW1pYy9nbG9iYWwiLAo+ICAgICAg ICAgICAgICAgICAgICAgIHRlc3RfZHluYW1pY19nbG9iYWxwcm9wKTsKPiAgCj4gLSAgICBnX3Rl c3RfYWRkX2Z1bmMoIi9xZGV2L3Byb3BlcnRpZXMvZHluYW1pYy9nbG9iYWwvbm91c2VyL3N1YnBy b2Nlc3MiLAo+IC0gICAgICAgICAgICAgICAgICAgIHRlc3RfZHluYW1pY19nbG9iYWxwcm9wX25v dXNlcl9zdWJwcm9jZXNzKTsKPiAtICAgIGdfdGVzdF9hZGRfZnVuYygiL3FkZXYvcHJvcGVydGll cy9keW5hbWljL2dsb2JhbC9ub3VzZXIiLAo+IC0gICAgICAgICAgICAgICAgICAgIHRlc3RfZHlu YW1pY19nbG9iYWxwcm9wX25vdXNlcik7Cj4gLQo+ICAgICAgZ190ZXN0X2FkZF9mdW5jKCIvcWRl di9wcm9wZXJ0aWVzL2dsb2JhbC9zdWJjbGFzcyIsCj4gICAgICAgICAgICAgICAgICAgICAgdGVz dF9zdWJjbGFzc19nbG9iYWxfcHJvcHMpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvdmwuYyBiL3ZsLmMK PiBpbmRleCAyYWVhODg0YzlkLi5kMTFiMDcwZTcwIDEwMDY0NAo+IC0tLSBhL3ZsLmMKPiArKysg Yi92bC5jCj4gQEAgLTI5MzEsNyArMjkzMSw2IEBAIHN0YXRpYyBpbnQgZ2xvYmFsX2luaXRfZnVu Yyh2b2lkICpvcGFxdWUsIFFlbXVPcHRzICpvcHRzLCBFcnJvciAqKmVycnApCj4gICAgICBnLT5k cml2ZXIgICA9IHFlbXVfb3B0X2dldChvcHRzLCAiZHJpdmVyIik7Cj4gICAgICBnLT5wcm9wZXJ0 eSA9IHFlbXVfb3B0X2dldChvcHRzLCAicHJvcGVydHkiKTsKPiAgICAgIGctPnZhbHVlICAgID0g cWVtdV9vcHRfZ2V0KG9wdHMsICJ2YWx1ZSIpOwo+IC0gICAgZy0+dXNlcl9wcm92aWRlZCA9IHRy dWU7Cj4gICAgICBnLT5lcnJwID0gJmVycm9yX2ZhdGFsOwo+ICAgICAgcWRldl9wcm9wX3JlZ2lz dGVyX2dsb2JhbChnKTsKPiAgICAgIHJldHVybiAwOwoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tZGV2ZWw=