From: Wei Liu <wei.liu2@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wei.liu2@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH RFC 27/55] x86_64/mm: drop lXe_to_lYe invocations from setup_m2p_table
Date: Thu, 7 Feb 2019 16:44:28 +0000 [thread overview]
Message-ID: <20190207164456.9260-28-wei.liu2@citrix.com> (raw)
In-Reply-To: <20190207164456.9260-1-wei.liu2@citrix.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
xen/arch/x86/x86_64/mm.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
index 0b85961105..216f97c95f 100644
--- a/xen/arch/x86/x86_64/mm.c
+++ b/xen/arch/x86/x86_64/mm.c
@@ -400,11 +400,13 @@ static int setup_m2p_table(struct mem_hotadd_info *info)
l2_pgentry_t *pl2e = NULL, *l2_ro_mpt = NULL;
l3_pgentry_t *l3_ro_mpt = NULL;
int ret = 0;
- mfn_t l2_ro_mpt_mfn;
+ mfn_t l2_ro_mpt_mfn, l3_ro_mpt_mfn;
ASSERT(l4e_get_flags(idle_pg_table[l4_table_offset(RO_MPT_VIRT_START)])
& _PAGE_PRESENT);
- l3_ro_mpt = l4e_to_l3e(idle_pg_table[l4_table_offset(RO_MPT_VIRT_START)]);
+ l3_ro_mpt_mfn = l4e_get_mfn(idle_pg_table[l4_table_offset(
+ RO_MPT_VIRT_START)]);
+ l3_ro_mpt = map_xen_pagetable_new(l3_ro_mpt_mfn);
smap = (info->spfn & (~((1UL << (L2_PAGETABLE_SHIFT - 3)) -1)));
emap = ((info->epfn + ((1UL << (L2_PAGETABLE_SHIFT - 3)) - 1 )) &
@@ -459,8 +461,13 @@ static int setup_m2p_table(struct mem_hotadd_info *info)
_PAGE_PSE));
if ( l3e_get_flags(l3_ro_mpt[l3_table_offset(va)]) &
_PAGE_PRESENT )
- pl2e = l3e_to_l2e(l3_ro_mpt[l3_table_offset(va)]) +
- l2_table_offset(va);
+ {
+ UNMAP_XEN_PAGETABLE_NEW(l2_ro_mpt);
+ l2_ro_mpt_mfn = l3e_get_mfn(l3_ro_mpt[l3_table_offset(va)]);
+ l2_ro_mpt = map_xen_pagetable_new(l2_ro_mpt_mfn);
+ ASSERT(l2_ro_mpt);
+ pl2e = l2_ro_mpt + l2_table_offset(va);
+ }
else
{
UNMAP_XEN_PAGETABLE_NEW(l2_ro_mpt);
@@ -492,6 +499,7 @@ static int setup_m2p_table(struct mem_hotadd_info *info)
ret = setup_compat_m2p_table(info);
error:
UNMAP_XEN_PAGETABLE_NEW(l2_ro_mpt);
+ UNMAP_XEN_PAGETABLE_NEW(l3_ro_mpt);
return ret;
}
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-02-07 16:59 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 16:44 [PATCH RFC 00/55] x86: use domheap page for xen page tables Wei Liu
2019-02-07 16:44 ` [PATCH RFC 01/55] x86/mm: defer clearing page in virt_to_xen_lXe Wei Liu
2019-03-15 14:38 ` Jan Beulich
2019-04-09 12:21 ` Wei Liu
2019-04-09 12:21 ` [Xen-devel] " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 02/55] x86: move some xen mm function declarations Wei Liu
2019-03-15 14:42 ` Jan Beulich
2019-02-07 16:44 ` [PATCH RFC 03/55] x86: introduce a new set of APIs to manage Xen page tables Wei Liu
2019-02-07 16:44 ` [PATCH RFC 04/55] x86/mm: introduce l{1, 2}t local variables to map_pages_to_xen Wei Liu
2019-03-15 15:36 ` Jan Beulich
2019-04-09 12:22 ` Wei Liu
2019-04-09 12:22 ` [Xen-devel] " Wei Liu
2019-04-09 12:49 ` Jan Beulich
2019-04-09 12:49 ` [Xen-devel] " Jan Beulich
2019-04-09 12:59 ` Wei Liu
2019-04-09 12:59 ` [Xen-devel] " Wei Liu
2019-04-09 13:20 ` Jan Beulich
2019-04-09 13:20 ` [Xen-devel] " Jan Beulich
2019-02-07 16:44 ` [PATCH RFC 05/55] x86/mm: introduce l{1, 2}t local variables to modify_xen_mappings Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-02-07 16:44 ` [PATCH RFC 06/55] x86/mm: map_pages_to_xen should have one exit path Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-04-09 12:22 ` Wei Liu
2019-04-09 12:22 ` [Xen-devel] " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 07/55] x86/mm: add an end_of_loop label in map_pages_to_xen Wei Liu
2019-03-15 15:40 ` Jan Beulich
2019-04-09 12:22 ` Wei Liu
2019-04-09 12:22 ` [Xen-devel] " Wei Liu
2019-04-09 12:50 ` Jan Beulich
2019-04-09 12:50 ` [Xen-devel] " Jan Beulich
2019-03-18 21:14 ` Nuernberger, Stefan
2019-02-07 16:44 ` [PATCH RFC 08/55] x86/mm: make sure there is one exit path for modify_xen_mappings Wei Liu
2019-02-07 16:44 ` [PATCH RFC 09/55] x86/mm: add an end_of_loop label in modify_xen_mappings Wei Liu
2019-02-07 16:44 ` [PATCH RFC 10/55] x86/mm: change pl2e to l2t in virt_to_xen_l2e Wei Liu
2019-02-07 16:44 ` [PATCH RFC 11/55] x86/mm: change pl1e to l1t in virt_to_xen_l1e Wei Liu
2019-02-07 16:44 ` [PATCH RFC 12/55] x86/mm: change pl3e to l3t in virt_to_xen_l3e Wei Liu
2019-02-07 16:44 ` [PATCH RFC 13/55] x86/mm: rewrite virt_to_xen_l3e Wei Liu
2019-04-08 15:55 ` Jan Beulich
2019-04-08 15:55 ` [Xen-devel] " Jan Beulich
2019-04-09 12:27 ` Wei Liu
2019-04-09 12:27 ` [Xen-devel] " Wei Liu
2019-04-09 12:52 ` Jan Beulich
2019-04-09 12:52 ` [Xen-devel] " Jan Beulich
2019-02-07 16:44 ` [PATCH RFC 14/55] x86/mm: rewrite xen_to_virt_l2e Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-04-09 12:27 ` Wei Liu
2019-04-09 12:27 ` [Xen-devel] " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 15/55] x86/mm: rewrite virt_to_xen_l1e Wei Liu
2019-02-07 16:44 ` [PATCH RFC 16/55] x86/mm: switch to new APIs in map_pages_to_xen Wei Liu
2019-02-08 17:58 ` Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-02-07 16:44 ` [PATCH RFC 17/55] x86/mm: drop lXe_to_lYe invocations " Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-02-07 16:44 ` [PATCH RFC 18/55] x86/mm: switch to new APIs in modify_xen_mappings Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-04-09 12:22 ` Wei Liu
2019-04-09 12:22 ` [Xen-devel] " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 19/55] x86/mm: drop lXe_to_lYe invocations from modify_xen_mappings Wei Liu
2019-02-07 16:44 ` [PATCH RFC 20/55] x86/mm: switch to new APIs in arch_init_memory Wei Liu
2019-02-07 16:44 ` [PATCH RFC 21/55] x86_64/mm: introduce pl2e in paging_init Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-02-07 16:44 ` [PATCH RFC 22/55] x86_64/mm: switch to new APIs " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 23/55] x86_64/mm: drop l4e_to_l3e invocation from paging_init Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-04-09 12:22 ` Wei Liu
2019-04-09 12:22 ` [Xen-devel] " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 24/55] x86_64/mm.c: remove code that serves no purpose in setup_m2p_table Wei Liu
2019-02-07 16:44 ` [PATCH RFC 25/55] x86_64/mm: introduce pl2e " Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-02-07 16:44 ` [PATCH RFC 26/55] x86_64/mm: switch to new APIs " Wei Liu
2019-02-07 16:44 ` Wei Liu [this message]
2019-03-18 21:14 ` [PATCH RFC 27/55] x86_64/mm: drop lXe_to_lYe invocations from setup_m2p_table Nuernberger, Stefan
2019-04-09 12:30 ` Wei Liu
2019-04-09 12:30 ` [Xen-devel] " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 28/55] efi: use new page table APIs in copy_mapping Wei Liu
2019-02-07 16:44 ` [PATCH RFC 29/55] efi: avoid using global variable " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 30/55] efi: use new page table APIs in efi_init_memory Wei Liu
2019-02-07 16:44 ` [PATCH RFC 31/55] efi: add emacs block to boot.c Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-04-09 12:23 ` Wei Liu
2019-04-09 12:23 ` [Xen-devel] " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 32/55] efi: switch EFI L4 table to use new APIs Wei Liu
2019-03-18 21:14 ` Nuernberger, Stefan
2019-04-09 12:23 ` Wei Liu
2019-04-09 12:23 ` [Xen-devel] " Wei Liu
2019-04-09 12:56 ` Jan Beulich
2019-04-09 12:56 ` [Xen-devel] " Jan Beulich
2019-04-09 13:00 ` Wei Liu
2019-04-09 13:00 ` [Xen-devel] " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 33/55] x86/smpboot: add emacs block Wei Liu
2019-02-07 16:44 ` [PATCH RFC 34/55] x86/smpboot: clone_mapping should have one exit path Wei Liu
2019-02-07 16:44 ` [PATCH RFC 35/55] x86/smpboot: switch pl3e to use new APIs in clone_mapping Wei Liu
2019-02-07 16:44 ` [PATCH RFC 36/55] x86/smpboot: switch pl2e " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 37/55] x86/smpboot: switch pl1e " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 38/55] x86/smpboot: drop lXe_to_lYe invocations from cleanup_cpu_root_pgt Wei Liu
2019-02-07 16:44 ` [PATCH RFC 39/55] x86: switch root_pgt to mfn_t and use new APIs Wei Liu
2019-03-19 16:45 ` Nuernberger, Stefan
2019-04-09 12:23 ` Wei Liu
2019-04-09 12:23 ` [Xen-devel] " Wei Liu
2019-02-07 16:44 ` [PATCH RFC 40/55] x86/shim: map and unmap page tables in replace_va_mapping Wei Liu
2019-02-07 16:44 ` [PATCH RFC 41/55] x86_64/mm: map and unmap page tables in m2p_mapped Wei Liu
2019-03-19 16:45 ` Nuernberger, Stefan
2019-02-07 16:44 ` [PATCH RFC 42/55] x86_64/mm: map and unmap page tables in share_hotadd_m2p_table Wei Liu
2019-03-19 16:45 ` Nuernberger, Stefan
2019-02-07 16:44 ` [PATCH RFC 43/55] x86_64/mm: map and unmap page tables in destroy_compat_m2p_mapping Wei Liu
2019-02-07 16:44 ` [PATCH RFC 44/55] x86_64/mm: map and unmap page tables in destroy_m2p_mapping Wei Liu
2019-02-07 16:44 ` [PATCH RFC 45/55] x86_64/mm: map and unmap page tables in setup_compat_m2p_table Wei Liu
2019-02-07 16:44 ` [PATCH RFC 46/55] x86_64/mm: map and unmap page tables in cleanup_frame_table Wei Liu
2019-02-07 16:44 ` [PATCH RFC 47/55] x86_64/mm: map and unmap page tables in subarch_init_memory Wei Liu
2019-02-07 16:44 ` [PATCH RFC 48/55] x86_64/mm: map and unmap page tables in subarch_memory_op Wei Liu
2019-02-07 16:44 ` [PATCH RFC 49/55] x86/smpboot: remove lXe_to_lYe in cleanup_cpu_root_pgt Wei Liu
2019-02-07 16:44 ` [PATCH RFC 50/55] x86/pv: properly map and unmap page tables in mark_pv_pt_pages_rdonly Wei Liu
2019-02-07 16:44 ` [PATCH RFC 51/55] x86/pv: properly map and unmap page table in dom0_construct_pv Wei Liu
2019-02-07 16:44 ` [PATCH RFC 52/55] x86: remove lXe_to_lYe in __start_xen Wei Liu
2019-02-07 16:44 ` [PATCH RFC 53/55] x86/mm: drop old page table APIs Wei Liu
2019-02-07 16:44 ` [PATCH RFC 54/55] x86: switch to use domheap page for page tables Wei Liu
2019-02-07 16:44 ` [PATCH RFC 55/55] x86/mm: drop _new suffix from page table APIs Wei Liu
2019-03-18 21:14 ` [PATCH RFC 00/55] x86: use domheap page for xen page tables Nuernberger, Stefan
2019-03-28 12:52 ` Nuernberger, Stefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207164456.9260-28-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).