From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] x86/livepatch: Fail the build if duplicate symbols exist Date: Fri, 5 Apr 2019 17:02:50 -0400 Message-ID: <20190405210250.GA18169@char.us.oracle.com> References: <1554492364-21684-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1554492364-21684-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Stefano Stabellini , Wei Liu , Xen-devel , Ross Lagerwall , Julien Grall , Norbert Manthey , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBBcHIgMDUsIDIwMTkgYXQgMDg6MjY6MDRQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBGcm9tOiBSb3NzIExhZ2Vyd2FsbCA8cm9zcy5sYWdlcndhbGxAY2l0cml4LmNvbT4K PiAKPiBUaGUgYmluYXJ5IGRpZmZpbmcgYWxnb3JpdGhtIHVzZWQgYnkgeGVuLWxpdmVwYXRjaCBk ZXBlbmRzIG9uIGhhdmluZyB1bmlxdWUKPiBzeW1ib2xzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJv c3MgTGFnZXJ3YWxsIDxyb3NzLmxhZ2Vyd2FsbEBjaXRyaXguY29tPgo+IFNpZ25lZC1vZmYtYnk6 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBL b25yYWQgUnplc3p1dGVrIFdpbGsgPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+CgoKPiAtLS0KPiBD QzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPgo+IENDOiBXZWkgTGl1IDx3ZWkubGl1 MkBjaXRyaXguY29tPgo+IENDOiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNv bT4KPiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+IEND OiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgo+IENDOiBSb3NzIExhZ2Vyd2Fs bCA8cm9zcy5sYWdlcndhbGxAY2l0cml4LmNvbT4KPiBDQzogS29ucmFkIFJ6ZXN6dXRlayBXaWxr IDxrb25yYWQud2lsa0BvcmFjbGUuY29tPgo+IENDOiBOb3JiZXJ0IE1hbnRoZXkgPG5tYW50aGV5 QGFtYXpvbi5kZT4KPiAKPiBUaGlzIHBhdGNoIGhhcyBiZWVuIHBhcnQgb2YgdGhlIFhlblNlcnZl ciBwYXRjaHF1ZXVlIGZvciBhZ2VzLCBhbmQgc2hvdWxkIGhhdmUKPiBiZWVuIHVwc3RyZWFtZWQg c29vbmVyLiAgSXQgb2J2aW91c2x5IGNhbid0IGJlIGFwcGxpZWQgd2hpbGUgdGhlICJibG9jawo+ IHNwZWN1bGF0aW9uIiBpc3N1ZSBpcyBvdXRzdGFuZGluZy4KPiAtLS0KPiAgeGVuL2FyY2gveDg2 L01ha2VmaWxlIHwgIDEgKwo+ICB4ZW4vdG9vbHMvc3ltYm9scy5jICAgfCAxMSArKysrKysrKyst LQo+ICAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9NYWtlZmlsZSBiL3hlbi9hcmNoL3g4Ni9NYWtl ZmlsZQo+IGluZGV4IGVmMDk5MzkuLmQ0YWU0NmIgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2 L01ha2VmaWxlCj4gKysrIGIveGVuL2FyY2gveDg2L01ha2VmaWxlCj4gQEAgLTk4LDYgKzk4LDcg QEAgZW5kaWYKPiAgCj4gIHN5bXMtd2Fybi1kdXAteSA6PSAtLXdhcm4tZHVwCj4gIHN5bXMtd2Fy bi1kdXAtJChDT05GSUdfU1VQUFJFU1NfRFVQTElDQVRFX1NZTUJPTF9XQVJOSU5HUykgOj0KPiAr c3ltcy13YXJuLWR1cC0kKENPTkZJR19MSVZFUEFUQ0gpIDo9IC0tZXJyb3ItZHVwCj4gIAo+ICAk KFRBUkdFVCk6ICQoVEFSR0VUKS1zeW1zICQoZWZpLXkpIGJvb3QvbWtlbGYzMgo+ICAJLi9ib290 L21rZWxmMzIgJChub3Rlc19waGRycykgJChUQVJHRVQpLXN5bXMgJChUQVJHRVQpICQoWEVOX0lN R19PRkZTRVQpIFwKPiBkaWZmIC0tZ2l0IGEveGVuL3Rvb2xzL3N5bWJvbHMuYyBiL3hlbi90b29s cy9zeW1ib2xzLmMKPiBpbmRleCAwNTEzOWQxLi45ZjllMmM5IDEwMDY0NAo+IC0tLSBhL3hlbi90 b29scy9zeW1ib2xzLmMKPiArKysgYi94ZW4vdG9vbHMvc3ltYm9scy5jCj4gQEAgLTU5OSw3ICs1 OTksNyBAQCBzdGF0aWMgaW50IGNvbXBhcmVfbmFtZShjb25zdCB2b2lkICpwMSwgY29uc3Qgdm9p ZCAqcDIpCj4gIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKPiAgewo+ICAJdW5zaWdu ZWQgaW50IGk7Cj4gLQlib29sIHVuc29ydGVkID0gZmFsc2UsIHdhcm5fZHVwID0gZmFsc2U7Cj4g Kwlib29sIHVuc29ydGVkID0gZmFsc2UsIHdhcm5fZHVwID0gZmFsc2UsIGVycm9yX2R1cCA9IGZh bHNlLCBmb3VuZF9kdXAgPSBmYWxzZTsKPiAgCj4gIAlpZiAoYXJnYyA+PSAyKSB7Cj4gIAkJZm9y IChpID0gMTsgaSA8IGFyZ2M7IGkrKykgewo+IEBAIC02MTksNiArNjE5LDggQEAgaW50IG1haW4o aW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ICAJCQkJc29ydF9ieV9uYW1lID0gMTsKPiAgCQkJZWxz ZSBpZiAoc3RyY21wKGFyZ3ZbaV0sICItLXdhcm4tZHVwIikgPT0gMCkKPiAgCQkJCXdhcm5fZHVw ID0gdHJ1ZTsKPiArCQkJZWxzZSBpZiAoc3RyY21wKGFyZ3ZbaV0sICItLWVycm9yLWR1cCIpID09 IDApCj4gKwkJCQl3YXJuX2R1cCA9IGVycm9yX2R1cCA9IHRydWU7Cj4gIAkJCWVsc2UgaWYgKHN0 cmNtcChhcmd2W2ldLCAiLS14ZW5zeW1zIikgPT0gMCkKPiAgCQkJCW1hcF9vbmx5ID0gdHJ1ZTsK PiAgCQkJZWxzZQo+IEBAIC02MzQsMTQgKzYzNiwxOSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hh ciAqKmFyZ3YpCj4gIAkJZm9yIChpID0gMTsgaSA8IHRhYmxlX2NudDsgKytpKQo+ICAJCQlpZiAo c3RyY21wKFNZTUJPTF9OQU1FKHRhYmxlICsgaSAtIDEpLAo+ICAJCQkJICAgU1lNQk9MX05BTUUo dGFibGUgKyBpKSkgPT0gMCAmJgo+IC0JCQkgICAgdGFibGVbaSAtIDFdLmFkZHIgIT0gdGFibGVb aV0uYWRkcikKPiArCQkJICAgIHRhYmxlW2kgLSAxXS5hZGRyICE9IHRhYmxlW2ldLmFkZHIpIHsK PiAgCQkJCWZwcmludGYoc3RkZXJyLAo+ICAJCQkJCSJEdXBsaWNhdGUgc3ltYm9sICclcycgKCVs bHggIT0gJWxseClcbiIsCj4gIAkJCQkJU1lNQk9MX05BTUUodGFibGUgKyBpKSwKPiAgCQkJCQl0 YWJsZVtpXS5hZGRyLCB0YWJsZVtpIC0gMV0uYWRkcik7Cj4gKwkJCQlmb3VuZF9kdXAgPSB0cnVl Owo+ICsJCQl9Cj4gIAkJdW5zb3J0ZWQgPSB0cnVlOwo+ICAJfQo+ICAKPiArCWlmIChlcnJvcl9k dXAgJiYgZm91bmRfZHVwKQo+ICsJCWV4aXQoMSk7Cj4gKwo+ICAJaWYgKHVuc29ydGVkKQo+ICAJ CXFzb3J0KHRhYmxlLCB0YWJsZV9jbnQsIHNpemVvZigqdGFibGUpLCBjb21wYXJlX3ZhbHVlKTsK PiAgCj4gLS0gCj4gMi4xLjQKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94 ZW4tZGV2ZWw=