From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Reinoud Zandijk" <reinoud@netbsd.org>,
"David Hildenbrand" <david@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Woodhouse" <dwmw2@infradead.org>,
kvm@vger.kernel.org, "Eric Farman" <farman@linux.ibm.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
xen-devel@lists.xenproject.org, "Paul Durrant" <paul@xen.org>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Jason Herne" <jjherne@linux.ibm.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Anthony PERARD" <anthony@xenproject.org>,
qemu-s390x@nongnu.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Peter Xu" <peterx@redhat.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>
Subject: [PATCH 06/15] system/physmem: Pass address space argument to cpu_flush_icache_range()
Date: Mon, 29 Sep 2025 20:32:45 +0200 [thread overview]
Message-ID: <20250929183254.85478-7-philmd@linaro.org> (raw)
In-Reply-To: <20250929183254.85478-1-philmd@linaro.org>
Rename cpu_flush_icache_range() as address_space_flush_icache_range(),
passing an address space by argument. The single caller, rom_reset(),
already operates on an address space. Use it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/exec/cpu-common.h | 2 --
include/system/memory.h | 2 ++
hw/core/loader.c | 2 +-
system/physmem.c | 5 ++---
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
index a73463a7038..6c7d84aacb4 100644
--- a/include/exec/cpu-common.h
+++ b/include/exec/cpu-common.h
@@ -156,8 +156,6 @@ void cpu_physical_memory_unmap(void *buffer, hwaddr len,
*/
void qemu_flush_coalesced_mmio_buffer(void);
-void cpu_flush_icache_range(hwaddr start, hwaddr len);
-
typedef int (RAMBlockIterFunc)(RAMBlock *rb, void *opaque);
int qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque);
diff --git a/include/system/memory.h b/include/system/memory.h
index 6cfa22d7a80..00203522ae4 100644
--- a/include/system/memory.h
+++ b/include/system/memory.h
@@ -2977,6 +2977,8 @@ void address_space_cache_invalidate(MemoryRegionCache *cache,
*/
void address_space_cache_destroy(MemoryRegionCache *cache);
+void address_space_flush_icache_range(AddressSpace *as, hwaddr addr, hwaddr len);
+
/* address_space_get_iotlb_entry: translate an address into an IOTLB
* entry. Should be called from an RCU critical section.
*/
diff --git a/hw/core/loader.c b/hw/core/loader.c
index 524af6f14a0..477661a0255 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -1242,7 +1242,7 @@ static void rom_reset(void *unused)
* that the instruction cache for that new region is clear, so that the
* CPU definitely fetches its instructions from the just written data.
*/
- cpu_flush_icache_range(rom->addr, rom->datasize);
+ address_space_flush_icache_range(rom->as, rom->addr, rom->datasize);
trace_loader_write_rom(rom->name, rom->addr, rom->datasize, rom->isrom);
}
diff --git a/system/physmem.c b/system/physmem.c
index fd2331c8d01..dc458cedc3f 100644
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -3214,7 +3214,7 @@ MemTxResult address_space_write_rom(AddressSpace *as, hwaddr addr,
return MEMTX_OK;
}
-void cpu_flush_icache_range(hwaddr addr, hwaddr len)
+void address_space_flush_icache_range(AddressSpace *as, hwaddr addr, hwaddr len)
{
/*
* This function should do the same thing as an icache flush that was
@@ -3229,8 +3229,7 @@ void cpu_flush_icache_range(hwaddr addr, hwaddr len)
RCU_READ_LOCK_GUARD();
while (len > 0) {
hwaddr addr1, l = len;
- MemoryRegion *mr = address_space_translate(&address_space_memory,
- addr, &addr1, &l, true,
+ MemoryRegion *mr = address_space_translate(as, addr, &addr1, &l, true,
MEMTXATTRS_UNSPECIFIED);
if (!memory_region_supports_direct_access(mr)) {
--
2.51.0
next prev parent reply other threads:[~2025-09-29 18:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 18:32 [PATCH 00/15] system/physmem: Remove cpu_physical_memory _is_io() and _rw() Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 01/15] docs/devel/loads-stores: Stop mentioning cpu_physical_memory_write_rom() Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 02/15] system/memory: Factor address_space_memory_is_io() out Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 03/15] target/i386/arch_memory_mapping: Use address_space_memory_is_io() Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 04/15] hw/s390x/sclp: Use address_space_memory_is_io() in sclp_service_call() Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 05/15] system/physmem: Remove cpu_physical_memory_is_io() Philippe Mathieu-Daudé
2025-09-29 18:32 ` Philippe Mathieu-Daudé [this message]
2025-09-29 18:32 ` [PATCH 07/15] target/s390x/mmu: Replace [cpu_physical_memory -> address_space]_rw() Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 08/15] target/i386/whpx: Replace legacy cpu_physical_memory_rw() call Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 09/15] target/i386/kvm: " Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 10/15] target/i386/nvmm: Inline cpu_physical_memory_rw() in nvmm_mem_callback Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 11/15] hw/xen/hvm: Inline cpu_physical_memory_rw() in rw_phys_req_item() Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 12/15] system/physmem: Un-inline cpu_physical_memory_read/write() Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 13/15] system/physmem: Inline cpu_physical_memory_rw() and remove it Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 14/15] hw/virtio/vhost: Replace legacy cpu_physical_memory_*map() calls Philippe Mathieu-Daudé
2025-09-29 18:32 ` [PATCH 15/15] hw/virtio/virtio: Replace legacy cpu_physical_memory_map() call Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250929183254.85478-7-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=anthony@xenproject.org \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=dwmw2@infradead.org \
--cc=edgar.iglesias@gmail.com \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=reinoud@netbsd.org \
--cc=richard.henderson@linaro.org \
--cc=sgarzare@redhat.com \
--cc=sstabellini@kernel.org \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).