xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Jan Beulich" <JBeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Oleksii Kurochko" <oleksii.kurochko@gmail.com>
Subject: [PATCH 1/5] x86/ucode: Fix missing printk() newline in ucode_probe_amd()
Date: Mon, 20 Oct 2025 14:19:51 +0100	[thread overview]
Message-ID: <20251020131955.2928261-2-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <20251020131955.2928261-1-andrew.cooper3@citrix.com>

Fixes: 630e8875ab36 ("x86/ucode: Perform extra SHA2 checks on AMD Fam17h/19h microcode")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>

For 4.21.  This is a formatting fix with basically 0 risk.

It is encouraging that no-one has reported this bug so far, because it
suggests that no-one has turned off digest checking and then looked at dmesg.
---
 xen/arch/x86/cpu/microcode/amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c
index a5729229a403..59332da2b827 100644
--- a/xen/arch/x86/cpu/microcode/amd.c
+++ b/xen/arch/x86/cpu/microcode/amd.c
@@ -519,7 +519,7 @@ void __init ucode_probe_amd(struct microcode_ops *ops)
     if ( !opt_digest_check && boot_cpu_data.family >= 0x17 )
     {
         printk(XENLOG_WARNING
-               "Microcode patch additional digest checks disabled");
+               "Microcode patch additional digest checks disabled\n");
         add_taint(TAINT_CPU_OUT_OF_SPEC);
     }
 
-- 
2.39.5



  reply	other threads:[~2025-10-20 13:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 13:19 [PATCH for-4.21? 0/5] x86/ucode: Support loading latest ucode from linux-firwmare Andrew Cooper
2025-10-20 13:19 ` Andrew Cooper [this message]
2025-10-20 13:37   ` [PATCH 1/5] x86/ucode: Fix missing printk() newline in ucode_probe_amd() Jan Beulich
2025-10-20 15:02     ` Andrew Cooper
2025-10-20 13:19 ` [PATCH 2/5] x86/ucode: Abort parallel load early on any control thread error Andrew Cooper
2025-10-20 15:55   ` Jan Beulich
2025-10-22 19:28     ` Andrew Cooper
2025-10-23  6:24       ` Jan Beulich
2025-10-27 22:46         ` Andrew Cooper
2025-10-28  8:07           ` Jan Beulich
2025-10-20 13:19 ` [PATCH 3/5] x86/ucode: Refine TLB flush fix for AMD Fam17h CPUs Andrew Cooper
2025-10-21  8:34   ` Jan Beulich
2025-10-20 13:19 ` [PATCH 4/5] x86/ucode: Cross check the minimum revision Andrew Cooper
2025-10-21  9:18   ` Jan Beulich
2025-10-21  9:24     ` Andrew Cooper
2025-10-20 13:19 ` [PATCH 5/5] x86/ucode: Relax digest check when Entrysign is fixed in firmware Andrew Cooper
2025-10-20 15:06   ` Andrew Cooper
2025-10-21  9:47   ` Jan Beulich
2025-10-22 21:19     ` Andrew Cooper
2025-10-23  7:05       ` Jan Beulich
2025-10-27 21:42         ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251020131955.2928261-2-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=oleksii.kurochko@gmail.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).