From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Xen-devel] [PATCH] libxl: Spice usbredirection
 support for upstream qemu
Date: Fri, 5 Jul 2013 05:02:56 -0400 (EDT)
Message-ID: <2039015654.6402905.1373014976350.JavaMail.root@redhat.com>
References: <1372932359-4625-1-git-send-email-fabio.fantoni@m2r.biz>
	<51D54B8B.9010703@m2r.biz>
	<20130704103224.GT7483@zion.uk.xensource.com>
	<51D564CB.9090602@m2r.biz>
	<alpine.DEB.2.02.1307041341110.5067@kaball.uk.xensource.com>
	<51D5AE39.2010606@suse.de> <51D5D676.2080901@redhat.com>
	<51D686F6.8020606@m2r.biz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <51D686F6.8020606@m2r.biz>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
To: Fabio Fantoni <fabio.fantoni@m2r.biz>
Cc: xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, qemu-devel@nongnu.org, Hans de Goede <hdegoede@redhat.com>, spice-devel@lists.freedesktop.org, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
List-Id: xen-devel@lists.xenproject.org



----- Messaggio originale -----
> Da: "Fabio Fantoni" <fabio.fantoni@m2r.biz>
> A: "Paolo Bonzini" <pbonzini@redhat.com>
> Cc: "Andreas F=C3=A4rber" <afaerber@suse.de>, "Stefano Stabellini" <stefa=
no.stabellini@eu.citrix.com>,
> xen-devel@lists.xensource.com, "Wei Liu" <wei.liu2@citrix.com>, "Ian Camp=
bell" <Ian.Campbell@citrix.com>, "Ian
> Jackson" <Ian.Jackson@eu.citrix.com>, qemu-devel@nongnu.org, "Hans de Goe=
de" <hdegoede@redhat.com>,
> spice-devel@lists.freedesktop.org
> Inviato: Venerd=C3=AC, 5 luglio 2013 10:42:30
> Oggetto: Re: [Xen-devel] [PATCH] libxl: Spice usbredirection support for =
upstream qemu
>=20
> Il 04/07/2013 22:09, Paolo Bonzini ha scritto:
> > Il 04/07/2013 19:17, Andreas F=C3=A4rber ha scritto:
> >> Also if at some point you try to use, e.g., q35 rather than i440fx
> >> machine, it might have EHCI by default and the snippet would be
> >> instantiating a duplicate one. I.e., the three levels of dependency
> >> could be separated more clearly: PCI, USB, redirection.
> > At least you could start specifying the USB desired version (1.1, 2.0
> > with companion controllers, 3.0) as an extension of the "usb=3D1" that =
is
> > already supported.
> >
> > Paolo
>=20
> Thanks and sorry, I found only now that is working also with only
> -device usb-ehci,id=3Dusb.
> I'll post a new patch version.

With only the EHCI you might have problems redirecting USB 1.1 devices.
The EHCI+UHCI magic is the right thing to do for USB 2.0 support on x86.

What Andreas and I were suggesting was to split the patch in two parts:
first adding support for USB 2.0/3.0, and only then adding redirection
(perhaps with the possibility to customize how many redirected devices
to support).

Paolo