From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. [and 1 more messages]
Date: Mon, 1 Oct 2012 17:27:37 +0100 [thread overview]
Message-ID: <20585.50297.106231.155363@mariner.uk.xensource.com> (raw)
In-Reply-To: <291EDFCB1E9E224A99088639C4762022FDDCAB6EB9@LONPMAILBOX01.citrite.net>, <291EDFCB1E9E224A99088639C4762022FDDCAB6EB5@LONPMAILBOX01.citrite.net>
Paul Durrant writes ("RE: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers."):
> Ok. I thought it was helpful to reserve product number 0 for this purpose, but I'll ditch it.
Well if you want to reserve it you could put a comment in the list
saying "0 is reserved, do not use".
Paul Durrant writes ("Re: [Xen-devel] [PATCH] Use new Xen public header for product numbers and names"):
> Ian Jackson [mailto:Ian.Jackson@eu.citrix.com]:
> > As a case in point, this generates:
> > case 0: product = NULL; break;
> > and then passes the NULL to asprintf.
>
> Nothing should be using product number 0, so is this a problem?
You're joking, right ?
The guest can send any value it likes here and the result is that qemu
might dereference NULL. (Although in practice asprintf doesn't
crash on NULL strings in any implementation I'm aware of.)
Ian.
next prev parent reply other threads:[~2012-10-01 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 9:43 [PATCH] Use new Xen public header for product numbers and names Paul Durrant
2012-10-01 15:14 ` Ian Jackson
2012-10-01 16:08 ` Paul Durrant
2012-10-01 9:41 ` [PATCH 0/2] PV drivers product number registration (v2) Paul Durrant
2012-10-01 9:41 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant
2012-10-01 15:12 ` Ian Jackson
2012-10-01 16:17 ` Paul Durrant
2012-10-01 16:27 ` Ian Jackson [this message]
2012-10-01 9:41 ` [PATCH 2/2] Register Linux PV-on-HVM drivers product number Paul Durrant
2012-10-02 9:25 ` [PATCH] Use new Xen public header for product numbers and names Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20585.50297.106231.155363@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).