From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: [PATCH v3 09/52] xen/arch/x86/hvm/viridian.c: let
 custom parameter parsing routines return errno
Date: Mon, 21 Aug 2017 11:45:48 +0000
Message-ID: <20fcf7ae5e924d3d8f7299a318b6c356@AMSPEX02CL03.citrite.net>
References: <20170816125219.5255-1-jgross@suse.com>
 <20170816125219.5255-10-jgross@suse.com>
 <f4b5d46a625a4adbab7e04301f51ff14@AMSPEX02CL03.citrite.net>
 <439c7766-d776-f4d9-3d65-b570e3530a80@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=39998e063=Paul.Durrant@citrix.com>)
 id 1djl9V-0003PG-MN
 for xen-devel@lists.xenproject.org; Mon, 21 Aug 2017 11:45:53 +0000
In-Reply-To: <439c7766-d776-f4d9-3d65-b570e3530a80@suse.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: 'Juergen Gross' <jgross@suse.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWVyZ2VuIEdyb3NzIFttYWls
dG86amdyb3NzQHN1c2UuY29tXQ0KPiBTZW50OiAyMSBBdWd1c3QgMjAxNyAxMjowMg0KPiBUbzog
UGF1bCBEdXJyYW50IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT47IHhlbi1kZXZlbEBsaXN0cy54
ZW5wcm9qZWN0Lm9yZw0KPiBDYzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPjsgQW5k
cmV3IENvb3Blcg0KPiA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogUmU6
IFtQQVRDSCB2MyAwOS81Ml0geGVuL2FyY2gveDg2L2h2bS92aXJpZGlhbi5jOiBsZXQgY3VzdG9t
DQo+IHBhcmFtZXRlciBwYXJzaW5nIHJvdXRpbmVzIHJldHVybiBlcnJubw0KPiANCj4gT24gMjEv
MDgvMTcgMTA6MzMsIFBhdWwgRHVycmFudCB3cm90ZToNCj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNz
YWdlLS0tLS0NCj4gPj4gRnJvbTogSnVlcmdlbiBHcm9zcyBbbWFpbHRvOmpncm9zc0BzdXNlLmNv
bV0NCj4gPj4gU2VudDogMTYgQXVndXN0IDIwMTcgMTM6NTINCj4gPj4gVG86IHhlbi1kZXZlbEBs
aXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiA+PiBDYzogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu
Y29tPjsgUGF1bCBEdXJyYW50DQo+ID4+IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT47IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT47IEFuZHJldw0KPiA+PiBDb29wZXIgPEFuZHJldy5D
b29wZXIzQGNpdHJpeC5jb20+DQo+ID4+IFN1YmplY3Q6IFtQQVRDSCB2MyAwOS81Ml0geGVuL2Fy
Y2gveDg2L2h2bS92aXJpZGlhbi5jOiBsZXQgY3VzdG9tDQo+ID4+IHBhcmFtZXRlciBwYXJzaW5n
IHJvdXRpbmVzIHJldHVybiBlcnJubw0KPiA+Pg0KPiA+PiBNb2RpZnkgdGhlIGN1c3RvbSBwYXJh
bWV0ZXIgcGFyc2luZyByb3V0aW5lcyBpbjoNCj4gPj4NCj4gPj4geGVuL2FyY2gveDg2L2h2bS92
aXJpZGlhbi5jDQo+ID4+DQo+ID4+IHRvIGluZGljYXRlIHdoZXRoZXIgdGhlIHBhcmFtZXRlciB2
YWx1ZSB3YXMgcGFyc2VkIHN1Y2Nlc3NmdWxseS4NCj4gPj4NCj4gPj4gRml4IGFuIGVycm9yIGlu
IHRoZSBwYXJzaW5nIGZ1bmN0aW9uOiB1cCB0byBub3cgaXQgd291bGQgb3ZlcndyaXRlIHRoZQ0K
PiA+PiBzdGFjayBpbiBjYXNlIG1vcmUgdGhhbiAzIHZhbHVlcyBhcmUgc3BlY2lmaWVkLg0KPiA+
Pg0KPiA+PiBDYzogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4NCj4gPj4g
Q2M6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4gQ2M6IEFuZHJldyBDb29w
ZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+ID4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJn
ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gPj4gLS0tDQo+ID4+IFYzOg0KPiA+PiAtIGRv
bnQgbW9kaWZ5IG9wdGlvbiB2YWx1ZSBpbiBwYXJzaW5nIGZ1bmN0aW9uDQo+ID4+IC0gZml4IGVy
cm9yIGluIHBhcnNpbmcgcm91dGluZQ0KPiA+PiAtLS0NCj4gPj4gIHhlbi9hcmNoL3g4Ni9odm0v
dmlyaWRpYW4uYyB8IDI4ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0NCj4gPj4gIDEgZmls
ZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkNCj4gPj4NCj4gPj4g
ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vdmlyaWRpYW4uYyBiL3hlbi9hcmNoL3g4Ni9o
dm0vdmlyaWRpYW4uYw0KPiA+PiBpbmRleCBhYTliODdjMGFiLi4yZWRmOWQwYjIzIDEwMDY0NA0K
PiA+PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuLmMNCj4gPj4gKysrIGIveGVuL2Fy
Y2gveDg2L2h2bS92aXJpZGlhbi5jDQo+ID4+IEBAIC0xMDgzLDcgKzEwODMsNyBAQCBzdGF0aWMg
aW50IHZpcmlkaWFuX2xvYWRfdmNwdV9jdHh0KHN0cnVjdCBkb21haW4NCj4gKmQsDQo+ID4+IGh2
bV9kb21haW5fY29udGV4dF90ICpoKQ0KPiA+PiAgSFZNX1JFR0lTVEVSX1NBVkVfUkVTVE9SRShW
SVJJRElBTl9WQ1BVLA0KPiB2aXJpZGlhbl9zYXZlX3ZjcHVfY3R4dCwNCj4gPj4gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgdmlyaWRpYW5fbG9hZF92Y3B1X2N0eHQsIDEsIEhWTVNSX1BFUl9W
Q1BVKTsNCj4gPj4NCj4gPj4gLXN0YXRpYyB2b2lkIF9faW5pdCBwYXJzZV92aXJpZGlhbl92ZXJz
aW9uKGNoYXIgKmFyZykNCj4gPj4gK3N0YXRpYyBpbnQgX19pbml0IHBhcnNlX3ZpcmlkaWFuX3Zl
cnNpb24oY29uc3QgY2hhciAqYXJnKQ0KPiA+PiAgew0KPiA+PiAgICAgIGNvbnN0IGNoYXIgKnQ7
DQo+ID4+ICAgICAgdW5zaWduZWQgaW50IG5bM107DQo+ID4+IEBAIC0xMDkzLDE3ICsxMDkzLDI0
IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwYXJzZV92aXJpZGlhbl92ZXJzaW9uKGNoYXINCj4gPj4g
KmFyZykNCj4gPj4gICAgICBuWzFdID0gdmlyaWRpYW5fbWlub3I7DQo+ID4+ICAgICAgblsyXSA9
IHZpcmlkaWFuX2J1aWxkOw0KPiA+Pg0KPiA+PiAtICAgIHdoaWxlICggKHQgPSBzdHJzZXAoJmFy
ZywgIiwiKSkgIT0gTlVMTCApDQo+ID4+IC0gICAgew0KPiA+PiArICAgIGRvIHsNCj4gPj4gICAg
ICAgICAgY29uc3QgY2hhciAqZTsNCj4gPj4NCj4gPj4gLSAgICAgICAgaWYgKCAqdCA9PSAnXDAn
ICkNCj4gPj4gLSAgICAgICAgICAgIGNvbnRpbnVlOw0KPiA+PiArICAgICAgICB0ID0gc3RyY2hy
KGFyZywgJywnKTsNCj4gPj4gKyAgICAgICAgaWYgKCAhdCApDQo+ID4+ICsgICAgICAgICAgICB0
ID0gc3RyY2hyKGFyZywgJ1wwJyk7DQo+ID4+ICsNCj4gPj4gKyAgICAgICAgaWYgKCAqYXJnICYm
ICphcmcgIT0gJywnICYmIGkgPCAzICkNCj4gPj4gKyAgICAgICAgew0KPiA+PiArICAgICAgICAg
ICAgbltpXSA9IHNpbXBsZV9zdHJ0b3VsKGFyZywgJmUsIDApOw0KPiA+PiArICAgICAgICAgICAg
aWYgKCBlICE9IHQgKQ0KPiA+PiArICAgICAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4gPj4gKyAg
ICAgICAgfQ0KPiA+PiArDQo+ID4+ICsgICAgICAgIGkrKzsNCj4gPj4gKyAgICAgICAgYXJnID0g
dCArIDE7DQo+ID4+ICsgICAgfSB3aGlsZSAoICp0ICk7DQo+ID4NCj4gPiBUaGUgbG9vcCBpcyBt
dWNoIG5lYXRlciB3aGVuIHN0cnNlcCgpIGlzIHVzZWQuIENvdWxkIHlvdSBub3QganVzdCBhZGQg
YQ0KPiBjaGVjayBmb3IgaSA8IDMgYXQgdGhlIGJlZ2lubmluZz8NCj4gDQo+IE9mIGNvdXJzZSBJ
IGNvdWxkLiBPVE9IIEkgZG9uJ3QgdGhpbmsgdGhlIHJlc3VsdGluZyBjb2RlIHdvdWxkIGJlDQo+
IG5lYXRlci4gSSBjYW4ndCByZW1vdmUgdGhlIGNoZWNrIGZvciBpIGJlaW5nIDMgYWZ0ZXIgdGhl
IGxvb3AsIHNvDQo+IEknZCBoYXZlIHRvIGFkZCBzb21lIGxpbmVzIGluc3RlYWQgb2YgdGVzdGlu
ZyBpIDwgMyBpbiB0aGUgYWxyZWFkeQ0KPiBwcmVzZW50IGlmIHN0YXRlbWVudC4NCj4gDQo+IElu
IGNhc2UgeW91IGFyZSB0YXJnZXRpbmcgdG8gY29udGludWUgdXNpbmcgc3Ryc2VwKCk6IHRoaXMg
d291bGQNCj4gbW9kaWZ5IHRoZSBvcHRpb24gc3RyaW5nLiBJIHdhbnQgdG8gYXZvaWQgdGhhdCBh
cyBJIG5lZWQgaXQgdW5tb2RpZmllZA0KPiBmb3IgYmVpbmcgYWJsZSB0byB1c2UgaXQgaW4gdGhl
IGVycm9yIG1lc3NhZ2Ugb2YgcGF0Y2ggMzkuDQoNCk9rLCBJIGRvbid0IGZlZWwgdGhhdCBzdHJv
bmdseS4gSWYgeW91IGJlbGlldmUgdGhpcyBpcyB0aGUgbmVhdGVzdCB3YXkuLi4NCg0KQWNrZWQt
Ynk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+DQoNCj4gDQo+IA0KPiBK
dWVyZ2VuDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY
ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlz
dHMueGVuLm9yZy94ZW4tZGV2ZWwK