xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Bo Cao <caobosimon@gmail.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	Lars Kurth <lars.kurth@citrix.com>,
	xen-devel@lists.xensource.com,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v0 RFC 1/2] libxl: Introduce functions in libxl to add and remove USB devices for an PV guest
Date: Tue, 12 Aug 2014 17:11:29 +0100	[thread overview]
Message-ID: <21482.15537.351360.611523@mariner.uk.xensource.com> (raw)
In-Reply-To: <1407702234-22309-2-git-send-email-caobosimon@gmail.com>

Bo Cao writes ("[Xen-devel][PATCH v0 RFC 1/2] libxl: Introduce functions in libxl to add and remove USB devices for an PV guest"):
> This patch exposes a generic interface which can be expanded in the
> future to implement USB for DEVICEMODEL. 

Thanks.  Can you arrange to wrap this code to 70-75 characters
please ?  It currently is very hard to read in my mailreader.


>  /* generic callback for devices that only need to set ao_complete */
> -static void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev)
> +void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev)
>  {

Extern functions must have namespaced names.  (libxl__...)


I noticed several C++-style // comments.  We generally use /* */.


That's all I spotted right away.  I'll take a proper look when it's
less wrap-damaged.

Thanks,
Ian.

  reply	other threads:[~2014-08-12 16:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-10 20:23 [PATCH v0 RFC 0/2] xl/libxl support for PVUSB Bo Cao
2014-08-10 20:23 ` [PATCH v0 RFC 1/2] libxl: Introduce functions in libxl to add and remove USB devices for an PV guest Bo Cao
2014-08-12 16:11   ` Ian Jackson [this message]
2014-08-13 13:18     ` Simon Cao
2014-08-10 20:23 ` [PATCH v0 RFC 2/2] xl: Add commands for usb hot-plug Bo Cao
2014-08-14 15:04 ` [PATCH v0 RFC 0/2] xl/libxl support for PVUSB George Dunlap
2014-08-14 15:46   ` Simon Cao
2014-11-10  8:37 ` Chun Yan Liu
2014-11-10 15:01   ` Konrad Rzeszutek Wilk
2014-11-11  5:06     ` Juergen Gross
2014-11-16  2:36   ` Simon Cao
2014-11-19 21:32     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21482.15537.351360.611523@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=caobosimon@gmail.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=lars.kurth@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).